hermes commented on pull request dc/dc#481 2026-11-20 15:42:35 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Review 1459, findings 3 and 4. Both are answered from the files rather than changed; the first two findings are fixed in #650, against this…

hermes created pull request dc/dc#650 2026-11-20 15:42:22 +00:00
fix(client): read the licensing route by segment, in one predicate
hermes created branch fix/licensing-route-predicate in dc/dc 2026-11-20 15:42:13 +00:00
hermes pushed to fix/licensing-route-predicate at dc/dc 2026-11-20 15:42:13 +00:00
20e1d939e5 fix(client): read the licensing route by segment, in one predicate
hermes commented on pull request dc/dc#481 2026-11-20 15:36:31 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Supplements review 1459 at this head, which cannot be edited in place. Two things it does not carry: its audit finding does not hold, and the four findings below - raised and re-raised on this PR…

hermes commented on pull request dc/dc#649 2026-11-20 15:35:59 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

Addressed at 61077356 - the six code findings, in the order raised:

  1. Dead browse helpers in the mock makedata - brBrowseGate, brRoots, brFolderRow, brDirList and brWriteCheck are…
hermes pushed to fix/browse-json-in-service at dc/dc 2026-11-20 15:35:50 +00:00
6107735686 test(browse): finish the mock cleanup
hermes commented on pull request dc/dc#481 2026-11-20 15:34:18 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Review 1459, against 38f40cd1. The finding is answered from the tree, and nothing needed changing.

The audit gate survived. .gitea/workflows/build.yaml:240 is the step, unchanged in this…

hermes commented on pull request dc/dc#481 2026-11-20 15:33:38 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-20 15:33 UTC

Reviewed the release diff at 38f40cd at reduced depth: 66 files / ~2.7 MB, of which the fetched slice covers the workflows, the .gitea scripts, the pre-commit…

hermes commented on pull request dc/dc#649 2026-11-20 15:31:04 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

REVIEWED ON 2026-11-20 15:31 UTC

Re-review at head 62103eb0. The delta since ab3ab6a0 is one commit (62103eb, 13 files): the mock makedata now seeds on any request, its own ACTION refusal and its…

hermes commented on pull request dc/dc#481 2026-11-20 15:29:40 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Release body refreshed to the current head, 38f40cd1. What changed and why:

  • Merge list and count: 113 pull requests, oldest first, read from the API for every PR merged into release/7.23…
hermes commented on pull request dc/dc#649 2026-11-20 15:27:37 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

Addressed at 62103eb0. The 14 findings:

  1. Mock makedata seeds only on ACTION=MAKEDATA - the switch is gone. The seeding body is the only path, so a request with DCPATH and ADMIN and no…
hermes pushed to fix/browse-json-in-service at dc/dc 2026-11-20 15:27:28 +00:00
62103eb019 test(browse): align the mocks with the services and drop the dead ACTION
hermes commented on pull request dc/dc#649 2026-11-20 15:18:56 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

Re-review at head ab3ab6a0. The delta since the review at c2aab4cb is one commit (ab3ab6a, 13 files): the two mock services with their test files, %mp_init() in both new services with the dead…

hermes commented on pull request dc/dc#648 2026-11-20 15:18:05 +00:00
fix(client): apply a prompt change to the table, not to the route

Proven on a real estate, at 41dbb428.

Setup: this head's client build (verified: the served lazy chunk carries the new "these rows are from the previous selection" string) deployed to a scratch…

hermes commented on pull request dc/dc#649 2026-11-20 15:08:18 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

Addressed at ab3ab6a0. Each of the 11 findings:

  1. makedata ACTION validation / makedata.test.sas - the parameter is gone from all three targets, so there is no validation left to assert and…
hermes pushed to fix/browse-json-in-service at dc/dc 2026-11-20 15:08:06 +00:00
ab3ab6a06f test(browse): cover the caps and the probe, and mock the two services
hermes commented on pull request dc/dc#649 2026-11-20 14:51:47 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

Re-review at head c2aab4cb. The only change since 51d0908c is one commit - refactor(makedata): drop the ACTION parameter - which removes ACTION from all three targets, drops the mock's requirement…

hermes pushed to fix/browse-json-in-service at dc/dc 2026-11-20 14:43:34 +00:00
c2aab4cb96 refactor(makedata): drop the ACTION parameter
hermes commented on pull request dc/dc#649 2026-11-20 14:36:28 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

Re-review at head 51d0908c. The only change since 96f38a55 is one commit - test(cypress): stub the two browse services in the folder picker spec - which gates the picker's stub on admin/dirlist…