Review 1459, findings 3 and 4. Both are answered from the files rather than changed; the first two findings are fixed in #650, against this…
Supplements review 1459 at this head, which cannot be edited in place. Two things it does not carry: its audit finding does not hold, and the four findings below - raised and re-raised on this PR…
Addressed at 61077356 - the six code findings, in the order raised:
- Dead browse helpers in the mock makedata -
brBrowseGate,brRoots,brFolderRow,brDirListandbrWriteCheckare…
Review 1459, against 38f40cd1. The finding is answered from the tree, and nothing needed changing.
The audit gate survived. .gitea/workflows/build.yaml:240 is the step, unchanged in this…
REVIEWED ON 2026-11-20 15:33 UTC
Reviewed the release diff at 38f40cd at reduced depth: 66 files / ~2.7 MB, of which the fetched slice covers the workflows, the .gitea scripts, the pre-commit…
REVIEWED ON 2026-11-20 15:31 UTC
Re-review at head 62103eb0. The delta since ab3ab6a0 is one commit (62103eb, 13 files): the mock makedata now seeds on any request, its own ACTION refusal and its…
Release body refreshed to the current head, 38f40cd1. What changed and why:
- Merge list and count: 113 pull requests, oldest first, read from the API for every PR merged into
release/7.23…
Addressed at 62103eb0. The 14 findings:
- Mock makedata seeds only on ACTION=MAKEDATA - the switch is gone. The seeding body is the only path, so a request with DCPATH and ADMIN and no…
Re-review at head ab3ab6a0. The delta since the review at c2aab4cb is one commit (ab3ab6a, 13 files): the two mock services with their test files, %mp_init() in both new services with the dead…
Proven on a real estate, at 41dbb428.
Setup: this head's client build (verified: the served lazy chunk carries the new "these rows are from the previous selection" string) deployed to a scratch…
Addressed at ab3ab6a0. Each of the 11 findings:
- makedata ACTION validation / makedata.test.sas - the parameter is gone from all three targets, so there is no validation left to assert and…
Re-review at head c2aab4cb. The only change since 51d0908c is one commit - refactor(makedata): drop the ACTION parameter - which removes ACTION from all three targets, drops the mock's requirement…
Re-review at head 51d0908c. The only change since 96f38a55 is one commit - test(cypress): stub the two browse services in the folder picker spec - which gates the picker's stub on admin/dirlist…