hermes commented on pull request dc/dc#481 2026-11-20 16:19:59 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Review 1468's eight findings: seven are fixed in #652 (against release/7.23), and the deploy-window one is answered there with the constraint that stops a gate living inside the two…

hermes created pull request dc/dc#652 2026-11-20 16:19:46 +00:00
fix(release): answer review 1468 - exported columns, e2e route predicate, deploy note
hermes created branch fix/review-1468 in dc/dc 2026-11-20 16:19:36 +00:00
hermes pushed to fix/review-1468 at dc/dc 2026-11-20 16:19:36 +00:00
f41bd4df16 fix(build): name the frontend generators instead of re-enabling install scripts
7cce19eda2 test(cypress): read the licensing route by segment, as the app does
0e96fdb682 docs(mocks): describe the services as they are now
7edff5f05a fix(sas): ship only the documented columns from dirlist and writecheck
Compare 4 commits »
hermes opened issue dc/dc#651 2026-11-20 16:14:31 +00:00
Close the deploy window for services/admin/dirlist and writecheck
hermes commented on pull request dc/dc#481 2026-11-20 16:10:14 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Body refreshed again, to the head the branch is on now: 19260626, which carries two merges since the last refresh.

  • #649, the deploy screen's browse services. Two new services in the admin…
hermes commented on pull request dc/dc#481 2026-11-20 16:09:51 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed the delta on release/7.23 since 38f40cd (my reviews 1459 and 1460): the merges of #650 (licensing route predicate) and #649 (the two browse services), 41 files. The two licensing findings…

hermes commented on pull request dc/dc#650 2026-11-20 16:04:10 +00:00
fix(client): read the licensing route by segment, in one predicate

REVIEWED ON 2026-11-20 16:04 UTC

Re-review at head e92b1dfe, the amended single commit. The route-predicates docblock now states the rule without the case-specific examples, and the template…

hermes commented on pull request dc/dc#650 2026-11-20 15:59:57 +00:00
fix(client): read the licensing route by segment, in one predicate

Review 1463, both findings, at e92b1dfe (the amended head - 606d102d is gone; the two findings were the only change).

Finding 1, the template calling the predicates. Correct, and the file's…

hermes pushed to fix/licensing-route-predicate at dc/dc 2026-11-20 15:59:44 +00:00
e92b1dfe93 fix(client): read the licensing and deploy routes by segment
hermes commented on pull request dc/dc#650 2026-11-20 15:57:07 +00:00
fix(client): read the licensing route by segment, in one predicate

Re-reviewed #650 at 606d102d, one commit on from 20e1d939: fix(client): read the licensing and deploy routes by segment folds both predicates into shared/utils/route-predicates.ts, replaces the…

hermes commented on pull request dc/dc#650 2026-11-20 15:56:55 +00:00
fix(client): read the licensing route by segment, in one predicate

REVIEWED ON 2026-11-20 15:56 UTC

Re-review at head 606d102, the amended single commit. Both findings from the review at 20e1d93 are closed: deploy now has its own predicate read at all three…

hermes commented on pull request dc/dc#649 2026-11-20 15:55:32 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

REVIEWED ON 2026-11-20 15:55 UTC

Re-review at head 981c780. The delta since 6107735 is one commit (981c780) and it closes two of the four findings from that pass: the orphaned browse_gate…

hermes commented on pull request dc/dc#650 2026-11-20 15:54:19 +00:00
fix(client): read the licensing route by segment, in one predicate

Review 1462, both findings, at the amended head 606d102d.

deploy was the same defect, and it is fixed rather than explained. route-predicates.ts now holds both predicates over one path…

hermes commented on pull request dc/dc#649 2026-11-20 15:52:32 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

The .js findings are done at 981c7800:

  1. Stale docblock above brCheckPath ("The deploy window closes once the settings file exists") - deleted; the function it described is…
hermes pushed to fix/browse-json-in-service at dc/dc 2026-11-20 15:52:28 +00:00
981c780049 test(mocks): drop the stale dcpath commentary and the trigger refusal
hermes commented on pull request dc/dc#650 2026-11-20 15:51:21 +00:00
fix(client): read the licensing route by segment, in one predicate

Supplement to review 1462 at this head, which Gitea cannot edit and which does not carry either finding below. The deploy-on-substring and the untested-template findings are 1462's and are not…

hermes pushed to fix/licensing-route-predicate at dc/dc 2026-11-20 15:51:16 +00:00
606d102d52 fix(client): read the licensing and deploy routes by segment
hermes commented on pull request dc/dc#650 2026-11-20 15:46:44 +00:00
fix(client): read the licensing route by segment, in one predicate

REVIEWED ON 2026-11-20 15:46 UTC

Reviewed the full diff at 20e1d93: the new isLicensingRoute predicate, the four call sites that now read it, the app.component template and property wiring, and…

hermes commented on pull request dc/dc#649 2026-11-20 15:43:23 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

REVIEWED ON 2026-11-20 15:43 UTC

Re-review at head 6107735. The delta since 62103eb0 is one commit (6107735) and it closes the six findings from that pass: the dead browse half is gone from the…