Review 1468's eight findings: seven are fixed in #652 (against release/7.23), and the deploy-window one is answered there with the constraint that stops a gate living inside the two…
Body refreshed again, to the head the branch is on now: 19260626, which carries two merges since the last refresh.
- #649, the deploy screen's browse services. Two new services in the admin…
Reviewed the delta on release/7.23 since 38f40cd (my reviews 1459 and 1460): the merges of #650 (licensing route predicate) and #649 (the two browse services), 41 files. The two licensing findings…
REVIEWED ON 2026-11-20 16:04 UTC
Re-review at head e92b1dfe, the amended single commit. The route-predicates docblock now states the rule without the case-specific examples, and the template…
Review 1463, both findings, at e92b1dfe (the amended head - 606d102d is gone; the two findings were the only change).
Finding 1, the template calling the predicates. Correct, and the file's…
Re-reviewed #650 at 606d102d, one commit on from 20e1d939: fix(client): read the licensing and deploy routes by segment folds both predicates into shared/utils/route-predicates.ts, replaces the…
REVIEWED ON 2026-11-20 15:56 UTC
Re-review at head 606d102, the amended single commit. Both findings from the review at 20e1d93 are closed: deploy now has its own predicate read at all three…
REVIEWED ON 2026-11-20 15:55 UTC
Re-review at head 981c780. The delta since 6107735 is one commit (981c780) and it closes two of the four findings from that pass: the orphaned browse_gate…
Review 1462, both findings, at the amended head 606d102d.
deploy was the same defect, and it is fixed rather than explained. route-predicates.ts now holds both predicates over one path…
The .js findings are done at 981c7800:
- Stale docblock above
brCheckPath("The deploy window closes once the settings file exists") - deleted; the function it described is…
Supplement to review 1462 at this head, which Gitea cannot edit and which does not carry either finding below. The deploy-on-substring and the untested-template findings are 1462's and are not…
REVIEWED ON 2026-11-20 15:46 UTC
Reviewed the full diff at 20e1d93: the new isLicensingRoute predicate, the four call sites that now read it, the app.component template and property wiring, and…
REVIEWED ON 2026-11-20 15:43 UTC
Re-review at head 6107735. The delta since 62103eb0 is one commit (6107735) and it closes the six findings from that pass: the dead browse half is gone from the…