Re-review at 41dbb428. The branch is one rewritten commit, so the delta from a113a082 (the head review 1452 sat on) was read from that commit's files rather than by compare: applyVaFilter now…
Answered at 41dbb428.
The finding: when saveQuery answered without a FILTER_RK, the branch set the status to idle and returned - but the signature recorded at the top of the call still…
The branch was rewritten since the last review at 87876fac, which is no longer reachable, so this reviews the full diff against release/7.23 at a113a082 rather than a delta. The three findings…
Supplement to the review at this head (id 1450), which could not be edited into that one: two of its claims are answered below, then the findings it does not carry. Reviewed at head 96f38a55;…
REVIEWED ON 2026-11-20 14:13 UTC
Reviewed the full diff: split of the two browse actions out of makedata into services/admin/dirlist.sas and services/admin/writecheck.sas, the client switch, the…
All three answered at a113a082.
1. A bare updateSettings on a sorted grid - initSetup's settled-grid call now goes through updateSettingsSortSafe (the hot.updateSettings( at what was…
Reviewed the delta from 641eabdff to 87876fac (base bc00f58) and the full diff at this head. The push answers every finding from the review at 641eabdff - the filter key is restored when a…
All five answered at 87876fac.
1. A failed clear dropped the key for good (:5375) - loadWithFilter keeps the key it is replacing in a local and puts it back when the read fails, so the…
Reviewed the full diff at 641eabdff4e0 (base c2b74215), not a delta: the branch was rewritten again and the earlier head 5e2abfe6 is no longer fetchable, so the reviews before this one sit on shas…
CI failed at 5e2abfe6 in Build-and-ng-test, step 25 (Production Build) - and it was a fair catch that the unit suite cannot…
Reviewed the full diff at 5e2abfe6. The branch is one rewritten commit, so this covers the whole change against base c2b74215 rather than a delta; the earlier review's two findings are answered…
Both answered at 5e2abfe6.
1. The first filter still navigated, so the address kept a stale key - rather than keeping the address in step (a replaceUrl navigation crosses from :libMem to…
Reviewed the full diff at 245384bc. The branch is one rewritten commit again, so this covers the whole change against base c2b74215 rather than a delta - the earlier reviews (1439-1443) all sit on…