hermes pushed to fix/browse-json-in-service at dc/dc 2026-11-20 14:33:58 +00:00
51d0908c0f test(cypress): stub the two browse services in the folder picker spec
hermes commented on pull request dc/dc#648 2026-11-20 14:27:28 +00:00
fix(client): apply a prompt change to the table, not to the route

Re-review at 41dbb428. The branch is one rewritten commit, so the delta from a113a082 (the head review 1452 sat on) was read from that commit's files rather than by compare: applyVaFilter now…

hermes commented on pull request dc/dc#648 2026-11-20 14:23:18 +00:00
fix(client): apply a prompt change to the table, not to the route

Answered at 41dbb428.

The finding: when saveQuery answered without a FILTER_RK, the branch set the status to idle and returned - but the signature recorded at the top of the call still…

hermes pushed to fix/embed-prompt-apply-inplace at dc/dc 2026-11-20 14:23:09 +00:00
41dbb428e2 fix(client): apply a prompt change to the table, not to the route
hermes commented on pull request dc/dc#648 2026-11-20 14:16:41 +00:00
fix(client): apply a prompt change to the table, not to the route

The branch was rewritten since the last review at 87876fac, which is no longer reachable, so this reviews the full diff against release/7.23 at a113a082 rather than a delta. The three findings…

hermes commented on pull request dc/dc#649 2026-11-20 14:14:57 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

Supplement to the review at this head (id 1450), which could not be edited into that one: two of its claims are answered below, then the findings it does not carry. Reviewed at head 96f38a55;…

hermes commented on pull request dc/dc#649 2026-11-20 14:13:34 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

REVIEWED ON 2026-11-20 14:13 UTC

Reviewed the full diff: split of the two browse actions out of makedata into services/admin/dirlist.sas and services/admin/writecheck.sas, the client switch, the…

hermes commented on pull request dc/dc#648 2026-11-20 14:08:35 +00:00
fix(client): apply a prompt change to the table, not to the route

All three answered at a113a082.

1. A bare updateSettings on a sorted grid - initSetup's settled-grid call now goes through updateSettingsSortSafe (the hot.updateSettings( at what was…

hermes pushed to fix/embed-prompt-apply-inplace at dc/dc 2026-11-20 14:08:27 +00:00
a113a08246 fix(client): apply a prompt change to the table, not to the route
hermes pushed to fix/browse-json-in-service at dc/dc 2026-11-20 14:04:19 +00:00
96f38a5532 feat(browse): two dedicated services for the deploy screen's folder questions
hermes commented on pull request dc/dc#648 2026-11-20 14:02:52 +00:00
fix(client): apply a prompt change to the table, not to the route

Reviewed the delta from 641eabdff to 87876fac (base bc00f58) and the full diff at this head. The push answers every finding from the review at 641eabdff - the filter key is restored when a…

hermes commented on pull request dc/dc#648 2026-11-20 13:56:34 +00:00
fix(client): apply a prompt change to the table, not to the route

All five answered at 87876fac.

1. A failed clear dropped the key for good (:5375) - loadWithFilter keeps the key it is replacing in a local and puts it back when the read fails, so the…

hermes pushed to fix/embed-prompt-apply-inplace at dc/dc 2026-11-20 13:56:23 +00:00
87876fac6f fix(client): apply a prompt change to the table, not to the route
hermes commented on pull request dc/dc#648 2026-11-20 13:50:11 +00:00
fix(client): apply a prompt change to the table, not to the route

Reviewed the full diff at 641eabdff4e0 (base c2b74215), not a delta: the branch was rewritten again and the earlier head 5e2abfe6 is no longer fetchable, so the reviews before this one sit on shas…

hermes commented on pull request dc/dc#648 2026-11-20 13:38:48 +00:00
fix(client): apply a prompt change to the table, not to the route

CI failed at 5e2abfe6 in Build-and-ng-test, step 25 (Production Build) - and it was a fair catch that the unit suite cannot…

hermes pushed to fix/embed-prompt-apply-inplace at dc/dc 2026-11-20 13:38:41 +00:00
641eabdff4 fix(client): apply a prompt change to the table, not to the route
hermes commented on pull request dc/dc#648 2026-11-20 13:38:11 +00:00
fix(client): apply a prompt change to the table, not to the route

Reviewed the full diff at 5e2abfe6. The branch is one rewritten commit, so this covers the whole change against base c2b74215 rather than a delta; the earlier review's two findings are answered…

hermes commented on pull request dc/dc#648 2026-11-20 13:30:30 +00:00
fix(client): apply a prompt change to the table, not to the route

Both answered at 5e2abfe6.

1. The first filter still navigated, so the address kept a stale key - rather than keeping the address in step (a replaceUrl navigation crosses from :libMem to…

hermes pushed to fix/embed-prompt-apply-inplace at dc/dc 2026-11-20 13:30:17 +00:00
5e2abfe6c8 fix(client): apply a prompt change to the table, not to the route
hermes commented on pull request dc/dc#648 2026-11-20 13:24:16 +00:00
fix(client): apply a prompt change to the table, not to the route

Reviewed the full diff at 245384bc. The branch is one rewritten commit again, so this covers the whole change against base c2b74215 rather than a delta - the earlier reviews (1439-1443) all sit on…