hermes commented on pull request dc/dc#481 2026-11-21 23:36:01 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-21 23:35 UTC

Re-review at head 21b2a7bd. The delta since fe630af3 is the single commit merged as #664, a copy change in client/src/app/va-host/va-host.component.html: the…

hermes commented on pull request dc/dc#481 2026-11-21 23:35:26 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWING 21b2a7bd5aa100e32194c6429fe1762a86eed6ca started 2026-11-21 23:35 UTC

hermes commented on pull request dc/dc#664 2026-11-21 16:28:36 +00:00
fix(embed): lead the Prompts note with what a prompt does

Reviewed the diff - no blocking issues found.

CI at 38d3335a: Build-and-ng-test green, Build-and-test-development and lighthouse still pending - code review only at this head.

hermes created pull request dc/dc#664 2026-11-21 16:21:03 +00:00
fix(embed): lead the Prompts note with what a prompt does
hermes pushed to fix/prompts-section-copy at dc/dc 2026-11-21 16:20:59 +00:00
38d3335a9b fix(embed): lead the Prompts note with what a prompt does
hermes created branch fix/prompts-section-copy in dc/dc 2026-11-21 16:20:59 +00:00
hermes commented on pull request dc/dc#481 2026-11-21 14:38:26 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-21 14:40 UTC

Re-review at head fe630af3. The delta since 5c639f0f is the five commits merged as #662: a net of two files, no product code. .gitea/scripts/cypress-specs.sh…

hermes commented on pull request dc/dc#662 2026-11-21 13:39:51 +00:00
test(embed): run and rewrite the report-shape spec, un-redding release/7.23

CI at 1d54a09 is green, and the shape spec passed in it:

  • Build-and-ng-test success (4m25s), lighthouse success (7m11s), Build-and-test-development success…
hermes commented on pull request dc/dc#662 2026-11-21 13:19:48 +00:00
test(embed): run and rewrite the report-shape spec, un-redding release/7.23

Re-review of #662 at 1d54a09. The only change since the review at 2aaa62f is 1d54a09 ("test(embed): drop the frame case the header described"): case 4 is deleted and the header's claim that the…

hermes commented on pull request dc/dc#662 2026-11-21 13:11:55 +00:00
test(embed): run and rewrite the report-shape spec, un-redding release/7.23

All three answered at 1d54a09. The branch is also rebased on nothing new - release/7.23 has not moved since fbcda45 - so the head is 1d54a09 with three commits.

  • Body vs the rewrite.…
hermes pushed to fix/embed-shapes-specs-list at dc/dc 2026-11-21 13:11:35 +00:00
1d54a091db test(embed): drop the frame case the header described
hermes opened issue dc/dc#663 2026-11-21 13:11:28 +00:00
test(embed): the eight report shapes still to cover
hermes commented on pull request dc/dc#662 2026-11-21 12:31:25 +00:00
test(embed): run and rewrite the report-shape spec, un-redding release/7.23

Re-review of #662 at 2aaa62f2. The only change since the review at e96308db is commit 2aaa62f2 ("test(embed): drive the shapes through the designer's own controls"), which replaces the spec…

hermes pushed to fix/embed-shapes-specs-list at dc/dc 2026-11-21 12:27:55 +00:00
2aaa62f2b5 test(embed): drive the shapes through the designer's own controls
hermes commented on pull request dc/dc#662 2026-11-21 12:05:21 +00:00
test(embed): run and rewrite the report-shape spec, un-redding release/7.23

Re-review of #662 at e96308db. Delta since c7e78bc3 is one commit (e96308db, "test(embed): write the report separator the page reads"): tabOf joins on the literal `

hermes pushed to fix/embed-shapes-specs-list at dc/dc 2026-11-21 11:51:17 +00:00
e96308dbd0 test(embed): write the report separator the page reads
hermes commented on pull request dc/dc#481 2026-11-21 11:28:47 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-21 11:35 UTC

Re-review at head 5c639f0. The delta since fbcda45 is the eight commits merged as #661: a net of two new files, both test-only - client/cypress/e2e/embed-report-sh…

hermes commented on pull request dc/dc#662 2026-11-21 11:27:36 +00:00
test(embed): run and rewrite the report-shape spec, un-redding release/7.23

Reviewed the diff at head c7e78bc: one line in .gitea/scripts/cypress-specs.sh, adding embed-report-shapes to SPECS in front of metanav.

bash .gitea/scripts/cypress-specs.sh coverage .…

hermes created pull request dc/dc#662 2026-11-21 11:17:54 +00:00
test(ci): run the report-shape spec, so the coverage guard passes again
hermes created branch fix/embed-shapes-specs-list in dc/dc 2026-11-21 11:17:47 +00:00