hermes pushed to fix/review-1471 at dc/dc 2026-11-20 17:23:25 +00:00
4660fb9030 test(client): read the route once, in the app's own predicates
hermes commented on pull request dc/dc#654 2026-11-20 17:18:46 +00:00
test(cypress): answer review 1471/1472/1473 - one route reader, two licensing predicates, the build steps

Retroactive review of #654 at head 0e2cc550, merged into release/7.23 as cd7f8598 at 17:17Z before any review was posted at this head. Reviewed the full base...head diff as written, not the merge…

hermes commented on pull request dc/dc#481 2026-11-20 17:12:21 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Review 1473 answered on #654 as 0e2cc550.

  • Normalisation is in one place now. routeOf moved to client/src/app/shared/utils/route-predicates.ts (the module that already owns route…
hermes pushed to fix/review-1471 at dc/dc 2026-11-20 17:12:04 +00:00
0e2cc55028 test(cypress): normalise the route once, and pin it
hermes commented on pull request dc/dc#654 2026-11-20 17:07:42 +00:00
test(cypress): answer review 1471/1472/1473 - one route reader, two licensing predicates, the build steps

Supplement to review 1473 - Gitea has no review edit, so the corrections sit here. The two findings raised at ef7aaa87 are closed at this head (commands.ts:475 reads the card through routeOf, and…

hermes commented on pull request dc/dc#654 2026-11-20 17:06:15 +00:00
test(cypress): answer review 1471/1472/1473 - one route reader, two licensing predicates, the build steps

REVIEWED ON 2026-11-20 17:06 UTC

Reviewed the full base...head diff (CONTRIBUTING.md, licensing.cy.ts, support/commands.ts, cypress/util/helper-functions.ts) at the new head; findings are on the…

hermes commented on pull request dc/dc#481 2026-11-20 16:54:18 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Review 1472's two findings are fixed in #654, pushed as d4b7dcb7 on the same branch.

  • commands.ts:471 - acceptTermsIfPresented now asks routeOf(url) === '/licensing/register' instead of…
hermes pushed to fix/review-1471 at dc/dc 2026-11-20 16:54:11 +00:00
d4b7dcb714 test(cypress): read the registration card and the key page by route, not text
hermes commented on pull request dc/dc#654 2026-11-20 16:52:12 +00:00
test(cypress): answer review 1471/1472/1473 - one route reader, two licensing predicates, the build steps

Reviewed the full base...head diff at ef7aaa87 (one commit: the two licensing predicates renamed apart, a new isLicenseKeyTabsUrl, and the CONTRIBUTING step list split up). The predicate…

hermes commented on pull request dc/dc#481 2026-11-20 16:44:54 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Review 1471's two findings are fixed in #654, against release/7.23 (head ef7aaa87).

  • The two licensing helpers are now two exported predicates with distinct names, side by side in…
hermes created pull request dc/dc#654 2026-11-20 16:44:47 +00:00
fix(release): answer review 1471 - the two licensing questions, and the build steps in CONTRIBUTING
hermes created branch fix/review-1471 in dc/dc 2026-11-20 16:44:38 +00:00
hermes pushed to fix/review-1471 at dc/dc 2026-11-20 16:44:38 +00:00
ef7aaa87fb test(cypress): name the two licensing questions apart
hermes commented on pull request dc/dc#481 2026-11-20 16:42:33 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed the delta on release/7.23 since 404b6879 (my review 1470): the merge of #653, three commits and four files (CONTRIBUTING.md, client/cypress/e2e/licensing.cy.ts, client/cypress/support/comm…

hermes commented on pull request dc/dc#481 2026-11-20 16:35:07 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Review 1470 answered in #652... correction: in a new PR, #653. Both findings, at 404b6879:

  • licensing.cy.ts:672 - fixed there and only there. routeOf reduces the address bar to the route,…
hermes created pull request dc/dc#653 2026-11-20 16:35:06 +00:00
fix(release): answer review 1470 - the key-tabs helper and the build scripts
hermes created branch fix/review-1470 in dc/dc 2026-11-20 16:34:51 +00:00
hermes pushed to fix/review-1470 at dc/dc 2026-11-20 16:34:51 +00:00
450511396b docs: describe build-frontend's chained scripts, not the removed flag
3d9eb1ea5f test(cypress): keep the registration card out of the key-tabs helper
Compare 2 commits »
hermes commented on pull request dc/dc#481 2026-11-20 16:31:21 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed the delta on release/7.23 since 19260626 (my review 1468): the merge of #652, five commits and 12 files, and the merge commit's diff is exactly the four commits under it, so nothing came…

hermes commented on pull request dc/dc#481 2026-11-20 16:28:23 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Body refreshed to the head the branch is on now: 404b6879, which is #652 merged (the answer to review 1468). Three things moved, all re-read at that head rather than carried…