Retroactive review of #654 at head 0e2cc550, merged into release/7.23 as cd7f8598 at 17:17Z before any review was posted at this head. Reviewed the full base...head diff as written, not the merge…
Review 1473 answered on #654 as 0e2cc550.
- Normalisation is in one place now.
routeOfmoved toclient/src/app/shared/utils/route-predicates.ts(the module that already owns route…
Supplement to review 1473 - Gitea has no review edit, so the corrections sit here. The two findings raised at ef7aaa87 are closed at this head (commands.ts:475 reads the card through routeOf, and…
REVIEWED ON 2026-11-20 17:06 UTC
Reviewed the full base...head diff (CONTRIBUTING.md, licensing.cy.ts, support/commands.ts, cypress/util/helper-functions.ts) at the new head; findings are on the…
Review 1472's two findings are fixed in #654, pushed as d4b7dcb7 on the same branch.
commands.ts:471-acceptTermsIfPresentednow asksrouteOf(url) === '/licensing/register'instead of…
Reviewed the full base...head diff at ef7aaa87 (one commit: the two licensing predicates renamed apart, a new isLicenseKeyTabsUrl, and the CONTRIBUTING step list split up). The predicate…
Review 1471's two findings are fixed in #654, against release/7.23 (head ef7aaa87).
- The two licensing helpers are now two exported predicates with distinct names, side by side in…
Reviewed the delta on release/7.23 since 404b6879 (my review 1470): the merge of #653, three commits and four files (CONTRIBUTING.md, client/cypress/e2e/licensing.cy.ts, client/cypress/support/comm…
Review 1470 answered in #652... correction: in a new PR, #653. Both findings, at 404b6879:
licensing.cy.ts:672- fixed there and only there.routeOfreduces the address bar to the route,…
Reviewed the delta on release/7.23 since 19260626 (my review 1468): the merge of #652, five commits and 12 files, and the merge commit's diff is exactly the four commits under it, so nothing came…
Body refreshed to the head the branch is on now: 404b6879, which is #652 merged (the answer to review 1468). Three things moved, all re-read at that head rather than carried…