hermes commented on pull request dc/dc#657 2026-11-20 18:49:01 +00:00
fix(mocks): the load path and the saved-filter read, measured against the SAS services

Supplements review 1479 at this head, posted separately because Gitea reviews cannot be edited in place. It carries one correction to a finding in that review and one finding it does not have.

-…

hermes commented on pull request dc/dc#656 2026-11-20 18:48:25 +00:00
fix(embed): carry the page's embed switches onto the next page

Reviewed the diff at 5dbef57 (the new embed-params helper, its call sites, two component specs). CI at this head: Build-and-ng-test green, Build-and-test-development and lighthouse still running,…

hermes commented on pull request dc/dc#657 2026-11-20 18:48:25 +00:00
fix(mocks): the load path and the saved-filter read, measured against the SAS services

REVIEWED ON 2026-11-20 18:48 UTC

Reviewed the full diff: the load path (informat reading, refusals, MPE_LOADS ledger), the saved-filter read in editors/getdata and public/viewdata, and the new…

hermes commented on pull request dc/dc#656 2026-11-20 18:37:35 +00:00
fix(embed): carry the page's embed switches onto the next page

The approve journey is covered in this head (5dbef57c): the suggestion is that an embedded header=0 page can load/edit -> Submit -> APPROVE -> back to where it started with no header inside…

hermes pushed to fix/embed-header-across-navigation at dc/dc 2026-11-20 18:37:27 +00:00
5dbef57cdb fix(embed): carry the page's embed switches onto the next page
hermes created pull request dc/dc#657 2026-11-20 18:33:18 +00:00
fix(mocks): the load path and the saved-filter read, measured against the SAS services
hermes created branch fix/parity-embed-load in dc/dc 2026-11-20 18:33:07 +00:00
hermes pushed to fix/parity-embed-load at dc/dc 2026-11-20 18:33:07 +00:00
0d2682e085 test(parity): let a scenario carry an uploaded file, so a load can be recorded
6d3b07dc89 fix(mocks): answer a saved filter the way the view screen's read answers it
c08f68317c fix(mocks): read an upload the way the loader reads it, and keep the load ledger
2ec3ec0527 fix(mocks): refuse what loadfile and the loader refuse, and answer what they answer
Compare 4 commits »
hermes created pull request dc/dc#656 2026-11-20 18:31:51 +00:00
fix(embed): carry the page's embed switches onto the next page
hermes pushed to fix/embed-header-across-navigation at dc/dc 2026-11-20 18:31:45 +00:00
63f0dc4706 fix(embed): carry the page's embed switches onto the next page
hermes created branch fix/embed-header-across-navigation in dc/dc 2026-11-20 18:31:45 +00:00
hermes commented on pull request dc/dc#481 2026-11-20 17:37:09 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

#655 merged at 5491cba9, so the body has moved to that head: merge list 118 ending at #655, and the verification marker names 5491cba9.

Two corrections to what the verification section said while…

hermes commented on pull request dc/dc#481 2026-11-20 17:32:30 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed PR #481 at 5491cba9. The delta since cd7f8598, the sha review 1476 was posted at, is the merge of #655 and nothing else. I reviewed #655's own diff in full before it merged - both…

hermes commented on pull request dc/dc#481 2026-11-20 17:29:08 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-20 17:29 UTC

Reviewed the 7.23 release diff (408 files) at reduced depth: package.json and the lockfile, the workflow changes, the new client utilities and the two new admin…

hermes commented on pull request dc/dc#481 2026-11-20 17:24:10 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Review 1474's three findings are fixed in #655, against release/7.23 at cd7f8598. Note the ordering: #654 merged at 17:17, the review landed after that, so the fix is a fresh branch off the…

hermes created pull request dc/dc#655 2026-11-20 17:24:01 +00:00
test(client): answer review 1474 - one route reader for the predicates and the e2e helpers
hermes deleted branch fix/review-1471 from dc/dc 2026-11-20 17:23:50 +00:00
hermes created branch fix/review-1474 in dc/dc 2026-11-20 17:23:49 +00:00
hermes pushed to fix/review-1474 at dc/dc 2026-11-20 17:23:49 +00:00
d3bda5ab98 test(client): read the route once, in the app's own predicates
hermes created branch fix/review-1471 in dc/dc 2026-11-20 17:23:25 +00:00