hermes pushed to feat/hook-marker at dc/dc 2026-11-13 14:34:25 +00:00
1b3905d1f2 test(cypress): assert the hook marker is a visible glyph, and selective
hermes pushed to feat/hook-marker at dc/dc 2026-11-13 14:31:17 +00:00
980f02d749 test(cypress): cover the no-op demo pre-edit hook
hermes pushed to feat/hook-marker at dc/dc 2026-11-13 14:30:10 +00:00
aa61f72e47 test(demo): give DC_DEMO.DEMO_ORDERS a no-op PRE_EDIT hook
hermes pushed to feat/va-debug-logs at dc/dc 2026-11-13 14:29:23 +00:00
6ffbc3796b test(cypress): re-bootstrap the app between the two debug visits
hermes commented on pull request dc/dc#594 2026-11-13 14:24:35 +00:00
chore(deps): bump @sasjs/adapter to 6.1.0

Reviewed the diff at c94f7967 - @sasjs/adapter 6.0.2 -> 6.1.0 in client/package.json and client/package-lock.json.

  • client/src/app/shared/utils/api-base.ts:1-5 imports apiBaseFromPathSASJS /…
hermes created pull request dc/dc#594 2026-11-13 14:14:27 +00:00
chore(deps): bump @sasjs/adapter to 6.1.0
hermes pushed to chore/adapter-6.1.0 at dc/dc 2026-11-13 14:14:20 +00:00
c94f796722 chore(deps): bump @sasjs/adapter to 6.1.0
hermes created branch chore/adapter-6.1.0 in dc/dc 2026-11-13 14:14:19 +00:00
hermes commented on pull request dc/dc#593 2026-11-13 14:12:34 +00:00
feat(client): a SAS logs button in the editor toolbar, and a debug switch

Reviewed the diff at 0d904c2d (new PR, 14 files) - no blocking issues found.

CI at this head: Build-and-ng-test and lighthouse success, Build-and-test-development (which runs the cypress suite)…

hermes commented on pull request dc/dc#592 2026-11-13 14:12:14 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review at d221f8f0. The delta since my review at 2c90a6d7 is one commit (d221f8f0: the cypress assertions read the pill and its aria-label instead of the old title text, in embed-va.cy.ts,…

hermes pushed to feat/hook-marker at dc/dc 2026-11-13 14:04:40 +00:00
d221f8f022 test(cypress): read the rows/columns pill instead of the old title text
hermes created pull request dc/dc#593 2026-11-13 13:57:05 +00:00
feat(client): open the SAS log from a VA embed with debug=true
hermes pushed to feat/va-debug-logs at dc/dc 2026-11-13 13:56:57 +00:00
0d904c2d76 feat(va-host): a debug switch for the embedded object's URL
296d55fa9b fix(va-host): mark uploaded file members as base64
6a756f8e89 feat(client): open the SAS log from a VA embed with debug=true
Compare 3 commits »
hermes created branch feat/va-debug-logs in dc/dc 2026-11-13 13:56:56 +00:00
hermes created pull request dc/docs.datacontroller.io#33 2026-11-13 13:55:09 +00:00
docs(va): the SAS log from inside an embedded object
hermes pushed to docs/va-debug-logs at dc/docs.datacontroller.io 2026-11-13 13:54:52 +00:00
9afbbef571 docs(va): the SAS log from inside an embedded object
hermes created branch docs/va-debug-logs in dc/docs.datacontroller.io 2026-11-13 13:54:51 +00:00
hermes commented on pull request dc/dc#592 2026-11-13 13:42:55 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Reviewed the diff at 2c90a6d7 (new PR, 16 files). The service path is wired correctly: %global ... pre_edit_hook (getdata.sas:189-190) is cleared at :206, filled by the MPE_TABLES select at :219…

hermes commented on pull request dc/dc#592 2026-11-13 13:21:11 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Rendered from this branch, so the reviewer can see the result without building it:

https://paste.4gl.io/?d7b801b7d5622d5e#GLw5pCJ79F4VVNKq3kELpiy88NYCh4KZhsEsvRnJJ4bQ

The attachment on that…

hermes created pull request dc/dc#592 2026-11-13 13:20:43 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook