hermes pushed to feat/hook-marker at dc/dc 2026-11-13 13:20:32 +00:00
2c90a6d796 feat(editor): mark a table whose rows pass through a PRE_EDIT hook
hermes created branch feat/hook-marker in dc/dc 2026-11-13 13:20:32 +00:00
hermes commented on pull request dc/dc#481 2026-11-12 20:42:20 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Re-review of #481 at head ebfd3c94a9c002588d89cad005da611167657103 (release/7.23 into main). Delta since the review at 49164998713a62f53a5205dbf1da4a8203cae6c2: 11 commits over 21 files - the…

hermes commented on pull request dc/dc#591 2026-11-12 17:59:25 +00:00
fix(client): centre the LOAD screen's info icon with the table name

Reviewed the diff at a650bdf (one hunk in client/src/app/editor/editor.component.html) - no blocking issues found.

The classes the hunk introduces all resolve: clr-flex-column and…

hermes commented on pull request dc/dc#590 2026-11-12 17:45:11 +00:00
fix(client): close the SAS logs modal when the backdrop is clicked

Reviewed PR #590 at 0bfe297 against release/7.23 - all 25 closable clr-modal tags, the templates left static, and the two rendered-backdrop specs, reproduced locally (scoped karma over confirm-moda…

hermes created pull request dc/dc#591 2026-11-12 17:44:23 +00:00
fix(client): centre the LOAD screen's info icon with the table name
hermes pushed to fix/load-title-alignment at dc/dc 2026-11-12 17:44:15 +00:00
a650bdf3af fix(client): centre the LOAD screen's info icon with the table name
hermes created branch fix/load-title-alignment in dc/dc 2026-11-12 17:44:14 +00:00
hermes pushed to fix/logs-modal-backdrop at dc/dc 2026-11-12 17:37:16 +00:00
0bfe297731 fix(client): close the remaining modals when the backdrop is clicked
hermes created pull request dc/dc#590 2026-11-12 17:28:16 +00:00
fix(client): close the SAS logs modal when the backdrop is clicked
hermes pushed to fix/logs-modal-backdrop at dc/dc 2026-11-12 17:28:08 +00:00
491accc12f fix(client): close the SAS logs modal when the backdrop is clicked
hermes created branch fix/logs-modal-backdrop in dc/dc 2026-11-12 17:28:08 +00:00
hermes commented on pull request dc/dc#481 2026-11-12 15:45:09 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Supplement to the review at this head (id 1118). That body already carries the primaryKeyUniqueness display finding and the withdrawal of the noMalformedMacroCalls finding, which I reached…

hermes commented on pull request dc/dc#481 2026-11-12 15:21:35 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Re-review of #481 at head ea933f9f. The delta since the review at 49164998 is six commits netting #588 (a trailing row whose only value is a zero key is kept) and #589 (a one-command npm run…

hermes commented on pull request dc/dc#589 2026-11-12 11:04:41 +00:00
fix(build): add a one-command deploy and run the frontend's npm scripts

Re-review of dc/dc#589 at 23e71941 against release/7.23 (49164998). The branch is a single commit again and the delta since 6c789a94 is package.json:18 plus the CONTRIBUTING.md paragraph; it…

hermes commented on pull request dc/dc#588 2026-11-12 11:04:39 +00:00
fix(client): keep a trailing row whose only value is a zero key

Re-review of dc/dc#588 at cc13ba34 against release/7.23 (49164998). The only change since de52bc7f is cc13ba34 ("test(client): cover composite keys, numeric and character, on the trim path"), and…

hermes commented on pull request dc/dc#588 2026-11-12 10:49:41 +00:00
fix(client): keep a trailing row whose only value is a zero key

Composite coverage added in cc13ba34, mixing the two column types.

On the trim path the key has no shape - the trim asks only whether a row holds any value - but the composite case was only…

hermes pushed to fix/trailing-zero-key-row at dc/dc 2026-11-12 10:49:34 +00:00
cc13ba3489 test(client): cover composite keys, numeric and character, on the trim path
hermes commented on pull request dc/dc#589 2026-11-12 10:44:24 +00:00
fix(build): add a one-command deploy and run the frontend's npm scripts

Addressed in 23e71941.

Confirmed the redundancy before editing, in a scratch package whose .npmrc holds ignore-scripts=true with postinstall, prebuild and build hooks defined (npm…

hermes pushed to feat/deploy-script at dc/dc 2026-11-12 10:44:14 +00:00
23e719416e fix(build): add a one-command deploy and run the frontend's npm scripts