Re-review of #481 at head ebfd3c94a9c002588d89cad005da611167657103 (release/7.23 into main). Delta since the review at 49164998713a62f53a5205dbf1da4a8203cae6c2: 11 commits over 21 files - the…
Reviewed the diff at a650bdf (one hunk in client/src/app/editor/editor.component.html) - no blocking issues found.
The classes the hunk introduces all resolve: clr-flex-column and…
Reviewed PR #590 at 0bfe297 against release/7.23 - all 25 closable clr-modal tags, the templates left static, and the two rendered-backdrop specs, reproduced locally (scoped karma over confirm-moda…
Supplement to the review at this head (id 1118). That body already carries the primaryKeyUniqueness display finding and the withdrawal of the noMalformedMacroCalls finding, which I reached…
Re-review of #481 at head ea933f9f. The delta since the review at 49164998 is six commits netting #588 (a trailing row whose only value is a zero key is kept) and #589 (a one-command npm run…
Re-review of dc/dc#589 at 23e71941 against release/7.23 (49164998). The branch is a single commit again and the delta since 6c789a94 is package.json:18 plus the CONTRIBUTING.md paragraph; it…
Re-review of dc/dc#588 at cc13ba34 against release/7.23 (49164998). The only change since de52bc7f is cc13ba34 ("test(client): cover composite keys, numeric and character, on the trim path"), and…
Composite coverage added in cc13ba34, mixing the two column types.
On the trim path the key has no shape - the trim asks only whether a row holds any value - but the composite case was only…
Addressed in 23e71941.
Confirmed the redundancy before editing, in a scratch package whose .npmrc holds ignore-scripts=true with postinstall, prebuild and build hooks defined (npm…