hermes commented on pull request dc/dc#593 2026-11-13 16:52:51 +00:00
feat(client): a SAS logs button in the editor toolbar, and a debug switch

Re-review at b7710d7a. The delta since my review at 5d0309ee is one commit (b7710d7a, client + cypress): the SAS logs button moves from the head of the @if (tableTrue) toolbar to its end in…

hermes pushed to docs/va-debug-logs at dc/docs.datacontroller.io 2026-11-13 16:47:46 +00:00
72f31c2e35 docs(va): the SAS log from inside an embedded object
hermes pushed to feat/va-debug-logs at dc/dc 2026-11-13 16:47:37 +00:00
b7710d7ab2 feat(client): SAS logs is the last button in the toolbar
hermes commented on pull request dc/dc#593 2026-11-13 15:50:05 +00:00
feat(client): a SAS logs button in the editor toolbar, and a debug switch

Design changed after owner feedback at the two-switch shape, so the branch is now two commits and the diff is the final one:

  • log_button_in_edit_row=true puts the SAS Logs button in the…
hermes commented on pull request dc/dc#593 2026-11-13 15:35:44 +00:00
feat(client): a SAS logs button in the editor toolbar, and a debug switch

Re-review at 5d0309ee. The delta since my review at fc9266d7 is one commit (5d0309ee, cypress only): case 14 in client/cypress/e2e/embed-va.cy.ts now compares the SAS logs button's vertical centre…

hermes pushed to feat/va-debug-logs at dc/dc 2026-11-13 15:22:34 +00:00
5d0309ee0c test(cypress): measure the logs button against the toolbar, not its siblings
hermes commented on pull request dc/dc#592 2026-11-13 15:18:44 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review at c7018447. The delta since my review at a2f0f335 is two commits: c32fefae bumps @sasjs/adapter to 6.1.0 (pinned exactly in client/package.json, lockfile moved with it), and c7018447…

hermes commented on pull request dc/dc#593 2026-11-13 15:07:10 +00:00
feat(client): a SAS logs button in the editor toolbar, and a debug switch

Re-review at fc9266d7. The delta since my review at 6ffbc379 is one commit (fc9266d7, va-host only: host.js, index.html, deploy.mjs, README - the two diagnostic URL switches). The client-side…

hermes closed pull request dc/dc#594 2026-11-13 15:04:22 +00:00
chore(deps): bump @sasjs/adapter to 6.1.0
hermes commented on pull request dc/dc#594 2026-11-13 15:04:19 +00:00
chore(deps): bump @sasjs/adapter to 6.1.0

Rolled into #592, which is where the diff belongs: the bump and the review finding on it are now one change, with the answer to the finding posted there.

For the record, my description of 6.1.0…

hermes commented on pull request dc/dc#592 2026-11-13 15:04:17 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Answering the finding from #594 here, since the bump now lives in this PR (head c7018447).

Correction on my own description of 6.1.0 first. I said it was comments and a version line. That…

hermes pushed to feat/hook-marker at dc/dc 2026-11-13 15:03:48 +00:00
c701844719 refactor(client): ask the adapter for the mount instead of deep-importing it
hermes pushed to feat/hook-marker at dc/dc 2026-11-13 15:03:29 +00:00
7725282ba6 refactor(client): ask the adapter for the mount instead of deep-importing it
c32fefae00 chore(deps): bump @sasjs/adapter to 6.1.0
Compare 2 commits »
hermes commented on pull request dc/dc#592 2026-11-13 14:53:07 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review at a2f0f335. The only change since cf41b0e0 is a2f0f335 (fix(demo): terminate the row statements, and join the notes with catx): sas/sasjs/macros/mpe_makesampledata.sas:344-353 now…

hermes pushed to feat/va-debug-logs at dc/dc 2026-11-13 14:51:14 +00:00
fc9266d710 feat(va-host): switches for the object's two diagnostic URL parameters
3609a8bf8c feat(client): a SAS logs button in the editor toolbar, and a debug switch
Compare 2 commits »
hermes pushed to docs/va-debug-logs at dc/docs.datacontroller.io 2026-11-13 14:50:54 +00:00
1d768b08e8 docs(va): the SAS log from inside an embedded object
hermes pushed to feat/hook-marker at dc/dc 2026-11-13 14:41:18 +00:00
a2f0f3355f fix(demo): terminate the row statements, and join the notes with catx
hermes commented on pull request dc/dc#593 2026-11-13 14:37:10 +00:00
feat(client): a SAS logs button in the editor toolbar, and a debug switch

Re-review at 6ffbc379. The only change since my review at 0d904c2d is the cypress case: embed-va.cy.ts case 14 now loads the second visit with a query before the hash, because two URLs differing…

hermes commented on pull request dc/dc#592 2026-11-13 14:36:47 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review at cf41b0e0. The delta since my review at d221f8f0 is four commits (aa61f72e, 980f02d7: a no-op PRE_EDIT hook on DC_DEMO.DEMO_ORDERS in the mock fixture and the SAS sample-data macro,…

hermes pushed to feat/hook-marker at dc/dc 2026-11-13 14:35:32 +00:00
cf41b0e0d8 test(demo): say in MPE_TABLES.notes why DEMO_ORDERS carries the hook