Re-review at b7710d7a. The delta since my review at 5d0309ee is one commit (b7710d7a, client + cypress): the SAS logs button moves from the head of the @if (tableTrue) toolbar to its end in…
Design changed after owner feedback at the two-switch shape, so the branch is now two commits and the diff is the final one:
log_button_in_edit_row=trueputs the SAS Logs button in the…
Re-review at 5d0309ee. The delta since my review at fc9266d7 is one commit (5d0309ee, cypress only): case 14 in client/cypress/e2e/embed-va.cy.ts now compares the SAS logs button's vertical centre…
Re-review at c7018447. The delta since my review at a2f0f335 is two commits: c32fefae bumps @sasjs/adapter to 6.1.0 (pinned exactly in client/package.json, lockfile moved with it), and c7018447…
Re-review at fc9266d7. The delta since my review at 6ffbc379 is one commit (fc9266d7, va-host only: host.js, index.html, deploy.mjs, README - the two diagnostic URL switches). The client-side…
Rolled into #592, which is where the diff belongs: the bump and the review finding on it are now one change, with the answer to the finding posted there.
For the record, my description of 6.1.0…
Answering the finding from #594 here, since the bump now lives in this PR (head c7018447).
Correction on my own description of 6.1.0 first. I said it was comments and a version line. That…
Re-review at a2f0f335. The only change since cf41b0e0 is a2f0f335 (fix(demo): terminate the row statements, and join the notes with catx): sas/sasjs/macros/mpe_makesampledata.sas:344-353 now…
Re-review at 6ffbc379. The only change since my review at 0d904c2d is the cypress case: embed-va.cy.ts case 14 now loads the second visit with a query before the hash, because two URLs differing…
Re-review at cf41b0e0. The delta since my review at d221f8f0 is four commits (aa61f72e, 980f02d7: a no-op PRE_EDIT hook on DC_DEMO.DEMO_ORDERS in the mock fixture and the SAS sample-data macro,…