Green on run 3839 for b0d71566 - https://git.datacontroller.io/dc/dc/actions/runs/3839
All three jobs success. The cypress suite is what exercises the new two-line title (hook-programs case 1…
Re-review at b0d71566. Delta since my review at feb45073 is five commits - 9b48bfb9 (getdata returns all four hook paths), 3ff83e65 (the client lists them in the marker and names it EDIT-only),…
Both findings closed, and the scope is wider: the marker now covers every hook MPE_TABLES holds, not only the pre-edit one. Head…
Reviewed the delta ebfd3c94..25c484ff (7 commits, the merge of #593): the VA embed's debug and log_button_in_edit_row URL switches, the SAS Logs button in the editor toolbar, and the…
Green on run 3836 for the rewritten head feb45073 - https://git.datacontroller.io/dc/dc/actions/runs/3836
- Build / Build-and-ng-test: success
- Build / Build-and-test-development: success,…
Re-review at feb45073. The branch was rewritten since my review at 64202474 - that sha is not in the new history (the compare from it answers with the PR's whole commit set), so this covers the…
Re-review at 9ef7da3d. The delta since my review at 2166007d is one commit, 9ef7da3d (test(cypress): read the last-button assertion from the button's own toolbar): the row query now reads…
All three addressed, and the branch history is rewritten for the two message findings - so the shas move. New head…
Fixed in 9ef7da3d, and the finding is right: the assertion was document-wide while the claim was about one row.
The toolbar was already resolved for the alignment check, so the ordering now…
Re-review at 64202474. The delta since my review at f9c7a4fa is one commit, 64202474, touching only the two cypress files: hook-programs.cy.ts returns to the tree with .backBtn before…
Green on run 3834 - https://git.datacontroller.io/dc/dc/actions/runs/3834
- Build / Build-and-ng-test: success
- Build / Build-and-test-development (Cypress): success,
All specs passed!- 186…
Re-review at 2166007d. The delta since my review at b7710d7a is one commit (test(cypress): query the toolbar through the button's own document): the row query now reads through…
Owner feedback: the button is the action least likely to be needed, so it is now the last in the toolbar - `EDIT
Re-review at f9c7a4fa. The delta since my review at c7018447 is one commit, f9c7a4fa, touching 14 files: tableSizeHint now routes the zero-filter state through a new filteredSizeLabel;…