hermes commented on pull request dc/dc#592 2026-11-13 21:18:47 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Green on run 3839 for b0d71566 - https://git.datacontroller.io/dc/dc/actions/runs/3839

All three jobs success. The cypress suite is what exercises the new two-line title (hook-programs case 1…

hermes commented on pull request dc/dc#592 2026-11-13 20:55:26 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review at b0d71566. Delta since my review at feb45073 is five commits - 9b48bfb9 (getdata returns all four hook paths), 3ff83e65 (the client lists them in the marker and names it EDIT-only),…

hermes commented on pull request dc/dc#592 2026-11-13 20:49:49 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Both findings closed, and the scope is wider: the marker now covers every hook MPE_TABLES holds, not only the pre-edit one. Head…

hermes pushed to feat/hook-marker at dc/dc 2026-11-13 20:49:12 +00:00
b0d7156699 fix(parity): restore the trailing newline on scenarios.json
811021c4ef test(parity): record from the estate, not only from the target named server
cfd54d2856 test(cypress): assert the marker lists both edit hooks
3ff83e65c9 feat(editor): mark a table that runs through any edit or approve hook
9b48bfb921 feat(getdata): return all four hook paths
Compare 5 commits »
hermes commented on pull request dc/dc#481 2026-11-13 20:43:52 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed the delta ebfd3c94..25c484ff (7 commits, the merge of #593): the VA embed's debug and log_button_in_edit_row URL switches, the SAS Logs button in the editor toolbar, and the…

hermes commented on pull request dc/dc#592 2026-11-13 19:14:48 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Green on run 3836 for the rewritten head feb45073 - https://git.datacontroller.io/dc/dc/actions/runs/3836

  • Build / Build-and-ng-test: success
  • Build / Build-and-test-development: success,…
hermes commented on pull request dc/dc#592 2026-11-13 18:58:53 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review at feb45073. The branch was rewritten since my review at 64202474 - that sha is not in the new history (the compare from it answers with the PR's whole commit set), so this covers the…

hermes commented on pull request dc/dc#593 2026-11-13 18:56:49 +00:00
feat(client): a SAS logs button in the editor toolbar, and a debug switch

Re-review at 9ef7da3d. The delta since my review at 2166007d is one commit, 9ef7da3d (test(cypress): read the last-button assertion from the button's own toolbar): the row query now reads…

hermes commented on pull request dc/dc#592 2026-11-13 18:50:57 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

All three addressed, and the branch history is rewritten for the two message findings - so the shas move. New head…

hermes pushed to feat/hook-marker at dc/dc 2026-11-13 18:50:09 +00:00
feb45073a3 test(cypress): return to the tree, and close the tooltip before clicking
86ad88ff87 docs(getdata): describe PRE_EDIT_HOOK in the sasparams contract
36dfab24f5 test(parity): record a table that carries a PRE_EDIT hook
0901bac4f0 test(cypress): pin the marker's glyph, and the tooltip that covers Filter
e09f5d896f refactor(client): drop the unused sasjsExecutionPath helper
Compare 8 commits »
hermes commented on pull request dc/dc#593 2026-11-13 18:48:40 +00:00
feat(client): a SAS logs button in the editor toolbar, and a debug switch

Fixed in 9ef7da3d, and the finding is right: the assertion was document-wide while the claim was about one row.

The toolbar was already resolved for the alignment check, so the ordering now…

hermes pushed to feat/va-debug-logs at dc/dc 2026-11-13 18:48:31 +00:00
9ef7da3d9a test(cypress): read the last-button assertion from the button's own toolbar
hermes commented on pull request dc/dc#592 2026-11-13 18:20:06 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review at 64202474. The delta since my review at f9c7a4fa is one commit, 64202474, touching only the two cypress files: hook-programs.cy.ts returns to the tree with .backBtn before…

hermes commented on pull request dc/dc#592 2026-11-13 18:11:44 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Green on run 3834 - https://git.datacontroller.io/dc/dc/actions/runs/3834

  • Build / Build-and-ng-test: success
  • Build / Build-and-test-development (Cypress): success, All specs passed! - 186…
hermes commented on pull request dc/dc#593 2026-11-13 17:56:33 +00:00
feat(client): a SAS logs button in the editor toolbar, and a debug switch

Re-review at 2166007d. The delta since my review at b7710d7a is one commit (test(cypress): query the toolbar through the button's own document): the row query now reads through…

hermes commented on pull request dc/dc#593 2026-11-13 17:54:52 +00:00
feat(client): a SAS logs button in the editor toolbar, and a debug switch

Owner feedback: the button is the action least likely to be needed, so it is now the last in the toolbar - `EDIT

hermes pushed to feat/hook-marker at dc/dc 2026-11-13 17:45:22 +00:00
6420247496 test(cypress): return to the tree, and close the tooltip before clicking
hermes pushed to feat/va-debug-logs at dc/dc 2026-11-13 17:21:12 +00:00
2166007dd7 test(cypress): query the toolbar through the button's own document
hermes commented on pull request dc/dc#592 2026-11-13 17:19:30 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review at f9c7a4fa. The delta since my review at c7018447 is one commit, f9c7a4fa, touching 14 files: tableSizeHint now routes the zero-filter state through a new filteredSizeLabel;…

hermes pushed to feat/hook-marker at dc/dc 2026-11-13 17:14:58 +00:00
f9c7a4fa77 fix(editor): carry the column count in the filtered label