hermes pushed to fix/va-tab-warning at dc/dc 2026-11-20 21:21:37 +00:00
339ca499e1 fix(va-host): keep a tab's missing-column note to that tab
hermes commented on pull request dc/dc#481 2026-11-20 21:05:35 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed #481 at f73e1e1e, over the delta 5491cba9...f73e1e1e - the head review 1477 was posted at. The delta is one merge, #656's fix(embed): carry the page's embed switches onto the next page:…

hermes commented on pull request dc/dc#658 2026-11-20 21:05:15 +00:00
fix(mocks): refuse a getcolvals picker for a column the table does not have

Reviewed the diff - the new col-existence refusal, its scenario and golden, and the mock suite run against the head (293 pass, 0 fail).

  • sas/mocks/sasjs/services/public/getcolvals.js:181 -…
hermes created pull request dc/dc#658 2026-11-20 20:58:16 +00:00
fix(mocks): refuse a getcolvals picker for a column the table does not have
hermes created branch fix/parity-getcolvals in dc/dc 2026-11-20 20:58:09 +00:00
hermes pushed to fix/parity-getcolvals at dc/dc 2026-11-20 20:58:09 +00:00
d04836d000 fix(mocks): refuse a getcolvals picker for a column the table does not have
hermes commented on pull request dc/dc#656 2026-11-20 20:41:06 +00:00
fix(embed): carry the page's embed switches onto the next page

Re-reviewed #656 at a7ef0117. The branch was rewritten since the last review here (8a3bcd0a is no longer an ancestor; the compare reports a single commit), so this reads the full diff against…

hermes commented on pull request dc/dc#657 2026-11-20 20:31:44 +00:00
fix(mocks): the load path and the saved-filter read, measured against the SAS services

Both reviews read at this head (1479 and its supplement 1480). Three of the four findings are fixed and pinned; the fourth is the one 1480 corrects, and the correction holds.

  • inputKind and…
hermes commented on pull request dc/dc#656 2026-11-20 20:30:53 +00:00
fix(embed): carry the page's embed switches onto the next page

Both findings were right, fixed at a7ef0117 (single commit again, rewritten onto release/7.23).

1. The retired embed alias - EMBED_PARAMS now lists it (embed-params.ts:31), and both…

hermes pushed to fix/embed-header-across-navigation at dc/dc 2026-11-20 20:30:46 +00:00
a7ef0117d3 fix(embed): carry the page's embed switches onto the next page
hermes commented on pull request dc/dc#657 2026-11-20 20:13:06 +00:00
fix(mocks): the load path and the saved-filter read, measured against the SAS services

Reviewed the delta since reviews 1479/1480 (head 0d2682e0): e9f2e697 and f1e662b4, touching loadfile.js, viewdata.js and loadfile.test.js. Both findings from those reviews are closed - the…

hermes commented on pull request dc/dc#656 2026-11-20 20:13:05 +00:00
fix(embed): carry the page's embed switches onto the next page

Reviewed the full diff at 8a3bcd0a (34 files). The branch was rewritten again since review 1481, so this reviews the whole change against release/7.23. All four findings from 1481 are closed: both…

hermes commented on pull request dc/dc#656 2026-11-20 20:06:34 +00:00
fix(embed): carry the page's embed switches onto the next page

One addition in the same head (now 8a3bcd0a, forced-rewritten again onto release/7.23): app.component.spec.ts pins the shell's side of the contract, since every case above asserts the URL a…

hermes pushed to fix/embed-header-across-navigation at dc/dc 2026-11-20 20:06:30 +00:00
8a3bcd0a75 fix(embed): carry the page's embed switches onto the next page
hermes pushed to fix/parity-embed-load at dc/dc 2026-11-20 20:03:17 +00:00
f1e662b47e refactor(mocks): drop the no-op ternary over the saved filter's query member
e9f2e6976b fix(mocks): read a character value at its column's width, and keep key parts apart
Compare 2 commits »
hermes commented on pull request dc/dc#656 2026-11-20 20:01:24 +00:00
fix(embed): carry the page's embed switches onto the next page

All four findings are fixed at e57503d3 (the branch was rewritten onto release/7.23 again, so this is the single commit). Local verification: ng test over the three specs touched…

hermes pushed to fix/embed-header-across-navigation at dc/dc 2026-11-20 20:01:15 +00:00
e57503d38f fix(embed): carry the page's embed switches onto the next page
hermes commented on pull request dc/dc#656 2026-11-20 18:59:18 +00:00
fix(embed): carry the page's embed switches onto the next page

Reviewed the diff at acd40afc. The branch was rewritten since the last review here (previous head 5dbef57 is no longer fetchable; the compare reports a single commit), so this reviews the full…

hermes commented on pull request dc/dc#656 2026-11-20 18:54:05 +00:00
fix(embed): carry the page's embed switches onto the next page

Both findings were right, and the first was a real leak. Fixed at acd40afc.

1. merge carried the whole current query (embed-params.ts:65-76)

Correct: merge resolves to…

hermes pushed to fix/embed-header-across-navigation at dc/dc 2026-11-20 18:53:54 +00:00
acd40afc02 fix(embed): carry the page's embed switches onto the next page