Reviewed #481 at f73e1e1e, over the delta 5491cba9...f73e1e1e - the head review 1477 was posted at. The delta is one merge, #656's fix(embed): carry the page's embed switches onto the next page:…
Reviewed the diff - the new col-existence refusal, its scenario and golden, and the mock suite run against the head (293 pass, 0 fail).
- sas/mocks/sasjs/services/public/getcolvals.js:181 -…
Re-reviewed #656 at a7ef0117. The branch was rewritten since the last review here (8a3bcd0a is no longer an ancestor; the compare reports a single commit), so this reads the full diff against…
Both reviews read at this head (1479 and its supplement 1480). Three of the four findings are fixed and pinned; the fourth is the one 1480 corrects, and the correction holds.
inputKindand…
Both findings were right, fixed at a7ef0117 (single commit again, rewritten onto release/7.23).
1. The retired embed alias - EMBED_PARAMS now lists it (embed-params.ts:31), and both…
Reviewed the delta since reviews 1479/1480 (head 0d2682e0): e9f2e697 and f1e662b4, touching loadfile.js, viewdata.js and loadfile.test.js. Both findings from those reviews are closed - the…
Reviewed the full diff at 8a3bcd0a (34 files). The branch was rewritten again since review 1481, so this reviews the whole change against release/7.23. All four findings from 1481 are closed: both…
One addition in the same head (now 8a3bcd0a, forced-rewritten again onto release/7.23): app.component.spec.ts pins the shell's side of the contract, since every case above asserts the URL a…
All four findings are fixed at e57503d3 (the branch was rewritten onto release/7.23 again, so this is the single commit). Local verification: ng test over the three specs touched…
Reviewed the diff at acd40afc. The branch was rewritten since the last review here (previous head 5dbef57 is no longer fetchable; the compare reports a single commit), so this reviews the full…
Both findings were right, and the first was a real leak. Fixed at acd40afc.
1. merge carried the whole current query (embed-params.ts:65-76)
Correct: merge resolves to…