hermes commented on pull request dc/dc#592 2026-11-14 12:03:18 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Green on run 3849 for 79c3728c - https://git.datacontroller.io/dc/dc/actions/runs/3849

  • Build-and-ng-test: success
  • Build-and-test-development: success,…
hermes commented on pull request dc/dc#592 2026-11-14 11:49:18 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review of #592 at 79c3728c. The delta since my review at b17fe707 is one commit, 79c3728c (test: count every registration, and compare the pill with what fits): the dsn in (...) list is gone,…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 11:39:06 +00:00
79c3728c6e test: count every registration, and compare the pill with what fits
hermes commented on pull request dc/dc#592 2026-11-14 11:30:01 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Green on run 3848 for b17fe707 - https://git.datacontroller.io/dc/dc/actions/runs/3848

  • Build-and-ng-test: success
  • Build-and-test-development: success,…
hermes commented on pull request dc/dc#592 2026-11-14 11:11:34 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review of #592 at b17fe707. The delta since my review at a9f906ce is one commit, b17fe707 (test(demo): take the fixture's shape from the control table): the fixture copies the control table's…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 11:04:28 +00:00
b17fe70724 test(demo): take the fixture's shape from the control table
hermes commented on pull request dc/dc#592 2026-11-14 10:48:39 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review of #592 at a9f906ce. The delta since my review at cf799fc2 is one commit, a9f906ce (test(demo): give the fixture the columns the macro appends): sas/sasjs/macros/mpe_makesampledata.test.s…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 10:39:55 +00:00
a9f906ceaf test(demo): give the fixture the columns the macro appends
hermes commented on pull request dc/dc#592 2026-11-14 10:34:26 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review at cf799fc2. Delta since my review at 11bfdfd6 is five commits: cf799fc2 (the formula demo rows get their call missing), cfe1ec5e (the cypress hook case asserts a count), c8392adc…

hermes commented on pull request dc/dc#592 2026-11-14 10:18:51 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

All six closed at cf799fc2, plus one the work turned…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 10:18:34 +00:00
cf799fc2e8 fix(demo): write the formula demo rows the installer promises
hermes pushed to feat/hook-marker at dc/dc 2026-11-14 10:12:57 +00:00
cfe1ec5edd test(cypress): assert the row count, not just that rows exist
c8392adcc2 test(parity): record in _meta that these values were typed
674e3e5c39 test(parity): compare the estate by origin, not as a string
140923499f test(hooks): assert every hook column reaches its own member
7a847b7b33 chore(demo): drop an assignment that guards nothing
Compare 6 commits »
hermes pushed to docs/va-debug-logs at dc/docs.datacontroller.io 2026-11-14 09:02:10 +00:00
c95ebd83f2 docs(va): document the embed's URL parameters, including the log switches
hermes pushed to docs/va-debug-logs at dc/docs.datacontroller.io 2026-11-14 08:58:39 +00:00
3880324119 docs(va): document the embed's URL parameters, including the log switches
hermes commented on pull request dc/dc#592 2026-11-13 22:37:45 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Green on run 3841 for 11bfdfd6 - https://git.datacontroller.io/dc/dc/actions/runs/3841

All three jobs success, so the cypress suite passed with case 3 asserting the marker on MPE_X_TEST through…

hermes commented on pull request dc/dc#592 2026-11-13 22:20:17 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review at 11bfdfd6. The delta since my review at 925e6b7f is one commit, 11bfdfd6, which drops the MPE_X_TEST note back to 'Test table for controller' in both seeds and both goldens. That…

hermes pushed to feat/hook-marker at dc/dc 2026-11-13 22:12:24 +00:00
11bfdfd6d0 fix(hooks): leave the table's notes alone, and pin the real hook value
hermes commented on pull request dc/dc#592 2026-11-13 22:06:36 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review at 925e6b7f. The delta since my review at b0d71566 is two commits: 2ff4fdb2f moves the fixture PRE_EDIT hook from DC_DEMO.DEMO_ORDERS to MPE_X_TEST and ships a working example hook, and…

hermes commented on pull request dc/dc#592 2026-11-13 21:51:12 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

The shipped example hook moved, at review: head 925e6b7f.

It used to sit on DC_DEMO.DEMO_ORDERS - a table that…

hermes pushed to feat/hook-marker at dc/dc 2026-11-13 21:51:00 +00:00
925e6b7fec test: point the hook tests at the table that now carries the hook
2ff4fdb2f8 feat(hooks): ship a working PRE_EDIT example on MPE_X_TEST
Compare 2 commits »