hermes commented on pull request dc/dc#592 2026-11-14 16:08:26 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Supplement to review 1151 at this same head (1b2f67d0), which is the earlier review on this PR (Gitea reviews cannot be edited, so a second body is the only way to add material). Its three…

hermes commented on pull request dc/dc#592 2026-11-14 16:01:04 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Green on run 3851 for 1b2f67d0 - https://git.datacontroller.io/dc/dc/actions/runs/3851

  • Build-and-ng-test: success
  • Build-and-test-development: success,…
hermes commented on pull request dc/dc#592 2026-11-14 15:57:12 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

REVIEWED ON 2026-11-14 15:57 UTC

Reviewed the full current diff (client templates/TS/specs, sas macros, services, mocks, goldens) - re-review at a new head, not just the delta.

  • sas/sasjs/servic…
hermes deleted branch wip/checkrestore-inline from dc/dc 2026-11-14 15:35:28 +00:00
hermes pushed to feat/hook-marker at dc/dc 2026-11-14 15:35:26 +00:00
1b2f67d081 test(getdata): drop the four-member hook assertion
e56cfafbc3 feat(postdata): keep the log in the session when a test is the caller
b454163cc6 test(checkrestore): stage and approve the change in the test itself
Compare 3 commits »
hermes pushed to wip/checkrestore-inline at dc/dc 2026-11-14 15:11:30 +00:00
75a4b1bf7c feat(postdata): keep the log in the session when a test is the caller
hermes pushed to wip/checkrestore-inline at dc/dc 2026-11-14 13:29:24 +00:00
1f72c0e701 test(checkrestore): stage and approve the change in the test itself
hermes pushed to wip/checkrestore-inline at dc/dc 2026-11-14 13:29:08 +00:00
hermes created branch wip/checkrestore-inline in dc/dc 2026-11-14 13:29:07 +00:00
hermes commented on pull request dc/dc#592 2026-11-14 12:46:15 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review of #592 at 163f561f. The delta since my review at 79c3728c is one commit, 163f561f (test(getdata): put the hooks on a versioned row, not into the open one), touching sas/sasjs/services/ed…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 12:26:25 +00:00
163f561f64 test(getdata): put the hooks on a versioned row, not into the open one
hermes commented on pull request dc/dc#592 2026-11-14 12:03:18 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Green on run 3849 for 79c3728c - https://git.datacontroller.io/dc/dc/actions/runs/3849

  • Build-and-ng-test: success
  • Build-and-test-development: success,…
hermes commented on pull request dc/dc#592 2026-11-14 11:49:18 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review of #592 at 79c3728c. The delta since my review at b17fe707 is one commit, 79c3728c (test: count every registration, and compare the pill with what fits): the dsn in (...) list is gone,…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 11:39:06 +00:00
79c3728c6e test: count every registration, and compare the pill with what fits
hermes commented on pull request dc/dc#592 2026-11-14 11:30:01 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Green on run 3848 for b17fe707 - https://git.datacontroller.io/dc/dc/actions/runs/3848

  • Build-and-ng-test: success
  • Build-and-test-development: success,…
hermes commented on pull request dc/dc#592 2026-11-14 11:11:34 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review of #592 at b17fe707. The delta since my review at a9f906ce is one commit, b17fe707 (test(demo): take the fixture's shape from the control table): the fixture copies the control table's…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 11:04:28 +00:00
b17fe70724 test(demo): take the fixture's shape from the control table
hermes commented on pull request dc/dc#592 2026-11-14 10:48:39 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review of #592 at a9f906ce. The delta since my review at cf799fc2 is one commit, a9f906ce (test(demo): give the fixture the columns the macro appends): sas/sasjs/macros/mpe_makesampledata.test.s…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 10:39:55 +00:00
a9f906ceaf test(demo): give the fixture the columns the macro appends
hermes commented on pull request dc/dc#592 2026-11-14 10:34:26 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review at cf799fc2. Delta since my review at 11bfdfd6 is five commits: cf799fc2 (the formula demo rows get their call missing), cfe1ec5e (the cypress hook case asserts a count), c8392adc…