Supplement to review 1151 at this same head (1b2f67d0), which is the earlier review on this PR (Gitea reviews cannot be edited, so a second body is the only way to add material). Its three…
Green on run 3851 for 1b2f67d0 - https://git.datacontroller.io/dc/dc/actions/runs/3851
- Build-and-ng-test: success
- Build-and-test-development: success,…
REVIEWED ON 2026-11-14 15:57 UTC
Reviewed the full current diff (client templates/TS/specs, sas macros, services, mocks, goldens) - re-review at a new head, not just the delta.
- sas/sasjs/servic…
Re-review of #592 at 163f561f. The delta since my review at 79c3728c is one commit, 163f561f (test(getdata): put the hooks on a versioned row, not into the open one), touching sas/sasjs/services/ed…
Green on run 3849 for 79c3728c - https://git.datacontroller.io/dc/dc/actions/runs/3849
- Build-and-ng-test: success
- Build-and-test-development: success,…
Re-review of #592 at 79c3728c. The delta since my review at b17fe707 is one commit, 79c3728c (test: count every registration, and compare the pill with what fits): the dsn in (...) list is gone,…
Green on run 3848 for b17fe707 - https://git.datacontroller.io/dc/dc/actions/runs/3848
- Build-and-ng-test: success
- Build-and-test-development: success,…
Re-review of #592 at b17fe707. The delta since my review at a9f906ce is one commit, b17fe707 (test(demo): take the fixture's shape from the control table): the fixture copies the control table's…
Re-review of #592 at a9f906ce. The delta since my review at cf799fc2 is one commit, a9f906ce (test(demo): give the fixture the columns the macro appends): sas/sasjs/macros/mpe_makesampledata.test.s…
Re-review at cf799fc2. Delta since my review at 11bfdfd6 is five commits: cf799fc2 (the formula demo rows get their call missing), cfe1ec5e (the cypress hook case asserts a count), c8392adc…