hermes commented on pull request dc/dc#592 2026-11-14 20:24:53 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

dbed398b is now verified on the estate as well as in CI (run 3855, all jobs…

hermes commented on pull request dc/dc#592 2026-11-14 19:57:50 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review of the delta from ddaa7020 to dbed398b: one commit (refactor(postdata): mf_getapploc returns a clean value, so drop the %trim), removing %let applocus=%trim(&applocus); and rewriting…

hermes commented on pull request dc/dc#592 2026-11-14 19:49:53 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Correction to my earlier note on %mf_getapploc, which I wrote before testing it.

It returns a clean value. Five path shapes (services, jobs, tests/services, tests/macros, and the warning…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 19:49:39 +00:00
dbed398bfc refactor(postdata): mf_getapploc returns a clean value, so drop the %trim
hermes commented on pull request dc/dc#592 2026-11-14 18:52:36 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Green on run 3854 for ddaa7020 - https://git.datacontroller.io/dc/dc/actions/runs/3854

  • Build-and-ng-test: success
  • Build-and-test-development: success, All specs passed! 186,…
hermes commented on pull request dc/dc#592 2026-11-14 18:34:52 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review of the delta from af073c6a to ddaa7020: one commit (refactor(postdata): ask mf_getapploc where the app lives). It replaces the substring test with an appLoc prefix test and closes the…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 18:23:48 +00:00
ddaa7020bc refactor(postdata): ask mf_getapploc where the app lives
hermes commented on pull request dc/dc#592 2026-11-14 18:11:29 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Reviewed the delta from dfb88833 (the head I last reviewed) to af073c6a: one commit, and it addresses three of the five findings from review 1153 - the five blank members in the no-data literal…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 18:01:55 +00:00
af073c6a2f fix: focusable hook tooltip, anchored test-log check, faithful no-data literal
hermes commented on pull request dc/dc#592 2026-11-14 17:24:22 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Green on run 3852 for dfb88833 - https://git.datacontroller.io/dc/dc/actions/runs/3852

  • Build-and-ng-test: success
  • Build-and-test-development: success, All specs passed! 186 (17:53) -…
hermes commented on pull request dc/dc#592 2026-11-14 16:45:00 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Reviewed the delta from 1b2f67d0 (the head I last reviewed) to dfb88833: one commit, the abort branch of the getdata mock now carries all four hook members as ' ', and read-paths.test.js pins that…

hermes commented on pull request dc/dc#592 2026-11-14 16:29:21 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Both addressed at dfb88833, one with a correction.

The no-data payload (getdata.js) - fixed as you asked: all four members, each ' ', on the object that branch builds. One correction to the…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 16:28:58 +00:00
dfb8883364 fix(mocks): blank the hooks in the no-data payload too
hermes commented on pull request dc/dc#592 2026-11-14 16:08:26 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Supplement to review 1151 at this same head (1b2f67d0), which is the earlier review on this PR (Gitea reviews cannot be edited, so a second body is the only way to add material). Its three…

hermes commented on pull request dc/dc#592 2026-11-14 16:01:04 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Green on run 3851 for 1b2f67d0 - https://git.datacontroller.io/dc/dc/actions/runs/3851

  • Build-and-ng-test: success
  • Build-and-test-development: success,…
hermes commented on pull request dc/dc#592 2026-11-14 15:57:12 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

REVIEWED ON 2026-11-14 15:57 UTC

Reviewed the full current diff (client templates/TS/specs, sas macros, services, mocks, goldens) - re-review at a new head, not just the delta.

  • sas/sasjs/servic…
hermes deleted branch wip/checkrestore-inline from dc/dc 2026-11-14 15:35:28 +00:00
hermes pushed to feat/hook-marker at dc/dc 2026-11-14 15:35:26 +00:00
1b2f67d081 test(getdata): drop the four-member hook assertion
e56cfafbc3 feat(postdata): keep the log in the session when a test is the caller
b454163cc6 test(checkrestore): stage and approve the change in the test itself
Compare 3 commits »
hermes pushed to wip/checkrestore-inline at dc/dc 2026-11-14 15:11:30 +00:00
75a4b1bf7c feat(postdata): keep the log in the session when a test is the caller
hermes pushed to wip/checkrestore-inline at dc/dc 2026-11-14 13:29:24 +00:00
1f72c0e701 test(checkrestore): stage and approve the change in the test itself