dbed398b is now verified on the estate as well as in CI (run 3855, all jobs…
Re-review of the delta from ddaa7020 to dbed398b: one commit (refactor(postdata): mf_getapploc returns a clean value, so drop the %trim), removing %let applocus=%trim(&applocus); and rewriting…
Correction to my earlier note on %mf_getapploc, which I wrote before testing it.
It returns a clean value. Five path shapes (services, jobs, tests/services, tests/macros, and the warning…
Green on run 3854 for ddaa7020 - https://git.datacontroller.io/dc/dc/actions/runs/3854
- Build-and-ng-test: success
- Build-and-test-development: success,
All specs passed! 186,…
Re-review of the delta from af073c6a to ddaa7020: one commit (refactor(postdata): ask mf_getapploc where the app lives). It replaces the substring test with an appLoc prefix test and closes the…
Reviewed the delta from dfb88833 (the head I last reviewed) to af073c6a: one commit, and it addresses three of the five findings from review 1153 - the five blank members in the no-data literal…
Green on run 3852 for dfb88833 - https://git.datacontroller.io/dc/dc/actions/runs/3852
- Build-and-ng-test: success
- Build-and-test-development: success,
All specs passed! 186(17:53) -…
Reviewed the delta from 1b2f67d0 (the head I last reviewed) to dfb88833: one commit, the abort branch of the getdata mock now carries all four hook members as ' ', and read-paths.test.js pins that…
Both addressed at dfb88833, one with a correction.
The no-data payload (getdata.js) - fixed as you asked: all four members, each ' ', on the object that branch builds. One correction to the…
Supplement to review 1151 at this same head (1b2f67d0), which is the earlier review on this PR (Gitea reviews cannot be edited, so a second body is the only way to add material). Its three…
Green on run 3851 for 1b2f67d0 - https://git.datacontroller.io/dc/dc/actions/runs/3851
- Build-and-ng-test: success
- Build-and-test-development: success,…
REVIEWED ON 2026-11-14 15:57 UTC
Reviewed the full current diff (client templates/TS/specs, sas macros, services, mocks, goldens) - re-review at a new head, not just the delta.
- sas/sasjs/servic…