hermes created pull request dc/dc#595 2026-11-14 23:23:26 +00:00
fix(mocks): honour DCPATH, and describe the library the panel asks for
hermes pushed to fix/mock-dcpath-and-libinfo at dc/dc 2026-11-14 23:23:22 +00:00
3ddd4882e4 fix(mocks): honour DCPATH, and describe the library the panel asks for
hermes created branch fix/mock-dcpath-and-libinfo in dc/dc 2026-11-14 23:23:22 +00:00
hermes commented on pull request dc/dc#481 2026-11-14 22:36:27 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-14 22:36 UTC

Reviewed the release 7.23 diff at this head: the workflow consolidation in .gitea/workflows/build.yaml, the new .gitea/scripts reporters (coverage, lighthouse,…

hermes pushed to release/7.23 at dc/dc 2026-11-14 22:34:32 +00:00
1c21ded5fb docs(readme): say what is closed here, and that an account is the way in
hermes commented on pull request dc/dc#481 2026-11-14 22:16:49 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Re-review of #481 at head 670f87d8 (release/7.23 into main). The delta since the review at 49164998 is 65 commits netting six merges - #588 (a trailing row whose only value is a zero key), #589…

hermes pushed to release/7.23 at dc/dc 2026-11-14 22:16:30 +00:00
670f87d807 docs(readme): say what is closed here, and that an account is the way in
hermes commented on pull request dc/dc#481 2026-11-14 22:10:23 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Both findings answered at 1e7c23c9, plus the README note.

Finding 1, the "Before this is cut" block - the stale line is gone and the list now reads "19 pull requests, all merged". #506 landed…

hermes pushed to release/7.23 at dc/dc 2026-11-14 22:10:12 +00:00
1e7c23c96f docs(readme): say what is restricted here, and how to get an account
hermes commented on pull request dc/dc#592 2026-11-14 22:04:46 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Two follow-ups from finding 2, now that CI has run it: 42c2d0eb and run 3858, all jobs green (All specs passed! 186).

Making the badge a real <button> put a second button inside .buttonBar,…

hermes commented on pull request dc/dc#592 2026-11-14 21:51:43 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

REVIEWED ON 2026-11-14 21:51 UTC

Reviewed the full base...head diff at 42c2d0e - hook marker, the rows x columns pill, the @sasjs/adapter 6.1.0 mount accessor, the SAS hook params, and the…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 21:33:21 +00:00
42c2d0ebdd fix(client): name the upload button instead of picking the last one
hermes commented on pull request dc/dc#592 2026-11-14 21:29:38 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Finding 1 is now a one-liner, as it should have been from the start - d0a1a843 replaces the three-branch…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 21:29:16 +00:00
b9537bae97 fix(client): make the hook badge a real button
d0a1a8436c fix(postdata): decide "is this a test" in one line
Compare 2 commits »
hermes commented on pull request dc/dc#592 2026-11-14 21:25:26 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

REVIEWED ON 2026-11-14 21:25 UTC

Reviewed the full base...head diff: EDIT/VIEW title rework (size pill, hook badge, tableMeta helpers and specs), @sasjs/adapter bump to 6.1.0 with lockfile, the…

hermes commented on pull request dc/dc#592 2026-11-14 21:12:30 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

All four addressed. Head is 9984e292; the branch was force-pushed because finding 4 needed a message rewritten, so the earlier ddaa7020 is now ea5c3526 with identical…

hermes pushed to feat/hook-marker at dc/dc 2026-11-14 21:11:59 +00:00
9984e292c3 fix(client): make the hook badge a real button
b9b49beea0 fix(postdata): recognise a test from any folder shape, not one
5ff689523a refactor(postdata): mf_getapploc returns a clean value, so drop the %trim
ea5c3526ce fix(postdata): compare the appLoc prefix with a quoted %if
Compare 4 commits »
hermes commented on pull request dc/dc#592 2026-11-14 20:24:53 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

dbed398b is now verified on the estate as well as in CI (run 3855, all jobs…

hermes commented on pull request dc/dc#592 2026-11-14 19:57:50 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Re-review of the delta from ddaa7020 to dbed398b: one commit (refactor(postdata): mf_getapploc returns a clean value, so drop the %trim), removing %let applocus=%trim(&applocus); and rewriting…

hermes commented on pull request dc/dc#592 2026-11-14 19:49:53 +00:00
feat(editor): mark a table whose rows pass through a PRE_EDIT hook

Correction to my earlier note on %mf_getapploc, which I wrote before testing it.

It returns a clean value. Five path shapes (services, jobs, tests/services, tests/macros, and the warning…