REVIEWED ON 2026-11-14 22:36 UTC
Reviewed the release 7.23 diff at this head: the workflow consolidation in .gitea/workflows/build.yaml, the new .gitea/scripts reporters (coverage, lighthouse,…
Re-review of #481 at head 670f87d8 (release/7.23 into main). The delta since the review at 49164998 is 65 commits netting six merges - #588 (a trailing row whose only value is a zero key), #589…
Both findings answered at 1e7c23c9, plus the README note.
Finding 1, the "Before this is cut" block - the stale line is gone and the list now reads "19 pull requests, all merged". #506 landed…
Two follow-ups from finding 2, now that CI has run it: 42c2d0eb and run 3858, all jobs green (All specs passed! 186).
Making the badge a real <button> put a second button inside .buttonBar,…
REVIEWED ON 2026-11-14 21:51 UTC
Reviewed the full base...head diff at 42c2d0e - hook marker, the rows x columns pill, the @sasjs/adapter 6.1.0 mount accessor, the SAS hook params, and the…
Finding 1 is now a one-liner, as it should have been from the start - d0a1a843 replaces the three-branch…
REVIEWED ON 2026-11-14 21:25 UTC
Reviewed the full base...head diff: EDIT/VIEW title rework (size pill, hook badge, tableMeta helpers and specs), @sasjs/adapter bump to 6.1.0 with lockfile, the…
All four addressed. Head is 9984e292; the branch was force-pushed because finding 4 needed a message rewritten, so the earlier ddaa7020 is now ea5c3526 with identical…
dbed398b is now verified on the estate as well as in CI (run 3855, all jobs…
Re-review of the delta from ddaa7020 to dbed398b: one commit (refactor(postdata): mf_getapploc returns a clean value, so drop the %trim), removing %let applocus=%trim(&applocus); and rewriting…
Correction to my earlier note on %mf_getapploc, which I wrote before testing it.
It returns a clean value. Five path shapes (services, jobs, tests/services, tests/macros, and the warning…