hermes commented on pull request dc/dc#596 2026-11-15 11:24:52 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

REVIEWED ON 2026-11-15 11:24 UTC

Reviewed the full base...head diff: HTML escaping of the makedata success page, the libref guard in libDataDir, the loadDcConfig fallback, and the new/updated…

hermes commented on pull request dc/dc#596 2026-11-15 11:10:17 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

Finding 1166 fixed in 44a30b8a.

libDataDir now refuses through mpAbort('Invalid libref: ' + libref, 'libDataDir'), so the refusal is the sasjsAbort table every service's own handler already…

hermes pushed to fix/481-mock-review at dc/dc 2026-11-15 11:10:07 +00:00
44a30b8a1b fix(mocks): refuse a libref through mp_abort, so every caller inherits the refusal
hermes commented on pull request dc/dc#596 2026-11-15 11:01:51 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

Reviewed the diff at 16da405d against release/7.23: the libref guard, the loadDcConfig fallback, the success-page escaping, and their cases. 243 mock tests and the 29 parity scenarios pass locally…

hermes pushed to fix/481-mock-review at dc/dc 2026-11-15 10:50:41 +00:00
16da405d75 fix(mocks): refuse a libref that is not a name, and read options from the deployment folder
hermes commented on pull request dc/dc#481 2026-11-15 10:50:12 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

The six items in reviews 1164 and 1165 are addressed in #596 against release/7.23.

  • makedata.js:6185 HTML interpolation - escaped, with a case that seeds a DCPATH of…
hermes created pull request dc/dc#596 2026-11-15 10:50:08 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder
hermes pushed to fix/481-mock-review at dc/dc 2026-11-15 10:50:00 +00:00
72d2286c39 fix(mocks): refuse a libref that is not a name, and read options from the deployment folder
hermes created branch fix/481-mock-review in dc/dc 2026-11-15 10:50:00 +00:00
hermes commented on pull request dc/dc#481 2026-11-15 01:37:35 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

SUPPLEMENT to review 1164 at this head (2026-11-15 01:32 UTC). No review edit exists on Gitea, so this carries only what that review does not already say, plus the measurements behind its two…

hermes commented on pull request dc/dc#481 2026-11-15 01:32:26 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-15 01:32 UTC

Reviewed the delta since 1c21ded (the fix/mocks DCPATH work merged as #595) - the rest of the 323-file release diff was reviewed at that head. Mock-service logic,…

hermes commented on pull request dc/dc#595 2026-11-15 00:06:48 +00:00
fix(mocks): honour DCPATH, and describe the library the panel asks for

Re-review at ada4b87f: the only change since the review at 9059d1a2 is commit ada4b87f ("read the control folder through one rule in every service").

The eleven services named at 9059d1a2 now…

hermes commented on pull request dc/dc#595 2026-11-14 23:51:40 +00:00
fix(mocks): honour DCPATH, and describe the library the panel asks for

Fixed in ada4b87f, one round.

  • dcSettings.js now owns the rule as dcControlDir(driveRoot, appLoc, settings): settings.dcpath, falling back to the Drive's data folder. loadDcSettings…
hermes pushed to fix/mock-dcpath-and-libinfo at dc/dc 2026-11-14 23:51:36 +00:00
ada4b87fb7 fix(mocks): read the control folder through one rule in every service
hermes commented on pull request dc/dc#595 2026-11-14 23:34:28 +00:00
fix(mocks): honour DCPATH, and describe the library the panel asks for

Reviewed the full diff at 9059d1a2: DCPATH in makedata, settings/libDataDir/allLibrefs following it, demodataTables taking libsRoot, the refreshlibinfo rewrite, the two new test files, and the…

hermes pushed to fix/mock-dcpath-and-libinfo at dc/dc 2026-11-14 23:25:55 +00:00
9059d1a2f3 fix(mocks): honour DCPATH, and describe the library the panel asks for
hermes created pull request dc/dc#595 2026-11-14 23:23:26 +00:00
fix(mocks): honour DCPATH, and describe the library the panel asks for
hermes pushed to fix/mock-dcpath-and-libinfo at dc/dc 2026-11-14 23:23:22 +00:00
3ddd4882e4 fix(mocks): honour DCPATH, and describe the library the panel asks for
hermes created branch fix/mock-dcpath-and-libinfo in dc/dc 2026-11-14 23:23:22 +00:00
hermes commented on pull request dc/dc#481 2026-11-14 22:36:27 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-14 22:36 UTC

Reviewed the release 7.23 diff at this head: the workflow consolidation in .gitea/workflows/build.yaml, the new .gitea/scripts reporters (coverage, lighthouse,…