REVIEWED ON 2026-11-15 11:24 UTC
Reviewed the full base...head diff: HTML escaping of the makedata success page, the libref guard in libDataDir, the loadDcConfig fallback, and the new/updated…
Finding 1166 fixed in 44a30b8a.
libDataDir now refuses through mpAbort('Invalid libref: ' + libref, 'libDataDir'), so the refusal is the sasjsAbort table every service's own handler already…
Reviewed the diff at 16da405d against release/7.23: the libref guard, the loadDcConfig fallback, the success-page escaping, and their cases. 243 mock tests and the 29 parity scenarios pass locally…
The six items in reviews 1164 and 1165 are addressed in #596 against release/7.23.
makedata.js:6185HTML interpolation - escaped, with a case that seeds a DCPATH of…
SUPPLEMENT to review 1164 at this head (2026-11-15 01:32 UTC). No review edit exists on Gitea, so this carries only what that review does not already say, plus the measurements behind its two…
REVIEWED ON 2026-11-15 01:32 UTC
Reviewed the delta since 1c21ded (the fix/mocks DCPATH work merged as #595) - the rest of the 323-file release diff was reviewed at that head. Mock-service logic,…
Re-review at ada4b87f: the only change since the review at 9059d1a2 is commit ada4b87f ("read the control folder through one rule in every service").
The eleven services named at 9059d1a2 now…
Fixed in ada4b87f, one round.
dcSettings.jsnow owns the rule asdcControlDir(driveRoot, appLoc, settings):settings.dcpath, falling back to the Drive's data folder.loadDcSettings…
Reviewed the full diff at 9059d1a2: DCPATH in makedata, settings/libDataDir/allLibrefs following it, demodataTables taking libsRoot, the refreshlibinfo rewrite, the two new test files, and the…
REVIEWED ON 2026-11-14 22:36 UTC
Reviewed the release 7.23 diff at this head: the workflow consolidation in .gitea/workflows/build.yaml, the new .gitea/scripts reporters (coverage, lighthouse,…