hermes created pull request dc/dc#597 2026-11-15 15:00:44 +00:00
feat(deploy): warn when the DC folder is not an absolute path
hermes pushed to fix/deploy-path-shape at dc/dc 2026-11-15 15:00:36 +00:00
7a6b349084 feat(deploy): warn when the DC folder is not an absolute path
hermes created branch fix/deploy-path-shape in dc/dc 2026-11-15 15:00:36 +00:00
hermes commented on pull request dc/dc#481 2026-11-15 14:12:12 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed the delta since 18e53c3d - the seven commits of #596 (a libref that is a path, the folder case, and the deployment's options folder); the rest of the 323-file release diff was reviewed at…

hermes commented on pull request dc/dc#596 2026-11-15 12:44:17 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

CI is green at e700ae4d: Build / Build-and-ng-test success, Build / lighthouse success, Build / Build-and-test-development success with All specs passed! 187 passing in 17:02. Review 1172 closed…

hermes commented on pull request dc/dc#596 2026-11-15 12:31:12 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

REVIEWED ON 2026-11-15 12:44 UTC

Re-review of the delta since be4decc4, the head reviews 1170 and 1171 covered: one commit, e700ae4d, replacing the case-sensitive resolve in libDataDir with a…

hermes commented on pull request dc/dc#596 2026-11-15 12:18:58 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

Both findings from the 1171 supplement fixed in e700ae4d.

  • The resolver answers the entry that exists under the library root, case-blind, and returns the requested name only when there is no…
hermes pushed to fix/481-mock-review at dc/dc 2026-11-15 12:18:55 +00:00
e700ae4d8b fix(mocks): answer the library folder that exists, in either case
hermes commented on pull request dc/dc#596 2026-11-15 12:17:38 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

Supplement to review 1170 (which found nothing at this head), posted separately because Gitea reviews cannot be edited in place: one behaviour change in be4decc4 that review did not measure, found…

hermes commented on pull request dc/dc#596 2026-11-15 12:12:46 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

REVIEWED ON 2026-11-15 12:12 UTC

Reviewed the full base...head diff: the libref name gate in libDataDir and allLibrefs, the loadDcConfig fallback (which still reaches dcControlDir through…

hermes commented on pull request dc/dc#596 2026-11-15 11:57:45 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

Both findings from 1168 fixed in be4decc4.

  • The path segment is now the value as given, trimmed; only the comparison with the control library's name is case-blind. allLibrefs() lists directory…
hermes pushed to fix/481-mock-review at dc/dc 2026-11-15 11:57:42 +00:00
be4decc48b fix(mocks): resolve the folder case the drive holds, and name the rule in the refusal
hermes commented on pull request dc/dc#596 2026-11-15 11:55:59 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

Re-review at cf8ec5f1: the only change since 44a30b8a is a81f7592 plus cf8ec5f1 - LIBREF_NAME tightened to /^[A-Z_][A-Z0-9_]{0,7}$/, allLibrefs() dropping folder names that fail it, a test for a…

hermes commented on pull request dc/dc#596 2026-11-15 11:49:06 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

REVIEWED ON 2026-11-15 11:49 UTC

Reviewed the full base...head diff: the libref name rule, the folder listing that feeds the table search, the option-read fallback and the success-page…

hermes commented on pull request dc/dc#596 2026-11-15 11:31:10 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

Both findings from 1167 fixed in a81f7592 and cf8ec5f1.

  • allLibrefs() now leaves out a folder whose name is not a libref, so the table search gets the skip it had rather than an abort from a…
hermes pushed to fix/481-mock-review at dc/dc 2026-11-15 11:31:04 +00:00
cf8ec5f172 test(mocks): pin the libref guard with a parity scenario
a81f7592ca fix(mocks): list only librefs, and state the libref rule in full
Compare 2 commits »
hermes commented on pull request dc/dc#596 2026-11-15 11:24:52 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

REVIEWED ON 2026-11-15 11:24 UTC

Reviewed the full base...head diff: HTML escaping of the makedata success page, the libref guard in libDataDir, the loadDcConfig fallback, and the new/updated…

hermes commented on pull request dc/dc#596 2026-11-15 11:10:17 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

Finding 1166 fixed in 44a30b8a.

libDataDir now refuses through mpAbort('Invalid libref: ' + libref, 'libDataDir'), so the refusal is the sasjsAbort table every service's own handler already…

hermes pushed to fix/481-mock-review at dc/dc 2026-11-15 11:10:07 +00:00
44a30b8a1b fix(mocks): refuse a libref through mp_abort, so every caller inherits the refusal
hermes commented on pull request dc/dc#596 2026-11-15 11:01:51 +00:00
fix(mocks): refuse a libref that is not a name, and read options from the deployment folder

Reviewed the diff at 16da405d against release/7.23: the libref guard, the loadDcConfig fallback, the success-page escaping, and their cases. 243 mock tests and the 29 parity scenarios pass locally…