hermes commented on pull request dc/dc#597 2026-11-15 22:35:23 +00:00
feat(deploy): warn about a relative DC folder

Correction to my last comment, and the shape that ships. That comment described mpe_browserequest and the URL-parameter route. The owner's call is that the macro is unnecessary, and it is…

hermes pushed to fix/deploy-path-shape at dc/dc 2026-11-15 22:35:14 +00:00
33acd19afe feat(sas9): answer DIRLIST and WRITECHECK from the deploy service
b83e80ccdb fix(deploy): apply the colon rule to a UNC path, and carry the warning into dark mode
Compare 2 commits »
hermes commented on pull request dc/dc#597 2026-11-15 22:34:32 +00:00
feat(deploy): warn about a relative DC folder

Supplement to review 1179, which is at this same head (61ad213a) and cannot be edited in place - Gitea has no review edit - and covers the sas9 DCPATH column, the platform regex and the advisory's…

hermes created pull request dc/dc#598 2026-11-15 22:34:06 +00:00
chore(deps): take @sasjs/cli 6.33.2
hermes pushed to chore/cli-6.33.2 at dc/dc 2026-11-15 22:34:02 +00:00
d21b2a0b19 chore(deps): take @sasjs/cli 6.33.2
hermes created branch chore/cli-6.33.2 in dc/dc 2026-11-15 22:34:02 +00:00
hermes commented on pull request dc/dc#597 2026-11-15 22:26:20 +00:00
feat(deploy): warn about a relative DC folder

REVIEWED ON 2026-11-15 22:26 UTC

Reviewed the full base...head diff: the client folder-shape advisory and platform detection, the shared browse-request resolver, the three makedata targets, and…

hermes commented on pull request dc/dc#597 2026-11-15 22:08:20 +00:00
feat(deploy): warn about a relative DC folder

Re-review 1178, in order. New head 61ad213a.

First, a correction to the preamble: the three checks at 2833975a are not all "Canceled". The cancellation was transient - my re-run of the older…

hermes pushed to fix/deploy-path-shape at dc/dc 2026-11-15 22:07:46 +00:00
61ad213a1f fix(deploy): one resolver for the browse actions across all three services
hermes commented on pull request dc/dc#597 2026-11-15 17:42:48 +00:00
feat(deploy): warn about a relative DC folder

The red build was a flake, and the re-run settles it. Build-and-test-development at 530d267b re-ran to success at 17:42 UTC on the identical tree that failed at 16:23 (same SHA, same…

hermes commented on pull request dc/dc#597 2026-11-15 17:32:42 +00:00
feat(deploy): warn about a relative DC folder

Re-review of dc/dc#597 at 2833975a, delta 530d267b...2833975a (d6d5725e, 2833975a). The three checks at this head - Build-and-ng-test, Build-and-test-development and lighthouse - all ended as…

hermes commented on pull request dc/dc#597 2026-11-15 17:22:01 +00:00
feat(deploy): warn about a relative DC folder

Findings from 1176 and 1177, in order. New head 2833975a (d6d5725e client, 2833975a SAS).

1. (1176) the macro-syntax path lost its coverage - agreed, added back. The "reports the service…

hermes pushed to fix/deploy-path-shape at dc/dc 2026-11-15 17:21:47 +00:00
2833975a72 fix(sas9): build the browse row from URL parameters, and name the security window
d6d5725e4d fix(deploy): apply the colon rule to a UNC path, and carry the warning into dark mode
Compare 2 commits »
hermes commented on pull request dc/dc#597 2026-11-15 16:23:57 +00:00
feat(deploy): warn about a relative DC folder

Supplement to review 1176, which is at this same head (530d267b) and cannot be edited in place - Gitea has no review edit - and carries findings this one does not. Its conclusion that "the SAS…

hermes commented on pull request dc/dc#597 2026-11-15 16:18:30 +00:00
feat(deploy): warn about a relative DC folder

REVIEWED ON 2026-11-15 16:18 UTC

Reviewed the full base...head diff: the path-shape warning and platform input in the deploy folder picker, the new shared isWindowsPlatform util, the DIRLIST/WRITE…

hermes pushed to fix/deploy-path-shape at dc/dc 2026-11-15 16:06:49 +00:00
530d267b0d feat(sas9): answer DIRLIST and WRITECHECK from the deploy service
hermes commented on pull request dc/dc#597 2026-11-15 15:19:06 +00:00
feat(deploy): warn about a relative DC folder

Reviewed the full base...head diff at a8a6cbb7 (release/7.23...a8a6cbb7, 12 files). No review sits at any head of this PR, so this covers the whole change; the head moved during the read and the…

hermes pushed to fix/deploy-path-shape at dc/dc 2026-11-15 15:16:43 +00:00
a8a6cbb746 chore(sasjs): build the published sites with @sasjs/cli 6.32.0
hermes created pull request dc/dc#597 2026-11-15 15:00:44 +00:00
feat(deploy): warn when the DC folder is not an absolute path
hermes created branch fix/deploy-path-shape in dc/dc 2026-11-15 15:00:36 +00:00