hermes created pull request dc/docs.datacontroller.io#34 2026-11-16 11:58:51 +00:00
docs(va): name the log button switch va_log
hermes created pull request dc/dc#600 2026-11-16 11:58:50 +00:00
refactor(client): name the SAS logs switch va_log
hermes pushed to docs/va-log-switch at dc/docs.datacontroller.io 2026-11-16 11:58:39 +00:00
7e9e5bd494 docs(va): name the log button switch va_log
hermes created branch docs/va-log-switch in dc/docs.datacontroller.io 2026-11-16 11:58:39 +00:00
hermes pushed to refactor/va-log-switch at dc/dc 2026-11-16 11:58:38 +00:00
819406c081 refactor(client): name the SAS logs switch va_log
hermes created branch refactor/va-log-switch in dc/dc 2026-11-16 11:58:38 +00:00
hermes commented on pull request dc/dc#481 2026-11-16 11:49:17 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed the delta since 1c7e1bb1 - the 11 files and 507 insertions that 716ff174 merges (the deploy path warning, and the sas9 DIRLIST/WRITECHECK actions). The rest of the 331-file release diff…

hermes commented on pull request dc/dc#597 2026-11-16 10:41:35 +00:00
feat(deploy): warn about a relative DC folder

Reviewed at head 4e145a3c. The only change since the review at a477d6f0 is 4e145a3c itself (refactor(sas9): drop the URL route for a browse): %br_row_from_url is gone and the docstring no…

hermes pushed to fix/deploy-path-shape at dc/dc 2026-11-16 10:36:27 +00:00
4e145a3c6c refactor(sas9): drop the URL route for a browse
hermes commented on pull request dc/dc#597 2026-11-16 10:05:46 +00:00
feat(deploy): warn about a relative DC folder

Reviewed the diff at a477d6f0. The branch moved since the review at 7635634b: the single commit a477d6f0 replaces the sas9 ACTION reader with the data-step pattern the server and viya targets…

hermes pushed to fix/deploy-path-shape at dc/dc 2026-11-16 10:01:58 +00:00
a477d6f0fd refactor(sas9): read the service's inputs the way viya and server do
hermes commented on pull request dc/dc#597 2026-11-16 09:42:11 +00:00
feat(deploy): warn about a relative DC folder

The branch was rewritten since the review at ceee2e25: the shared mpe_browserequest resolver is gone, the PR is now the client advisory plus the sas9 service, and the full diff against base…

hermes commented on pull request dc/dc#481 2026-11-16 09:35:00 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-16 09:34 UTC

Reviewed the delta since ae995a27 - the two commits of #598 (chore(deps): take @sasjs/cli 6.33.2); the rest of the 323-file release diff was reviewed at that…

hermes pushed to fix/deploy-path-shape at dc/dc 2026-11-16 09:27:58 +00:00
7635634bb3 fix(sas9): build the browse row from URL parameters, and name the security window
cc8f6b525b fix(deploy): apply the colon rule to a UNC path, and carry the warning into dark mode
ea145a722b feat(sas9): answer DIRLIST and WRITECHECK from the deploy service
8e45b0d541 feat(deploy): warn when the DC folder is not an absolute path
1c7e1bb1aa Merge pull request 'chore(deps): take @sasjs/cli 6.33.2' (#598) from chore/cli-6.33.2 into release/7.23
Compare 6 commits »
hermes commented on pull request dc/dc#598 2026-11-15 22:48:56 +00:00
chore(deps): take @sasjs/cli 6.33.2

REVIEWED ON 2026-11-15 22:48 UTC

Reviewed dc/dc#598 (base ae995a2 -> head d21b2a0): sas/package.json @sasjs/cli 6.27.1 -> 6.33.2 plus the matching sas/package-lock.json refresh. Version is pinned…

hermes commented on pull request dc/dc#597 2026-11-15 22:48:15 +00:00
feat(deploy): warn about a relative DC folder

Reviewed the diff at ceee2e25. The branch was rewritten since the review at 61ad213a - that review's shared mpe_browserequest resolver and its test are gone, with the ACTION/PARENT/PATH reads…

hermes commented on pull request dc/dc#597 2026-11-15 22:45:38 +00:00
feat(deploy): warn about a relative DC folder

Final scope after the owner's steer (no URL-parameter route for the browse actions).

Head ceee2e25, 13 files. The SAS side is now one file:…

hermes pushed to fix/deploy-path-shape at dc/dc 2026-11-15 22:45:14 +00:00
ceee2e2506 feat(sas9): answer DIRLIST and WRITECHECK from the deploy service
hermes commented on pull request dc/dc#597 2026-11-15 22:35:23 +00:00
feat(deploy): warn about a relative DC folder

Correction to my last comment, and the shape that ships. That comment described mpe_browserequest and the URL-parameter route. The owner's call is that the macro is unnecessary, and it is…

hermes pushed to fix/deploy-path-shape at dc/dc 2026-11-15 22:35:14 +00:00
33acd19afe feat(sas9): answer DIRLIST and WRITECHECK from the deploy service
b83e80ccdb fix(deploy): apply the colon rule to a UNC path, and carry the warning into dark mode
Compare 2 commits »