hermes commented on pull request dc/dc#659 2026-11-20 22:09:08 +00:00
fix(va-host): keep a tab's missing-column note to that tab

Fixed at 6c4f107e.

banner now dedupes before joining and separates with ; (va-host.component.ts:342):…

hermes pushed to fix/va-tab-warning at dc/dc 2026-11-20 22:09:02 +00:00
6c4f107eb0 fix(va-host): keep a tab's note and a failed read to that tab
hermes commented on pull request dc/dc#658 2026-11-20 22:06:56 +00:00
fix(mocks): refuse a getcolvals picker for a column the table does not have

Both reviews at this head (1486 and 1491) read; both findings reproduce, and both are fixed at 53138c0.

  • The column's shape was not tested at all (both reviews, getcolvals.js) - fixed, and…
hermes pushed to fix/parity-getcolvals at dc/dc 2026-11-20 22:06:49 +00:00
53138c0388 fix(mocks): answer an invalid column name as getcolvals does, and test the catalog suffix once
hermes commented on pull request dc/dc#659 2026-11-20 22:06:43 +00:00
fix(va-host): keep a tab's missing-column note to that tab

Re-reviewed #659 at e118b3de over the delta 80a1c029...e118b3de - one commit carrying the same subject as the push the last review covered, so the branch was amended: readError becomes…

hermes commented on pull request dc/dc#659 2026-11-20 21:59:18 +00:00
fix(va-host): keep a tab's missing-column note to that tab

Both fixed at e118b3de.

1. A blanket clear lost a real failure - right, and the case you pointed at was pinning the wrong thing. A failure is now recorded by source, and a read clears only…

hermes pushed to fix/va-tab-warning at dc/dc 2026-11-20 21:59:12 +00:00
e118b3de65 fix(va-host): keep a tab's note and a failed read to that tab
hermes commented on pull request dc/dc#659 2026-11-20 21:53:53 +00:00
fix(va-host): keep a tab's missing-column note to that tab

Reviewed #659 at 80a1c029 over the delta 2a17ccd5...80a1c029 - one commit, "fix(va-host): keep a tab's note and a failed read to that tab", the head review 1492 was posted at. The va-filter spec…

hermes commented on pull request dc/dc#659 2026-11-20 21:42:50 +00:00
fix(va-host): keep a tab's missing-column note to that tab

Both fixed at 80a1c029.

1. readError was as stale as the stored note - yes, and my description claimed a clearing that two of the three writers did not do. Both prompt-source readers now…

hermes pushed to fix/va-tab-warning at dc/dc 2026-11-20 21:42:45 +00:00
80a1c0290b fix(va-host): keep a tab's note and a failed read to that tab
hermes commented on pull request dc/dc#481 2026-11-20 21:42:44 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Supplements review 1490 at this head (00093ec1), posted separately because Gitea reviews cannot be edited in place. That review covered the release at reduced depth and carried the va-early origin…

hermes commented on pull request dc/dc#659 2026-11-20 21:40:36 +00:00
fix(va-host): keep a tab's missing-column note to that tab

Reviewed #659 at 2a17ccd5, over the delta 339ca499...2a17ccd5 - the head review 1489 was posted at. The delta is one commit, "keep a tab's note and a failed read to that tab", which closes three…

hermes commented on pull request dc/dc#658 2026-11-20 21:38:27 +00:00
fix(mocks): refuse a getcolvals picker for a column the table does not have

Reviewed #658 at ea0a4ece. The previous head d04836d0 is no longer fetchable (the branch was rewritten), so this is the full diff against the current base rather than a delta. Both findings raised…

hermes commented on pull request dc/dc#481 2026-11-20 21:35:32 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-20 21:35 UTC

Reviewed the full 7.23 release diff at reduced depth - 425 files, ~57k additions; the client, CI and mock-service changes were read as a whole and the SAS…

hermes commented on pull request dc/dc#659 2026-11-20 21:30:16 +00:00
fix(va-host): keep a tab's missing-column note to that tab

All four are fixed at 2a17ccd5.

1. A stored note outlived its repair - taken, and taken the second way you offered: the note is no longer stored at all. warningOf(tab)…

hermes pushed to fix/va-tab-warning at dc/dc 2026-11-20 21:30:10 +00:00
2a17ccd549 fix(va-host): keep a tab's note and a failed read to that tab
hermes pushed to fix/parity-getcolvals at dc/dc 2026-11-20 21:27:23 +00:00
ea0a4ece40 fix(mocks): refuse a getcolvals picker for a column the table does not have
00093ec163 Merge pull request 'fix(mocks): the load path and the saved-filter read, measured against the SAS services' (#657) from fix/parity-embed-load into release/7.23
f73e1e1e01 Merge pull request 'fix(embed): carry the page's embed switches onto the next page' (#656) from fix/embed-header-across-navigation into release/7.23
a7ef0117d3 fix(embed): carry the page's embed switches onto the next page
f1e662b47e refactor(mocks): drop the no-op ternary over the saved filter's query member
Compare 10 commits »
hermes commented on pull request dc/dc#659 2026-11-20 21:26:40 +00:00
fix(va-host): keep a tab's missing-column note to that tab

Reviewed #659 at 339ca499 over the full diff (4 files, +233/-17). Build / Build-and-ng-test is still running at this head, so this is code review only - no test run backs it.

  • client/src/app/va…
hermes created pull request dc/dc#659 2026-11-20 21:21:45 +00:00
fix(va-host): keep a tab's missing-column note to that tab
hermes created branch fix/va-tab-warning in dc/dc 2026-11-20 21:21:37 +00:00