hermes pushed to feat/va-host-page at dc/dc 2026-11-16 15:44:34 +00:00
33da508eee feat(va-host): add the VA report emulation page, and configure its target from the UI
hermes commented on pull request dc/dc#604 2026-11-16 15:43:42 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Reviewed PR #604 at 434d88e0 - the projection rule, the re-recorded golden, the scenario declaration and the new test. Ran node --test sas/mocks/test/*.test.js (247 pass, 0 fail) and…

hermes created pull request dc/dc#604 2026-11-16 15:33:58 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold
hermes pushed to fix/libinfo-golden at dc/dc 2026-11-16 15:33:52 +00:00
434d88e0b3 fix(mocks): mask a library owner, and record what libinfo can hold
hermes created branch fix/libinfo-golden in dc/dc 2026-11-16 15:33:52 +00:00
hermes commented on pull request dc/dc#481 2026-11-16 15:13:35 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed the delta b7aa9769...ff7636fa - the merge of #603, which wraps the bare %inc executor in %do / %end in both copies of dc_refreshcatalog (server/macros_server/dc_refreshcatalog.sas:…

hermes commented on pull request dc/dc#481 2026-11-16 14:55:10 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed the delta 7d27ec46...b7aa9769 - the merges of #601 (a period count on va_parmap RANGE transforms) and #602 (the staged-edit mock answer) - and re-read the three findings from my review at…

hermes commented on pull request dc/dc#603 2026-11-16 14:54:14 +00:00
fix(sas): run the generated refresh statements from their own %do block

REVIEWED ON 2026-11-16 14:54 UTC

Reviewed the full diff (two dc_refreshcatalog.sas variants, %else %inc -> %else %do/%end).

The change is correct: %else %inc executor; leaves the included…

hermes deleted branch docs/va-log-switch from dc/docs.datacontroller.io 2026-11-16 14:44:19 +00:00
hermes deleted branch docs/599-quarter-spans from dc/docs.datacontroller.io 2026-11-16 14:44:19 +00:00
hermes closed pull request dc/docs.datacontroller.io#35 2026-11-16 14:43:53 +00:00
docs(va): a period count on the RANGE transform
hermes commented on pull request dc/docs.datacontroller.io#35 2026-11-16 14:43:53 +00:00
docs(va): a period count on the RANGE transform

Combined into #36 along with the other change to visual-analytics.md, so the page has one review. Closing this one; the content is unchanged apart from that.

hermes closed pull request dc/docs.datacontroller.io#34 2026-11-16 14:43:53 +00:00
docs(va): name the log button switch va_log
hermes commented on pull request dc/docs.datacontroller.io#34 2026-11-16 14:43:53 +00:00
docs(va): name the log button switch va_log

Combined into #36 along with the other change to visual-analytics.md, so the page has one review. Closing this one; the content is unchanged apart from that.

hermes created pull request dc/docs.datacontroller.io#36 2026-11-16 14:43:52 +00:00
docs(va): the va_log switch, and a period count on the RANGE transform
hermes pushed to docs/va-transforms at dc/docs.datacontroller.io 2026-11-16 14:43:52 +00:00
235c881b01 docs(va): keep the transform section to what the entries do
c996a2461c docs(va): give each transform its INTNX equivalent
8496e098bf docs(va): bound the transform offset, and name the refusal in the banner table
d798efc3bb docs(va): a period count on the RANGE transform
89c8fde4bc docs(va): name the log button switch va_log
Compare 5 commits »
hermes created branch docs/va-transforms in dc/docs.datacontroller.io 2026-11-16 14:43:52 +00:00
hermes commented on pull request dc/dc#603 2026-11-16 14:41:39 +00:00
fix(sas): run the generated refresh statements from their own %do block

Review 1198 addressed on f729437b (was fa92cd7c).

You are right, and it is the same construct rather than a similar one: sas/sasjs/targets/viya/macros_viya/dc_refreshcatalog.sas ends the same…

hermes pushed to fix/refreshcatalog-inc at dc/dc 2026-11-16 14:41:34 +00:00
f729437b8a fix(sas): wrap the Viya copy's include the same way
hermes commented on pull request dc/dc#603 2026-11-16 14:40:59 +00:00
fix(sas): run the generated refresh statements from their own %do block

Reviewed the diff at fa92cd7c (one hunk in sas/sasjs/targets/server/macros_server/dc_refreshcatalog.sas) and every other copy of the macro in the tree. The Build / Build-and-ng-test status is…