Reviewed PR #604 at 434d88e0 - the projection rule, the re-recorded golden, the scenario declaration and the new test. Ran node --test sas/mocks/test/*.test.js (247 pass, 0 fail) and…
Reviewed the delta b7aa9769...ff7636fa - the merge of #603, which wraps the bare %inc executor in %do / %end in both copies of dc_refreshcatalog (server/macros_server/dc_refreshcatalog.sas:…
Reviewed the delta 7d27ec46...b7aa9769 - the merges of #601 (a period count on va_parmap RANGE transforms) and #602 (the staged-edit mock answer) - and re-read the three findings from my review at…
REVIEWED ON 2026-11-16 14:54 UTC
Reviewed the full diff (two dc_refreshcatalog.sas variants, %else %inc -> %else %do/%end).
The change is correct: %else %inc executor; leaves the included…
Combined into #36 along with the other change to visual-analytics.md, so the page has one review. Closing this one; the content is unchanged apart from that.
Combined into #36 along with the other change to visual-analytics.md, so the page has one review. Closing this one; the content is unchanged apart from that.
Review 1198 addressed on f729437b (was fa92cd7c).
You are right, and it is the same construct rather than a similar one: sas/sasjs/targets/viya/macros_viya/dc_refreshcatalog.sas ends the same…
Reviewed the diff at fa92cd7c (one hunk in sas/sasjs/targets/server/macros_server/dc_refreshcatalog.sas) and every other copy of the macro in the tree. The Build / Build-and-ng-test status is…