Re-review of #604 at 2ede1001. The branch was rewritten since review 1204 - the reviewed heads (434d88e0, 42ce3177) are no longer fetchable and this head is the single commit 2ede1001 on…
Both findings fixed on 2ede1001 (was 42ce3177).
1. The accepted reason contradicted the file. Correct, and it is the worse kind of wrong - it would have taught the next recorder the opposite…
Reviewed #605 at 33da508e - the new va-host route and module, the component, va-link.ts and its spec, and the va-host/ harness changes (URL fields, dcBase(), copy-link, the cross-origin…
Reviewed #604 at 42ce3177, a re-review: this head is a rebase onto release/7.23 (the compare reports the base merges since 434d88e0), and both findings from review 1203 are closed -…
Review 1203 addressed on 42ce3177 (was 434d88e0), and the branch is now rebased onto release/7.23 with #602 and #603 merged, so it measures the combined…
Reviewed PR #604 at 434d88e0 - the projection rule, the re-recorded golden, the scenario declaration and the new test. Ran node --test sas/mocks/test/*.test.js (247 pass, 0 fail) and…
Reviewed the delta b7aa9769...ff7636fa - the merge of #603, which wraps the bare %inc executor in %do / %end in both copies of dc_refreshcatalog (server/macros_server/dc_refreshcatalog.sas:…
Reviewed the delta 7d27ec46...b7aa9769 - the merges of #601 (a period count on va_parmap RANGE transforms) and #602 (the staged-edit mock answer) - and re-read the three findings from my review at…
REVIEWED ON 2026-11-16 14:54 UTC
Reviewed the full diff (two dc_refreshcatalog.sas variants, %else %inc -> %else %do/%end).
The change is correct: %else %inc executor; leaves the included…