hermes pushed to fix/libinfo-golden at dc/dc 2026-11-16 16:06:40 +00:00
707e2ae374 fix(mocks): mask a library owner, and record what libinfo can hold
hermes commented on pull request dc/dc#604 2026-11-16 16:05:42 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Re-review of #604 at 2ede1001. The branch was rewritten since review 1204 - the reviewed heads (434d88e0, 42ce3177) are no longer fetchable and this head is the single commit 2ede1001 on…

hermes commented on pull request dc/dc#604 2026-11-16 15:56:02 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Both findings fixed on 2ede1001 (was 42ce3177).

1. The accepted reason contradicted the file. Correct, and it is the worse kind of wrong - it would have taught the next recorder the opposite…

hermes pushed to fix/libinfo-golden at dc/dc 2026-11-16 15:55:56 +00:00
2ede100126 fix(mocks): mask a library owner, and record what libinfo can hold
hermes commented on pull request dc/dc#605 2026-11-16 15:54:20 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Reviewed #605 at 33da508e - the new va-host route and module, the component, va-link.ts and its spec, and the va-host/ harness changes (URL fields, dcBase(), copy-link, the cross-origin…

hermes commented on pull request dc/dc#604 2026-11-16 15:54:19 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Reviewed #604 at 42ce3177, a re-review: this head is a rebase onto release/7.23 (the compare reports the base merges since 434d88e0), and both findings from review 1203 are closed -…

hermes commented on pull request dc/dc#604 2026-11-16 15:48:24 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Review 1203 addressed on 42ce3177 (was 434d88e0), and the branch is now rebased onto release/7.23 with #602 and #603 merged, so it measures the combined…

hermes pushed to fix/libinfo-golden at dc/dc 2026-11-16 15:48:17 +00:00
42ce3177c0 fix(mocks): mask a library owner, and record what libinfo can hold
ff7636fa45 Merge pull request 'fix(sas): run the generated refresh statements from their own %do block' (#603) from fix/refreshcatalog-inc into release/7.23
b7aa9769d2 Merge pull request 'fix(mocks): answer a staged edit the way SAS writes it' (#602) from fix/mock-submits-changeinfo into release/7.23
75e353fe88 Merge pull request 'feat(client): a period count on va_parmap RANGE transforms' (#601) from feat/599-quarter-spans into release/7.23
f729437b8a fix(sas): wrap the Viya copy's include the same way
Compare 21 commits »
hermes created pull request dc/dc#605 2026-11-16 15:44:46 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder
hermes pushed to feat/va-host-page at dc/dc 2026-11-16 15:44:34 +00:00
33da508eee feat(va-host): add the VA report emulation page, and configure its target from the UI
hermes created branch feat/va-host-page in dc/dc 2026-11-16 15:44:34 +00:00
hermes commented on pull request dc/dc#604 2026-11-16 15:43:42 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Reviewed PR #604 at 434d88e0 - the projection rule, the re-recorded golden, the scenario declaration and the new test. Ran node --test sas/mocks/test/*.test.js (247 pass, 0 fail) and…

hermes created pull request dc/dc#604 2026-11-16 15:33:58 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold
hermes pushed to fix/libinfo-golden at dc/dc 2026-11-16 15:33:52 +00:00
434d88e0b3 fix(mocks): mask a library owner, and record what libinfo can hold
hermes created branch fix/libinfo-golden in dc/dc 2026-11-16 15:33:52 +00:00
hermes commented on pull request dc/dc#481 2026-11-16 15:13:35 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed the delta b7aa9769...ff7636fa - the merge of #603, which wraps the bare %inc executor in %do / %end in both copies of dc_refreshcatalog (server/macros_server/dc_refreshcatalog.sas:…

hermes commented on pull request dc/dc#481 2026-11-16 14:55:10 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed the delta 7d27ec46...b7aa9769 - the merges of #601 (a period count on va_parmap RANGE transforms) and #602 (the staged-edit mock answer) - and re-read the three findings from my review at…

hermes commented on pull request dc/dc#603 2026-11-16 14:54:14 +00:00
fix(sas): run the generated refresh statements from their own %do block

REVIEWED ON 2026-11-16 14:54 UTC

Reviewed the full diff (two dc_refreshcatalog.sas variants, %else %inc -> %else %do/%end).

The change is correct: %else %inc executor; leaves the included…

hermes deleted branch docs/va-log-switch from dc/docs.datacontroller.io 2026-11-16 14:44:19 +00:00
hermes deleted branch docs/599-quarter-spans from dc/docs.datacontroller.io 2026-11-16 14:44:19 +00:00