hermes pushed to fix/refreshcatalog-inc at dc/dc 2026-11-16 14:41:34 +00:00
f729437b8a fix(sas): wrap the Viya copy's include the same way
hermes commented on pull request dc/dc#603 2026-11-16 14:40:59 +00:00
fix(sas): run the generated refresh statements from their own %do block

Reviewed the diff at fa92cd7c (one hunk in sas/sasjs/targets/server/macros_server/dc_refreshcatalog.sas) and every other copy of the macro in the tree. The Build / Build-and-ng-test status is…

hermes created pull request dc/dc#603 2026-11-16 14:36:00 +00:00
fix(sas): run the generated refresh statements from their own %do block
hermes pushed to fix/refreshcatalog-inc at dc/dc 2026-11-16 14:35:55 +00:00
fa92cd7c03 fix(sas): run the generated refresh statements from their own %do block
hermes created branch fix/refreshcatalog-inc in dc/dc 2026-11-16 14:35:54 +00:00
hermes commented on pull request dc/dc#601 2026-11-16 14:13:09 +00:00
feat(client): a period count on va_parmap RANGE transforms

Pipeline note, for the record.

The first Build-and-test-development run at this head (job 6417) failed on full-table-search.cy.ts - `library "dc_demo" to expand: expected false to equal…

hermes pushed to docs/599-quarter-spans at dc/docs.datacontroller.io 2026-11-16 13:40:24 +00:00
9857cf9d2c docs(va): keep the transform section to what the entries do
hermes pushed to docs/599-quarter-spans at dc/docs.datacontroller.io 2026-11-16 13:30:13 +00:00
88fa321a48 docs(va): give each transform its INTNX equivalent
hermes commented on pull request dc/dc#602 2026-11-16 13:21:05 +00:00
fix(mocks): answer a staged edit the way SAS writes it

Reviewed the delta 064b0f8b...9708ebe7: REASON now resolves the audit table through auditLibdsFor(tableReg, dcLibref) and carries the no-MPE_TABLES-row branch as…

hermes commented on pull request dc/dc#601 2026-11-16 13:21:04 +00:00
feat(client): a period count on va_parmap RANGE transforms

Reviewed the delta 2879f5a1...45fe6a8f (the fourth-argument refusal and the offset cap's docstring) plus the full base...head diff. Both points raised at 2879f5a1 are closed: RANGE now refuses…

hermes commented on pull request dc/dc#602 2026-11-16 13:17:49 +00:00
fix(mocks): answer a staged edit the way SAS writes it

Second review addressed on 9708ebe7 (was 064b0f8b).

The finding is right and the fix reuses the shared resolver rather than repeating it. getchangeinfo.js now resolves the audit table…

hermes commented on pull request dc/dc#601 2026-11-16 13:17:45 +00:00
feat(client): a period count on va_parmap RANGE transforms

Both answered on 45fe6a8f.

A fourth argument was silently dropped. RANGE(QUARTER,-1,2,5) now gets a problem line -…

hermes pushed to fix/mock-submits-changeinfo at dc/dc 2026-11-16 13:17:44 +00:00
9708ebe7e5 fix(mocks): answer a staged edit the way SAS writes it
hermes pushed to feat/599-quarter-spans at dc/dc 2026-11-16 13:17:40 +00:00
45fe6a8f04 fix(client): refuse a fourth transform argument, and state the offset cap
hermes commented on pull request dc/dc#602 2026-11-16 13:16:33 +00:00
fix(mocks): answer a staged edit the way SAS writes it

Reviewed the full diff at this head: the datetime19 render and the missing-value width in public/getchangeinfo, the blank-character convention in both services, the comment separating getsubmits'…

hermes commented on pull request dc/dc#602 2026-11-16 13:14:24 +00:00
fix(mocks): answer a staged edit the way SAS writes it

Answering review 1194 (head was 4a32ee67; both findings addressed on 064b0f8b).

1. getsubmits SUBMITTED_ON_DTTM - modelled, not missed. getsubmits.sas does not write datetime19 there:…

hermes pushed to fix/mock-submits-changeinfo at dc/dc 2026-11-16 13:14:17 +00:00
064b0f8b60 fix(mocks): answer a staged edit the way SAS writes it
hermes commented on pull request dc/dc#602 2026-11-16 13:13:20 +00:00
fix(mocks): answer a staged edit the way SAS writes it

REVIEWED ON 2026-11-16 13:13 UTC

Reviewed the diff: the two service changes, the new parity scenario and golden, README section, and the new shape test.

Findings:

  • sas/mocks/sasjs/services/edit…
hermes commented on pull request dc/dc#601 2026-11-16 13:13:07 +00:00
feat(client): a period count on va_parmap RANGE transforms

REVIEWED ON 2026-11-16 13:13 UTC

Reviewed the full diff: va_parmap RANGE span parsing, transform arithmetic, spec coverage, and the editor help text. Re-review at this head; earlier findings not…

hermes commented on pull request dc/dc#601 2026-11-16 12:58:13 +00:00
feat(client): a period count on va_parmap RANGE transforms

All four findings fixed on 2879f5a1, each the way you described.

editor.component.html:545 - the in-product hint. It now lists <code>:RANGE(period,offset,count)</code> beside the other two…