Reviewed the diff at fa92cd7c (one hunk in sas/sasjs/targets/server/macros_server/dc_refreshcatalog.sas) and every other copy of the macro in the tree. The Build / Build-and-ng-test status is…
Pipeline note, for the record.
The first Build-and-test-development run at this head (job 6417) failed on full-table-search.cy.ts - `library "dc_demo" to expand: expected false to equal…
Reviewed the delta 064b0f8b...9708ebe7: REASON now resolves the audit table through auditLibdsFor(tableReg, dcLibref) and carries the no-MPE_TABLES-row branch as…
Reviewed the delta 2879f5a1...45fe6a8f (the fourth-argument refusal and the offset cap's docstring) plus the full base...head diff. Both points raised at 2879f5a1 are closed: RANGE now refuses…
Second review addressed on 9708ebe7 (was 064b0f8b).
The finding is right and the fix reuses the shared resolver rather than repeating it. getchangeinfo.js now resolves the audit table…
Both answered on 45fe6a8f.
A fourth argument was silently dropped. RANGE(QUARTER,-1,2,5) now gets a problem line -…
Reviewed the full diff at this head: the datetime19 render and the missing-value width in public/getchangeinfo, the blank-character convention in both services, the comment separating getsubmits'…
Answering review 1194 (head was 4a32ee67; both findings addressed on 064b0f8b).
1. getsubmits SUBMITTED_ON_DTTM - modelled, not missed. getsubmits.sas does not write datetime19 there:…
REVIEWED ON 2026-11-16 13:13 UTC
Reviewed the diff: the two service changes, the new parity scenario and golden, README section, and the new shape test.
Findings:
- sas/mocks/sasjs/services/edit…
REVIEWED ON 2026-11-16 13:13 UTC
Reviewed the full diff: va_parmap RANGE span parsing, transform arithmetic, spec coverage, and the editor help text. Re-review at this head; earlier findings not…
All four findings fixed on 2879f5a1, each the way you described.
editor.component.html:545 - the in-product hint. It now lists <code>:RANGE(period,offset,count)</code> beside the other two…