hermes commented on pull request dc/dc#605 2026-11-16 18:42:17 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Reviewed #605 at e8900af0. The delta since the b5d2fba1 review is one commit (a target toggle, window-derived URL, and readable dark styling); the findings that review raised and this commit did…

hermes commented on pull request dc/dc#605 2026-11-16 18:27:47 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Second round on the page, at e8900af - all four points from using it on the estate.

  • The URL box is gone. The link only ever pointed at the page's own app, so the URL is read from…
hermes pushed to feat/va-host-page at dc/dc 2026-11-16 18:27:37 +00:00
e8900af052 feat(va-host): a target toggle, window-derived URL, and readable dark styling
hermes commented on pull request dc/dc#481 2026-11-16 18:13:06 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed the delta ff7636fa...52b7a933 - the merge of #604, which names OWNERS as an identity key in the parity projection, records the estate's libinfo row in the control_library golden, and…

hermes commented on pull request dc/dc#605 2026-11-16 17:14:47 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Reviewed #605 at b5d2fba1 - the delta since the 33da508e review: b5d2fba (VADER: the three-step page and the prompt builder over public/viewlibs, public/viewtables and public/getcols) and…

hermes pushed to feat/va-host-page at dc/dc 2026-11-16 17:07:12 +00:00
b5d2fba120 feat(va-host): VADER - a dark page with a prompt builder over DC's own metadata
60056afcf6 chore(deps): @sasjs/cli 6.33.4, whose deploy payload carries the file encoding
Compare 2 commits »
hermes opened issue dc/dc#606 2026-11-16 16:55:30 +00:00
fix(client): a Viya deployment cannot load its lazy route chunks
hermes commented on pull request dc/dc#604 2026-11-16 16:38:27 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Re-review of #604 at 9261a3ec. The branch was rewritten again - 3b8ffc52 is no longer fetchable and this head is a single commit on release/7.23 - so this reads the full diff against the current…

hermes commented on pull request dc/dc#604 2026-11-16 16:27:10 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Fixed on 9261a3ec (was 3b8ffc52).

You are right about public/getgroups: it has no golden and no scenario of its own - the only acceptance in its name is .globvars[0].DC_ADMIN_GROUP in the…

hermes pushed to fix/libinfo-golden at dc/dc 2026-11-16 16:27:01 +00:00
9261a3ec60 fix(mocks): mask a library owner, and record what libinfo can hold
hermes commented on pull request dc/dc#604 2026-11-16 16:25:50 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Re-review of #604 at 3b8ffc52. The branch was rewritten again - 707e2ae3 is no longer fetchable (couldn't find remote ref) and this head is the single commit 3b8ffc52 on release/7.23 - so this…

hermes commented on pull request dc/dc#604 2026-11-16 16:17:22 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Both fixed on 3b8ffc52 (was 707e2ae3).

1. The section contradicted itself. You are right that libinfo is recorded with a declared difference at a path while the intro said these answers are…

hermes pushed to fix/libinfo-golden at dc/dc 2026-11-16 16:17:17 +00:00
3b8ffc526b fix(mocks): mask a library owner, and record what libinfo can hold
hermes commented on pull request dc/dc#604 2026-11-16 16:16:01 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Re-review of #604 at 707e2ae3. The branch was rewritten again - the heads reviewed so far (434d88e0, 42ce3177, 2ede1001) are no longer fetchable and this is a single commit on release/7.23 - so…

hermes commented on pull request dc/dc#604 2026-11-16 16:06:44 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Both fixed on 707e2ae3 (was 2ede1001).

README.md:135 - the numeral is gone. The sentence now reads "...is the installation's own description of a library: ENGINE, LIBNAME, PATHS,…

hermes pushed to fix/libinfo-golden at dc/dc 2026-11-16 16:06:40 +00:00
707e2ae374 fix(mocks): mask a library owner, and record what libinfo can hold
hermes commented on pull request dc/dc#604 2026-11-16 16:05:42 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Re-review of #604 at 2ede1001. The branch was rewritten since review 1204 - the reviewed heads (434d88e0, 42ce3177) are no longer fetchable and this head is the single commit 2ede1001 on…

hermes commented on pull request dc/dc#604 2026-11-16 15:56:02 +00:00
fix(mocks): mask a library owner, and record what libinfo can hold

Both findings fixed on 2ede1001 (was 42ce3177).

1. The accepted reason contradicted the file. Correct, and it is the worse kind of wrong - it would have taught the next recorder the opposite…

hermes pushed to fix/libinfo-golden at dc/dc 2026-11-16 15:55:56 +00:00
2ede100126 fix(mocks): mask a library owner, and record what libinfo can hold
hermes commented on pull request dc/dc#605 2026-11-16 15:54:20 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Reviewed #605 at 33da508e - the new va-host route and module, the component, va-link.ts and its spec, and the va-host/ harness changes (URL fields, dcBase(), copy-link, the cross-origin…