Reviewed #605 at e8900af0. The delta since the b5d2fba1 review is one commit (a target toggle, window-derived URL, and readable dark styling); the findings that review raised and this commit did…
Second round on the page, at e8900af - all four points from using it on the estate.
- The URL box is gone. The link only ever pointed at the page's own app, so the URL is read from…
Reviewed the delta ff7636fa...52b7a933 - the merge of #604, which names OWNERS as an identity key in the parity projection, records the estate's libinfo row in the control_library golden, and…
Reviewed #605 at b5d2fba1 - the delta since the 33da508e review: b5d2fba (VADER: the three-step page and the prompt builder over public/viewlibs, public/viewtables and public/getcols) and…
Re-review of #604 at 9261a3ec. The branch was rewritten again - 3b8ffc52 is no longer fetchable and this head is a single commit on release/7.23 - so this reads the full diff against the current…
Fixed on 9261a3ec (was 3b8ffc52).
You are right about public/getgroups: it has no golden and no scenario of its own - the only acceptance in its name is .globvars[0].DC_ADMIN_GROUP in the…
Re-review of #604 at 3b8ffc52. The branch was rewritten again - 707e2ae3 is no longer fetchable (couldn't find remote ref) and this head is the single commit 3b8ffc52 on release/7.23 - so this…
Both fixed on 3b8ffc52 (was 707e2ae3).
1. The section contradicted itself. You are right that libinfo is recorded with a declared difference at a path while the intro said these answers are…
Re-review of #604 at 707e2ae3. The branch was rewritten again - the heads reviewed so far (434d88e0, 42ce3177, 2ede1001) are no longer fetchable and this is a single commit on release/7.23 - so…
Both fixed on 707e2ae3 (was 2ede1001).
README.md:135 - the numeral is gone. The sentence now reads "...is the installation's own description of a library: ENGINE, LIBNAME, PATHS,…
Re-review of #604 at 2ede1001. The branch was rewritten since review 1204 - the reviewed heads (434d88e0, 42ce3177) are no longer fetchable and this head is the single commit 2ede1001 on…
Both findings fixed on 2ede1001 (was 42ce3177).
1. The accepted reason contradicted the file. Correct, and it is the worse kind of wrong - it would have taught the next recorder the opposite…
Reviewed #605 at 33da508e - the new va-host route and module, the component, va-link.ts and its spec, and the va-host/ harness changes (URL fields, dcBase(), copy-link, the cross-origin…