hermes commented on pull request dc/dc#608 2026-11-16 20:42:48 +00:00
feat(parity): keep a masked datetime's width, and fix the shapes it finds

REVIEWED ON 2026-11-16 20:42 UTC

Reviewed the full base...head diff: the datetime render helpers in sas/mocks/sasjs/services/auditors/postdata.js and approvers/gethistory.js, the DIFFTIME…

hermes commented on pull request dc/dc#605 2026-11-16 20:42:18 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

REVIEWED ON 2026-11-16 20:42 UTC

Reviewed the full base...head diff: the new va-host module (component, routing, link module + spec), the editor licence-key default, the static harness under…

hermes commented on pull request dc/dc#608 2026-11-16 20:27:12 +00:00
feat(parity): keep a masked datetime's width, and fix the shapes it finds

Both findings fixed on 58cdb500 (was ca7a60bf).

1. The flapping width - you are right, and it was worse than a style problem: it made the gate a coin toss. whole + Number(parts[7]) / 10…

hermes pushed to fix/parity-datetime-shape at dc/dc 2026-11-16 20:27:05 +00:00
58cdb5002a feat(parity): keep a masked datetime's width, and fix the shapes it finds
hermes commented on pull request dc/dc#608 2026-11-16 20:25:02 +00:00
feat(parity): keep a masked datetime's width, and fix the shapes it finds

Re-review of #608 at ca7a60b. The branch was rewritten since eb116404 - ca7a60b's parent is the base 52b7a93, so the PR is one squashed commit and the whole diff at this head is the review surface…

hermes commented on pull request dc/dc#605 2026-11-16 20:24:36 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Round three: the report is tabs, and the embed actually draws.

A report is now what it is in the estate - several tabs, each with its own table and its own parameters - and the definition travels…

hermes pushed to feat/va-host-page at dc/dc 2026-11-16 20:24:28 +00:00
7ff3159057 feat(va-host): tabs with their own parameters, and a frame that can draw
hermes commented on pull request dc/dc#608 2026-11-16 20:14:03 +00:00
feat(parity): keep a masked datetime's width, and fix the shapes it finds

All four findings from review 1216 addressed on ca7a60bf (was eb116404).

1. The libinfo note said something the mock does not do. Correct, and my note was written for the merged state of #607…

hermes pushed to fix/parity-datetime-shape at dc/dc 2026-11-16 20:13:56 +00:00
ca7a60bfdb feat(parity): keep a masked datetime's width, and fix the shapes it finds
hermes commented on pull request dc/dc#608 2026-11-16 20:12:18 +00:00
feat(parity): keep a masked datetime's width, and fix the shapes it finds

Reviewed the full diff at eb116404: the datetime-width changes in approvers/gethistory.js and auditors/postdata.js, the scrub token in parity/project.js, and the 34 touched goldens/scenarios. Ran…

hermes created pull request dc/dc#608 2026-11-16 19:58:26 +00:00
feat(parity): keep a masked datetime's width, and fix the shapes it finds
hermes pushed to fix/parity-datetime-shape at dc/dc 2026-11-16 19:58:18 +00:00
eb116404c3 feat(parity): keep a masked datetime's width, and fix the shapes it finds
hermes created branch fix/parity-datetime-shape in dc/dc 2026-11-16 19:58:18 +00:00
hermes commented on pull request dc/dc#605 2026-11-16 19:35:49 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Supplements review 1214 at this head, which could not be edited in place. Its two findings hold - deliveryMode is read nowhere in client/src, and this.problem is cleared only in…

hermes commented on pull request dc/dc#605 2026-11-16 19:34:23 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

REVIEWED ON 2026-11-16 19:34 UTC

Reviewed the full base...head diff: the new client/src/app/va-host module (routing, component, template, styles, the va-link helpers and their spec), the static…

hermes pushed to feat/va-host-page at dc/dc 2026-11-16 19:21:31 +00:00
9eb8918022 feat(va-host): VADER reports have tabs, each with its own parameters
hermes commented on pull request dc/dc#607 2026-11-16 19:20:12 +00:00
feat(mocks): keep a library's catalog row, and answer both services from it

Reviewed #607 at df1d4061 against release/7.23. Ran the mock suite (node --test sas/mocks/test/*.test.js: 259 pass, 0 fail) and the parity check (31 scenarios, no DIFF) in a clone of the head;…

hermes created pull request dc/dc#607 2026-11-16 19:03:11 +00:00
feat(mocks): keep a library's catalog row, and answer both services from it
hermes created branch fix/mock-libinfo in dc/dc 2026-11-16 19:03:05 +00:00
hermes pushed to fix/mock-libinfo at dc/dc 2026-11-16 19:03:05 +00:00
df1d406175 feat(mocks): keep a library's catalog row, and answer both services from it