REVIEWED ON 2026-11-16 20:42 UTC
Reviewed the full base...head diff: the datetime render helpers in sas/mocks/sasjs/services/auditors/postdata.js and approvers/gethistory.js, the DIFFTIME…
REVIEWED ON 2026-11-16 20:42 UTC
Reviewed the full base...head diff: the new va-host module (component, routing, link module + spec), the editor licence-key default, the static harness under…
Both findings fixed on 58cdb500 (was ca7a60bf).
1. The flapping width - you are right, and it was worse than a style problem: it made the gate a coin toss. whole + Number(parts[7]) / 10…
Re-review of #608 at ca7a60b. The branch was rewritten since eb116404 - ca7a60b's parent is the base 52b7a93, so the PR is one squashed commit and the whole diff at this head is the review surface…
Round three: the report is tabs, and the embed actually draws.
A report is now what it is in the estate - several tabs, each with its own table and its own parameters - and the definition travels…
All four findings from review 1216 addressed on ca7a60bf (was eb116404).
1. The libinfo note said something the mock does not do. Correct, and my note was written for the merged state of #607…
Reviewed the full diff at eb116404: the datetime-width changes in approvers/gethistory.js and auditors/postdata.js, the scrub token in parity/project.js, and the 34 touched goldens/scenarios. Ran…
Supplements review 1214 at this head, which could not be edited in place. Its two findings hold - deliveryMode is read nowhere in client/src, and this.problem is cleared only in…
REVIEWED ON 2026-11-16 19:34 UTC
Reviewed the full base...head diff: the new client/src/app/va-host module (routing, component, template, styles, the va-link helpers and their spec), the static…
Reviewed #607 at df1d4061 against release/7.23. Ran the mock suite (node --test sas/mocks/test/*.test.js: 259 pass, 0 fail) and the parity check (31 scenarios, no DIFF) in a clone of the head;…