Supplements review 1225 at this head, which read the full 341-file diff. Nothing here restates it: this is the delta since the last review of this PR.
Reviewed the delta from 52b7a933 to 5eb63a79…
Reviewed the delta from df1d4061 to 08985306 - this PR's own commit (the mock's library row and the two services that answer it), plus the merge of #608, which is the datetime picture work already…
REVIEWED ON 2026-11-16 21:57 UTC
Reviewed the full base...head diff at reduced depth: 341 files, ~2.1 MB spanning client, CI and sas/mocks. The Angular changes (licence banner and licence.service…
All four findings from review 1213 addressed on 08985306, rebased onto release/7.23 so it carries #608.
1. History, not replacement. %bitemporal_dataloader(loadtype=TXTEMPORAL) closes the…
Re-review at head b8f0c853. The delta since the head reviews 1218 and 1220 covered is three commits: f7f4a501 (per-tab URL settings, value pickers, full-screen shell), 55d4adf1 (per-tab embed…
Reviewed the delta from c72f67cc (the head that carries a review) to 8329c4f4, then the current diff as a whole. The last commit closes the remaining finding: approvers-gethistory.test.js now…
Full screen, per-tab URL settings, and pickers that have values.
- The page now hides the app's own banner, header and footer while the route is showing, and sizes the frame to what the header,…
Fixed on 8329c4f4 (was c72f67cc) - and chasing it turned up a second defect in the same function.
Your finding: the round trip used Date.UTC against a render that uses local getters.…
REVIEWED ON 2026-11-16 21:10 UTC
Reviewed the full base...head diff: the datetime renderers in the approvers and auditors mocks, the parity projection's shape mask, and the refreshed goldens.
-…
Both findings fixed on c72f67cc (was 58cdb500).
1. The hundredth now carries instead of clamping. Correct, and it was the same class of defect as the flapping width: Math.min(99, ...) folds…
Supplements review 1219 at this head, which could not be edited in place and carries no finding on the new tests. Measured separately at this head so the timeline has it:…
Supplements review 1218 at this head, which could not be edited in place. The findings below are not in it: the first is the measured cause of the red pipeline that review reports, and the rest…