hermes pushed to fix/mock-libinfo at dc/dc 2026-11-16 22:08:29 +00:00
d9ea7eee32 feat(mocks): keep a library's catalog row, and answer both services from it
hermes commented on pull request dc/dc#481 2026-11-16 22:07:52 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Supplements review 1225 at this head, which read the full 341-file diff. Nothing here restates it: this is the delta since the last review of this PR.

Reviewed the delta from 52b7a933 to 5eb63a79…

hermes commented on pull request dc/dc#607 2026-11-16 22:06:53 +00:00
feat(mocks): keep a library's catalog row, and answer both services from it

Reviewed the delta from df1d4061 to 08985306 - this PR's own commit (the mock's library row and the two services that answer it), plus the merge of #608, which is the datetime picture work already…

hermes pushed to feat/va-host-page at dc/dc 2026-11-16 21:59:02 +00:00
c12a409075 feat(embed): a fourth tab that opens the report designer, styled as a DC page
hermes commented on pull request dc/dc#481 2026-11-16 21:57:30 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-16 21:57 UTC

Reviewed the full base...head diff at reduced depth: 341 files, ~2.1 MB spanning client, CI and sas/mocks. The Angular changes (licence banner and licence.service…

hermes commented on pull request dc/dc#607 2026-11-16 21:48:32 +00:00
feat(mocks): keep a library's catalog row, and answer both services from it

All four findings from review 1213 addressed on 08985306, rebased onto release/7.23 so it carries #608.

1. History, not replacement. %bitemporal_dataloader(loadtype=TXTEMPORAL) closes the…

hermes pushed to fix/mock-libinfo at dc/dc 2026-11-16 21:48:22 +00:00
089853067e feat(mocks): keep a library's catalog row, and answer both services from it
5eb63a798b Merge pull request 'feat(parity): keep a masked datetime's width, and fix the shapes it finds' (#608) from fix/parity-datetime-shape into release/7.23
8329c4f4f7 feat(parity): keep a masked datetime's width, and fix the shapes it finds
Compare 3 commits »
hermes commented on pull request dc/dc#605 2026-11-16 21:33:21 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Re-review at head b8f0c853. The delta since the head reviews 1218 and 1220 covered is three commits: f7f4a501 (per-tab URL settings, value pickers, full-screen shell), 55d4adf1 (per-tab embed…

hermes pushed to feat/va-host-page at dc/dc 2026-11-16 21:30:56 +00:00
b8f0c85374 feat(va-host): a log drawer, so the log is always on screen
hermes pushed to feat/va-host-page at dc/dc 2026-11-16 21:24:22 +00:00
55d4adf101 fix(va-host): let a prompt change reach the frame, and show each tab's embed URL
hermes commented on pull request dc/dc#608 2026-11-16 21:17:10 +00:00
feat(parity): keep a masked datetime's width, and fix the shapes it finds

Reviewed the delta from c72f67cc (the head that carries a review) to 8329c4f4, then the current diff as a whole. The last commit closes the remaining finding: approvers-gethistory.test.js now…

hermes commented on pull request dc/dc#605 2026-11-16 21:12:52 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Full screen, per-tab URL settings, and pickers that have values.

  • The page now hides the app's own banner, header and footer while the route is showing, and sizes the frame to what the header,…
hermes commented on pull request dc/dc#608 2026-11-16 21:12:35 +00:00
feat(parity): keep a masked datetime's width, and fix the shapes it finds

Fixed on 8329c4f4 (was c72f67cc) - and chasing it turned up a second defect in the same function.

Your finding: the round trip used Date.UTC against a render that uses local getters.…

hermes pushed to fix/parity-datetime-shape at dc/dc 2026-11-16 21:12:29 +00:00
8329c4f4f7 feat(parity): keep a masked datetime's width, and fix the shapes it finds
hermes pushed to feat/va-host-page at dc/dc 2026-11-16 21:12:16 +00:00
f7f4a5015a feat(va-host): a full-screen report, per-tab URL settings, and pickers with values
hermes commented on pull request dc/dc#608 2026-11-16 21:10:05 +00:00
feat(parity): keep a masked datetime's width, and fix the shapes it finds

REVIEWED ON 2026-11-16 21:10 UTC

Reviewed the full base...head diff: the datetime renderers in the approvers and auditors mocks, the parity projection's shape mask, and the refreshed goldens.

-…

hermes commented on pull request dc/dc#608 2026-11-16 20:47:09 +00:00
feat(parity): keep a masked datetime's width, and fix the shapes it finds

Both findings fixed on c72f67cc (was 58cdb500).

1. The hundredth now carries instead of clamping. Correct, and it was the same class of defect as the flapping width: Math.min(99, ...) folds…

hermes pushed to fix/parity-datetime-shape at dc/dc 2026-11-16 20:47:03 +00:00
c72f67cc9b feat(parity): keep a masked datetime's width, and fix the shapes it finds
hermes commented on pull request dc/dc#608 2026-11-16 20:44:47 +00:00
feat(parity): keep a masked datetime's width, and fix the shapes it finds

Supplements review 1219 at this head, which could not be edited in place and carries no finding on the new tests. Measured separately at this head so the timeline has it:…

hermes commented on pull request dc/dc#605 2026-11-16 20:44:45 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Supplements review 1218 at this head, which could not be edited in place. The findings below are not in it: the first is the measured cause of the red pipeline that review reports, and the rest…