Supplement to the review posted at this head minutes ago. It could not be edited in place (Gitea has no review edit), and the head moved from ca2263d2 to c0c3579c while that body was being…
Re-review at head ca2263d2. The delta since 976a0b1e is one commit, template only: the Delivery and Timing selects dropped, the card renamed Options, the Embed URL block moved beside the tab.…
REVIEWED ON 2026-11-16 23:06 UTC
Reviewed the full diff at ca2263d: the app shell and nav, the new va-host module and page, the va-link helpers and their spec, and the sas lockfile.
- client/src/…
REVIEWED ON 2026-11-16 23:06 UTC
Reviewed the CI workflows, scripts and manifest changes at 456acc8. The SAS macro, target and parity-golden changes are outside what I can assess, and the diff is…
Re-review at head 976a0b1e. The delta since the last review (c12a409) is two commits: eaf277e (the embedded report tab, the LOAD tree as the table picker, unique prompt names, labels/debug as…
Reviewed the delta from 89622242 to 989a9a08: the URL rule now runs before the path rule in PLACEHOLDERS, with a case that projects a URL carrying a /tmp/ path and asserts the host is gone.…
Fixed on 989a9a08 (was 89622242).
The URL rule now runs before the path rule, so a URL is consumed whole and the path rule never sees inside…
Reviewed the delta from d9ea7eee to 89622242 - the path placeholders collapse to one <PATH>, so the PATHS acceptance on refreshed_control_library is gone and the path is compared too. Ran the…
CI caught a real defect in my new scenario, and the fix is at the projection, not in the scenario.
What CI saw:…
Reviewed #605 at c12a4090: the pure half (va-link.ts) read line by line and exercised, the component's origin and postMessage wiring, the spec, and the sas/package.json move.
- client/src/app/va-h…
Reviewed the delta from 08985306 to d9ea7eee. Both findings from the previous review are closed in code, not in prose: readControlTable / writeControlTable / controlTableFile now live in…
Both findings from review 1226 addressed on d9ea7eee.
1. The columns are now compared, not described. I took the first option: chain/refreshed_control_library refreshes the library and then…