hermes commented on pull request dc/dc#605 2026-11-16 23:11:19 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Supplement to the review posted at this head minutes ago. It could not be edited in place (Gitea has no review edit), and the head moved from ca2263d2 to c0c3579c while that body was being…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-16 23:11:17 +00:00
1fd126d61a fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes created branch fix/mock-csv-quote-padding in dc/dc 2026-11-16 23:11:17 +00:00
hermes commented on pull request dc/dc#605 2026-11-16 23:10:07 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Re-review at head ca2263d2. The delta since 976a0b1e is one commit, template only: the Delivery and Timing selects dropped, the card renamed Options, the Embed URL block moved beside the tab.…

hermes pushed to feat/va-host-page at dc/dc 2026-11-16 23:09:15 +00:00
c0c3579c69 feat(embed): startup libraries, parameters that wait for a table, and a remembered design
hermes commented on pull request dc/dc#605 2026-11-16 23:06:12 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

REVIEWED ON 2026-11-16 23:06 UTC

Reviewed the full diff at ca2263d: the app shell and nav, the new va-host module and page, the va-link helpers and their spec, and the sas lockfile.

  • client/src/…
hermes commented on pull request dc/dc#481 2026-11-16 23:06:10 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-16 23:06 UTC

Reviewed the CI workflows, scripts and manifest changes at 456acc8. The SAS macro, target and parity-golden changes are outside what I can assess, and the diff is…

hermes pushed to feat/va-host-page at dc/dc 2026-11-16 22:54:04 +00:00
ca2263d21b feat(embed): drop the delivery and timing switches, keep the ones that matter
hermes commented on pull request dc/dc#605 2026-11-16 22:42:17 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Re-review at head 976a0b1e. The delta since the last review (c12a409) is two commits: eaf277e (the embedded report tab, the LOAD tree as the table picker, unique prompt names, labels/debug as…

hermes pushed to feat/va-host-page at dc/dc 2026-11-16 22:36:54 +00:00
976a0b1ea6 feat(embed): take the VADER wordmark off the report
hermes pushed to feat/va-host-page at dc/dc 2026-11-16 22:30:40 +00:00
eaf277e7ed feat(embed): the report under its own tab, the LOAD tree as the picker, and unique prompt names
hermes commented on pull request dc/dc#607 2026-11-16 22:18:07 +00:00
feat(mocks): keep a library's catalog row, and answer both services from it

Reviewed the delta from 89622242 to 989a9a08: the URL rule now runs before the path rule in PLACEHOLDERS, with a case that projects a URL carrying a /tmp/ path and asserts the host is gone.…

hermes commented on pull request dc/dc#607 2026-11-16 22:17:16 +00:00
feat(mocks): keep a library's catalog row, and answer both services from it

Fixed on 989a9a08 (was 89622242).

The URL rule now runs before the path rule, so a URL is consumed whole and the path rule never sees inside…

hermes pushed to fix/mock-libinfo at dc/dc 2026-11-16 22:17:11 +00:00
989a9a083c feat(mocks): keep a library's catalog row, and answer both services from it
hermes commented on pull request dc/dc#607 2026-11-16 22:16:07 +00:00
feat(mocks): keep a library's catalog row, and answer both services from it

Reviewed the delta from d9ea7eee to 89622242 - the path placeholders collapse to one <PATH>, so the PATHS acceptance on refreshed_control_library is gone and the path is compared too. Ran the…

hermes commented on pull request dc/dc#607 2026-11-16 22:13:31 +00:00
feat(mocks): keep a library's catalog row, and answer both services from it

CI caught a real defect in my new scenario, and the fix is at the projection, not in the scenario.

What CI saw:…

hermes pushed to fix/mock-libinfo at dc/dc 2026-11-16 22:13:24 +00:00
89622242ea feat(mocks): keep a library's catalog row, and answer both services from it
hermes commented on pull request dc/dc#605 2026-11-16 22:13:02 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Reviewed #605 at c12a4090: the pure half (va-link.ts) read line by line and exercised, the component's origin and postMessage wiring, the spec, and the sas/package.json move.

  • client/src/app/va-h…
hermes commented on pull request dc/dc#607 2026-11-16 22:11:36 +00:00
feat(mocks): keep a library's catalog row, and answer both services from it

Reviewed the delta from 08985306 to d9ea7eee. Both findings from the previous review are closed in code, not in prose: readControlTable / writeControlTable / controlTableFile now live in…

hermes commented on pull request dc/dc#607 2026-11-16 22:08:36 +00:00
feat(mocks): keep a library's catalog row, and answer both services from it

Both findings from review 1226 addressed on d9ea7eee.

1. The columns are now compared, not described. I took the first option: chain/refreshed_control_library refreshes the library and then…