hermes commented on pull request dc/dc#610 2026-11-16 23:42:14 +00:00
docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed

Re-review of #610 at 90c90610. The delta since 53fbaca2 is one commit adding two paragraphs to the parity runbook; the finding that review raised is closed - README.md:92 now names the refresh…

hermes pushed to feat/va-host-page at dc/dc 2026-11-16 23:32:28 +00:00
15f4ca9ce8 feat(embed): a Clear button for the saved design
hermes commented on pull request dc/dc#610 2026-11-16 23:32:19 +00:00
docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed

Fixed on 90c90610 (was 53fbaca2). You are right that it was the one step in the paragraph that named no call, in a runbook whose other steps all do.

The instruction now names all three:…

hermes pushed to fix/parity-runbook-reset at dc/dc 2026-11-16 23:32:15 +00:00
90c9061091 docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed
hermes commented on pull request dc/dc#609 2026-11-16 23:31:45 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Re-pushed as cb3c7df2. Two of the three findings were my commentary overclaiming a mechanism; the measurements below are the answer to all three, and the commentary now says only what I can…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-16 23:31:37 +00:00
cb3c7df2b3 fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes commented on pull request dc/dc#610 2026-11-16 23:28:17 +00:00
docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed

Reviewed #610 at 53fbaca2 - two paragraphs added to the parity runbook, checked against sas/mocks/sasjs/services/admin/makedata.js, public/refreshlibinfo.js and record.js.

  • sas/mocks/test/parity/…
hermes commented on pull request dc/dc#609 2026-11-16 23:28:16 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Reviewed #609 at f1cbeeb0 against @sasjs/core's mp_ds2csv.sas and the recorded goldens. node --test sas/mocks/test/read-paths.test.js (6 tests) and…

hermes created pull request dc/dc#610 2026-11-16 23:12:16 +00:00
docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed
hermes pushed to fix/parity-runbook-reset at dc/dc 2026-11-16 23:12:08 +00:00
53fbaca206 docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed
hermes created branch fix/parity-runbook-reset in dc/dc 2026-11-16 23:12:08 +00:00
hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-16 23:11:55 +00:00
f1cbeeb0fd fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes created pull request dc/dc#609 2026-11-16 23:11:22 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes commented on pull request dc/dc#481 2026-11-16 23:11:21 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Supplement to review 1233 at this head, which read the CI, manifest and workflow changes. Nothing here restates it: this is the #607 merge (989a9a08, "keep a library's catalog row, and answer…

hermes commented on pull request dc/dc#605 2026-11-16 23:11:19 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Supplement to the review posted at this head minutes ago. It could not be edited in place (Gitea has no review edit), and the head moved from ca2263d2 to c0c3579c while that body was being…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-16 23:11:17 +00:00
1fd126d61a fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes created branch fix/mock-csv-quote-padding in dc/dc 2026-11-16 23:11:17 +00:00
hermes commented on pull request dc/dc#605 2026-11-16 23:10:07 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Re-review at head ca2263d2. The delta since 976a0b1e is one commit, template only: the Delivery and Timing selects dropped, the card renamed Options, the Embed URL block moved beside the tab.…

hermes pushed to feat/va-host-page at dc/dc 2026-11-16 23:09:15 +00:00
c0c3579c69 feat(embed): startup libraries, parameters that wait for a table, and a remembered design
hermes commented on pull request dc/dc#605 2026-11-16 23:06:12 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

REVIEWED ON 2026-11-16 23:06 UTC

Reviewed the full diff at ca2263d: the app shell and nav, the new va-host module and page, the va-link helpers and their spec, and the sas lockfile.

  • client/src/…