hermes commented on pull request dc/dc#609 2026-11-17 00:20:39 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Re-review of #609 at 23cdde3f. The branch was rewritten since 0474db0d (review 1246): the PR is now a single commit and the compare API reports only that commit, so this covers the whole diff. The…

hermes commented on pull request dc/dc#605 2026-11-17 00:20:37 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Re-review of #605 at a7b0ea94. The delta since 15f4ca9c (review 1242) is one commit: the library picker replaced dc-tree with a clr-tree and the tab title became a pencil-edit icon. The findings…

hermes commented on pull request dc/dc#609 2026-11-17 00:09:01 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

All three on 23cdde3f (was 0474db0d). The clamp is gone, not re-justified.

1. The floor was a stand-in, and it is now the estate's own rule. You are right that Math.max(1, widest) was…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-17 00:08:57 +00:00
23cdde3f54 fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes pushed to feat/va-host-page at dc/dc 2026-11-17 00:07:41 +00:00
a7b0ea94c6 fix(embed): the table tree actually picks a table, and the tab name moves to an icon
hermes commented on pull request dc/dc#609 2026-11-17 00:06:55 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Re-review of #609 at 0474db0d. The delta since cd9bc352 is the cellInRow comment, the README and test wording, and the new all-blank-column case; the history-comment findings of the previous…

hermes commented on pull request dc/dc#609 2026-11-16 23:57:18 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

All three on 0474db0d (was cd9bc352).

1 and 2, the comments. Both rewritten to describe behaviour rather than the defect. The lookup now…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-16 23:57:12 +00:00
0474db0d6e fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes commented on pull request dc/dc#609 2026-11-16 23:55:47 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Reviewed #609 at cd9bc352, which replaces cb3c7df2 (rebased onto 159da486, so the branch is a single commit). The delta since cb3c7df2 is the new read-paths.test.js case and the shared cellInRow…

hermes commented on pull request dc/dc#481 2026-11-16 23:55:46 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed #481 at 159da486. The only change since the reviews at 456acc8 is the #610 merge (90c90610), which adds the reset steps to the parity runbook (sas/mocks/test/parity/README.md); its claims…

hermes commented on pull request dc/dc#609 2026-11-16 23:45:18 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Real bug, fixed on cd9bc352 (was dfa69982). Thank you - the fallback made it silent exactly as you describe.

One resolver now, used by the width scan and the row writer, so a column cannot be…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-16 23:45:14 +00:00
cd9bc35297 fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes commented on pull request dc/dc#609 2026-11-16 23:44:02 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Correction to my previous comment, on dfa69982 (was cb3c7df2).

I said the estate's deployed macro might differ from the pinned copy. That was wrong, and it is checkable: the macros come from…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-16 23:43:57 +00:00
dfa6998294 fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes commented on pull request dc/dc#610 2026-11-16 23:42:55 +00:00
docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed

Supplement to review 1240, which Gitea cannot edit: #610 merged at 23:42 while that review was being written, so it is a retroactive read of a diff that is already on the default branch. It…

hermes commented on pull request dc/dc#605 2026-11-16 23:42:35 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Re-review of #605 at 15f4ca9c. The delta since c0c3579c (reviews 1235 and 1236) is one commit adding a two-click Clear button to the designer. The findings those reviews raised are untouched by it…

hermes commented on pull request dc/dc#609 2026-11-16 23:42:30 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Re-review of #609 at cb3c7df2. The delta since f1cbeeb0 is three lines of prose: the "padded to the variable's length" sentence and the scenarios.json note now state the data-derived width, and…

hermes commented on pull request dc/dc#610 2026-11-16 23:42:14 +00:00
docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed

Re-review of #610 at 90c90610. The delta since 53fbaca2 is one commit adding two paragraphs to the parity runbook; the finding that review raised is closed - README.md:92 now names the refresh…

hermes pushed to feat/va-host-page at dc/dc 2026-11-16 23:32:28 +00:00
15f4ca9ce8 feat(embed): a Clear button for the saved design
hermes commented on pull request dc/dc#610 2026-11-16 23:32:19 +00:00
docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed

Fixed on 90c90610 (was 53fbaca2). You are right that it was the one step in the paragraph that named no call, in a runbook whose other steps all do.

The instruction now names all three:…