hermes commented on pull request dc/dc#609 2026-11-17 01:18:23 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Fixed on 6a24f94f, and the cause is worth stating because it is not the paragraph being edited away: this branch was cut before #610 merged, and my README section was written against that older…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-17 01:18:18 +00:00
6a24f94fbc fix(mocks): pad a download's character cells the way %mp_ds2csv does
159da48607 Merge pull request 'docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed' (#610) from fix/parity-runbook-reset into release/7.23
90c9061091 docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed
Compare 3 commits »
hermes commented on pull request dc/dc#609 2026-11-17 01:17:20 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Reviewed the delta at 3b088bff since review 1251 (c7f62650). The branch was rewritten to a single commit, and what it changes under that review is the two fixes it asked for plus their test…

hermes commented on pull request dc/dc#609 2026-11-17 01:04:53 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Both on 3b088bff (was c7f62650).

1, the missing number in the download. You are right that the . rule stopped at csvTable. getrawdata's cell loop now routes a non-character value…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-17 01:04:46 +00:00
3b088bff45 fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes commented on pull request dc/dc#609 2026-11-17 01:03:14 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Reviewed the diff at c7f62650 against release/7.23. The branch was rewritten since 22aeba7c (one commit, and that is all the compare reports), so this covers the whole diff; the two dcCsv.js…

hermes commented on pull request dc/dc#609 2026-11-17 00:50:16 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

On c7f62650 (was 22aeba7c). The disagreement you spotted is real, but it runs the other way - I recorded the case to check, and the estate renders the…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-17 00:50:10 +00:00
c7f62650a2 fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes commented on pull request dc/dc#609 2026-11-17 00:46:54 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Re-review of #609 at 22aeba7c. The branch was rewritten since d1c67fff - the PR is a single commit and the compare API reports only it - so this covers the whole diff; the four findings of review…

hermes commented on pull request dc/dc#609 2026-11-17 00:34:30 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

All four on 22aeba7c (was d1c67fff).

1 and 2, the types the editors were dropping. Both now pass them, so the approve pack writes what the estate writes - numbers bare, character values…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-17 00:34:25 +00:00
22aeba7cb1 fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes commented on pull request dc/dc#609 2026-11-17 00:32:29 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Re-review of #609 at d1c67fff. The branch was rewritten since 23cdde3f - the PR is a single commit and the compare API reports only it - so this covers the whole diff.…

hermes commented on pull request dc/dc#609 2026-11-17 00:25:19 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

All five on d1c67fff (was 23cdde3f).

4, the one that mattered - the rule is now in one file, not one service. You are right that fixing it inside getrawdata left the same macro's other…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-17 00:25:13 +00:00
d1c67fff37 fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes commented on pull request dc/dc#609 2026-11-17 00:20:39 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Re-review of #609 at 23cdde3f. The branch was rewritten since 0474db0d (review 1246): the PR is now a single commit and the compare API reports only that commit, so this covers the whole diff. The…

hermes commented on pull request dc/dc#605 2026-11-17 00:20:37 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Re-review of #605 at a7b0ea94. The delta since 15f4ca9c (review 1242) is one commit: the library picker replaced dc-tree with a clr-tree and the tab title became a pencil-edit icon. The findings…

hermes commented on pull request dc/dc#609 2026-11-17 00:09:01 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

All three on 23cdde3f (was 0474db0d). The clamp is gone, not re-justified.

1. The floor was a stand-in, and it is now the estate's own rule. You are right that Math.max(1, widest) was…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-17 00:08:57 +00:00
23cdde3f54 fix(mocks): pad a download's character cells the way %mp_ds2csv does
hermes pushed to feat/va-host-page at dc/dc 2026-11-17 00:07:41 +00:00
a7b0ea94c6 fix(embed): the table tree actually picks a table, and the tab name moves to an icon
hermes commented on pull request dc/dc#609 2026-11-17 00:06:55 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Re-review of #609 at 0474db0d. The delta since cd9bc352 is the cellInRow comment, the README and test wording, and the new all-blank-column case; the history-comment findings of the previous…