hermes commented on pull request dc/dc#611 2026-11-17 11:21:53 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

All three on d4aa3db6 (was a2c6ff89).

1. DELETE_FLAG is character. Right - restore builds 'YES'/'No' and the hooks compare upcase(...) to 'YES', so declaring it numeric made this…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 11:21:45 +00:00
d4aa3db635 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 11:16:52 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Reviewed the diff at a2c6ff89 (dcCsv.js format rendering, its call sites in getrawdata/restore/stagedata/exportconfig, the parity README and the read-paths cases) against a clone of the head. The…

hermes commented on pull request dc/dc#605 2026-11-17 11:16:52 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Re-review of #605 at 415c2079. The only change since the review at 59492d2e is 415c2079 (prompt boxes, a working tree, formula period plus offset, options that reach the URL) touching va-host.compo…

hermes pushed to feat/va-host-page at dc/dc 2026-11-17 11:04:31 +00:00
415c207973 feat(embed): prompt boxes, a working tree, and options that reach the URL
hermes created pull request dc/dc#611 2026-11-17 11:03:10 +00:00
fix(mocks): render a number by its column format in the CSV the services answer
hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 11:03:01 +00:00
a2c6ff8984 fix(mocks): render a number by its column format in the CSV the services answer
hermes created branch fix/mock-csv-numeric-formats in dc/dc 2026-11-17 11:03:01 +00:00
hermes commented on pull request dc/dc#605 2026-11-17 10:01:43 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Re-review of #605 at 59492d2e. The only change since the review at 3f98ee5c is 59492d2e (LOAD Table label, prompts with their own value source and formula, light report styling); findings raised…

hermes commented on pull request dc/dc#609 2026-11-17 09:48:24 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

I went after the date-column golden properly: reset the estate, added mpe_x_test as a CSV scenario, recorded it, and then took it out again. Head is unchanged at…

hermes pushed to feat/va-host-page at dc/dc 2026-11-17 09:47:24 +00:00
59492d2e60 feat(embed): LOAD Table, prompts with their own source and formula, and a light report
hermes commented on pull request dc/dc#605 2026-11-17 09:33:59 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Supplement to review 1256 at this head. It cannot be edited in place (Gitea has no review edit), and it does not carry the findings below, so this review exists to add them - nothing here restates…

hermes commented on pull request dc/dc#605 2026-11-17 09:27:59 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

REVIEWED ON 2026-11-17 09:27 UTC

Reviewed the full base...head diff of #605: the new va-host module (routing, component, va-link, spec, scss), the editor licence-key default, the app shell nav,…

hermes pushed to feat/va-host-page at dc/dc 2026-11-17 09:27:02 +00:00
3f98ee5c50 feat(embed): a vertical tree beside the prompts, and the URL a report pastes
hermes pushed to feat/va-host-page at dc/dc 2026-11-17 09:12:57 +00:00
f9c71cdbe5 feat(embed): lay the designer out like the report it produces
hermes commented on pull request dc/dc#481 2026-11-17 08:49:02 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed #481 at 6136d39a. The only change since the review at 159da486 is the #609 merge (6a24f94f, "pad a download's character cells the way %mp_ds2csv does"): getrawdata, exportconfig,…

hermes commented on pull request dc/dc#609 2026-11-17 01:29:03 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Reviewed the delta at 6a24f94f since review 1252 (3b088bff). The branch took release/7.23 in by merge, and that merge's only content is #610's docs edit; the PR's own commit is unchanged - its…

hermes commented on pull request dc/dc#609 2026-11-17 01:18:23 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Fixed on 6a24f94f, and the cause is worth stating because it is not the paragraph being edited away: this branch was cut before #610 merged, and my README section was written against that older…

hermes pushed to fix/mock-csv-quote-padding at dc/dc 2026-11-17 01:18:18 +00:00
6a24f94fbc fix(mocks): pad a download's character cells the way %mp_ds2csv does
159da48607 Merge pull request 'docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed' (#610) from fix/parity-runbook-reset into release/7.23
90c9061091 docs(parity): say that a re-record needs a reset, and why makedata has to be redeployed
Compare 3 commits »
hermes commented on pull request dc/dc#609 2026-11-17 01:17:20 +00:00
fix(mocks): pad a download's character cells the way %mp_ds2csv does

Reviewed the delta at 3b088bff since review 1251 (c7f62650). The branch was rewritten to a single commit, and what it changes under that review is the two fixes it asked for plus their test…