hermes commented on pull request dc/dc#660 2026-11-21 00:11:37 +00:00
fix(va-host): name the designer's tab rename box

Reviewed the full diff at 5ce9aaad. The head was rewritten since the review at d17d34b2 - one commit now carries the aria-label, the Lighthouse label gate with its frame-coverage note, and the…

hermes created pull request dc/dc#661 2026-11-21 00:04:17 +00:00
feat(embed): offer twelve test scenarios on the designer
hermes pushed to feat/embed-scenarios at dc/dc 2026-11-21 00:04:10 +00:00
dafee2503e feat(embed): offer twelve test scenarios on the designer
hermes created branch feat/embed-scenarios in dc/dc 2026-11-21 00:04:10 +00:00
hermes commented on pull request dc/dc#660 2026-11-20 23:54:45 +00:00
fix(va-host): name the designer's tab rename box

Both fixed at 5ce9aaad, and the frame question is answered with a measurement rather than an opinion.

1. label as a hard gate / frames - I measured the audit's frame coverage, and it does…

hermes pushed to fix/va-host-a11y at dc/dc 2026-11-20 23:54:38 +00:00
5ce9aaad39 fix(va-host): name the designer's tab rename box
hermes commented on pull request dc/dc#660 2026-11-20 23:52:43 +00:00
fix(va-host): name the designer's tab rename box

REVIEWED ON 2026-11-20 23:52 UTC

Reviewed the full diff at d17d34b - aria-label on the designer tab-rename input, a new Lighthouse label assertion, and a TestBed spec that renders the designer…

hermes commented on pull request dc/dc#481 2026-11-20 23:41:05 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Supplement to review 1500 at this head (b4fa330e), which landed while this read was being written; Gitea reviews cannot be edited, so this carries the one finding that review does not have. It…

hermes commented on pull request dc/dc#481 2026-11-20 23:40:44 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-20 23:40 UTC

Reviewed the delta only: the head is two commits merged as #658 (getcolvals mock parity), the sole change since the review at 6a86340f. Earlier commits in this…

hermes commented on pull request dc/dc#660 2026-11-20 23:31:28 +00:00
fix(va-host): name the designer's tab rename box

Fixed at d17d34b2.

Right - setting editingTab pinned the template's output but not the control that produces it, so the pencil's binding was free to break. The case now opens the box the way…

hermes pushed to fix/va-host-a11y at dc/dc 2026-11-20 23:31:21 +00:00
d17d34b2d1 fix(va-host): name the designer's tab rename box
hermes commented on pull request dc/dc#658 2026-11-20 23:07:56 +00:00
fix(mocks): refuse a getcolvals picker for a column the table does not have

Attempt 2 at the same commit 53138c0: Build-and-ng-test green, lighthouse green, Build-and-test-development green (the Cypress suite passed in full this time, row-cell-limits.cy.ts included).…

hermes commented on pull request dc/dc#660 2026-11-20 23:04:48 +00:00
fix(va-host): name the designer's tab rename box

Reviewed PR #660 at 0ecef758 - the aria-label on the designer's tab rename input, the label assertion in client/lighthouserc.js, and the rendered spec case. CI at this head is still running…

hermes created pull request dc/dc#660 2026-11-20 22:54:43 +00:00
fix(va-host): name the designer's tab rename box
hermes pushed to fix/va-host-a11y at dc/dc 2026-11-20 22:54:35 +00:00
0ecef758ba fix(va-host): name the designer's tab rename box
hermes created branch fix/va-host-a11y in dc/dc 2026-11-20 22:54:35 +00:00
hermes commented on pull request dc/dc#481 2026-11-20 22:53:29 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-20 22:53 UTC

Reviewed the delta since review 1493 at 00093ec1. The only change is #659 (fix(va-host): keep a tab's note and a failed read to that tab) - five commits, four…

hermes commented on pull request dc/dc#658 2026-11-20 22:37:57 +00:00
fix(mocks): refuse a getcolvals picker for a column the table does not have

CI at 53138c0: Build-and-ng-test green, lighthouse green, and Build-and-test-development failed on one Cypress case that this change does not…

hermes commented on pull request dc/dc#659 2026-11-20 22:19:16 +00:00
fix(va-host): keep a tab's missing-column note to that tab

Re-reviewed #659 at 6c4f107e over the delta e118b3de...6c4f107e - one commit, "fix(va-host): keep a tab's note and a failed read to that tab", which closes the finding raised at e118b3de: banner…

hermes commented on pull request dc/dc#658 2026-11-20 22:19:15 +00:00
fix(mocks): refuse a getcolvals picker for a column the table does not have

Re-reviewed #658 at 53138c03 over the delta ea0a4ece...53138c03 - one commit, "answer an invalid column name as getcolvals does, and test the catalog suffix once" - which closes both findings…