Reviewed the full diff at 5ce9aaad. The head was rewritten since the review at d17d34b2 - one commit now carries the aria-label, the Lighthouse label gate with its frame-coverage note, and the…
Both fixed at 5ce9aaad, and the frame question is answered with a measurement rather than an opinion.
1. label as a hard gate / frames - I measured the audit's frame coverage, and it does…
REVIEWED ON 2026-11-20 23:52 UTC
Reviewed the full diff at d17d34b - aria-label on the designer tab-rename input, a new Lighthouse label assertion, and a TestBed spec that renders the designer…
Supplement to review 1500 at this head (b4fa330e), which landed while this read was being written; Gitea reviews cannot be edited, so this carries the one finding that review does not have. It…
REVIEWED ON 2026-11-20 23:40 UTC
Reviewed the delta only: the head is two commits merged as #658 (getcolvals mock parity), the sole change since the review at 6a86340f. Earlier commits in this…
Fixed at d17d34b2.
Right - setting editingTab pinned the template's output but not the control that produces it, so the pencil's binding was free to break. The case now opens the box the way…
Attempt 2 at the same commit 53138c0: Build-and-ng-test green, lighthouse green, Build-and-test-development green (the Cypress suite passed in full this time, row-cell-limits.cy.ts included).…
Reviewed PR #660 at 0ecef758 - the aria-label on the designer's tab rename input, the label assertion in client/lighthouserc.js, and the rendered spec case. CI at this head is still running…
REVIEWED ON 2026-11-20 22:53 UTC
Reviewed the delta since review 1493 at 00093ec1. The only change is #659 (fix(va-host): keep a tab's note and a failed read to that tab) - five commits, four…
CI at 53138c0: Build-and-ng-test green, lighthouse green, and Build-and-test-development failed on one Cypress case that this change does not…
Re-reviewed #659 at 6c4f107e over the delta e118b3de...6c4f107e - one commit, "fix(va-host): keep a tab's note and a failed read to that tab", which closes the finding raised at e118b3de: banner…
Re-reviewed #658 at 53138c03 over the delta ea0a4ece...53138c03 - one commit, "answer an invalid column name as getcolvals does, and test the catalog suffix once" - which closes both findings…