hermes commented on pull request dc/dc#611 2026-11-17 12:31:29 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

All four on aa30ad2b (was a3d738a7).

1. csvIsTemporal deleted. No caller; csvIsTemporalSpec is what the two paths…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 12:31:21 +00:00
aa30ad2b42 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 12:29:04 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

REVIEWED ON 2026-11-17 12:29 UTC

Reviewed dc/dc #611 (mock CSV number formatting: the format parse/render in dcCsv.js, the exportconfig/restore/stagedata/getrawdata call sites, tests and the…

hermes pushed to feat/va-host-page at dc/dc 2026-11-17 12:23:17 +00:00
29aa77e79e feat(embed): chips for URL parameters, a picker for relative prompts, tidier designer
hermes commented on pull request dc/dc#605 2026-11-17 12:19:27 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Re-review of #605 at 8dc5c0a3. Scope: the delta since the review at bdc097b8 - ddc2ad93 and 8dc5c0a3 across 8 files (a formula span and the va_parmap transform it produces, tab text in the…

hermes commented on pull request dc/dc#611 2026-11-17 12:13:37 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

All three on a3d738a7 (was 31beb9da). Each is a render that was right for a positive value and wrong for a negative or a named variant.

1 and 3, the sign. The sign is carried outside the…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 12:13:31 +00:00
a3d738a714 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 12:12:06 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at 31beb9da. The delta since b61182f1 is three files (dcCsv.js, README.md, read-paths.test.js) and it closes the four findings from that review: zw.d now zero-fills through the…

hermes pushed to feat/va-host-page at dc/dc 2026-11-17 12:05:51 +00:00
8dc5c0a370 feat(embed): a prompt is named after the column it filters
hermes pushed to feat/va-host-page at dc/dc 2026-11-17 12:01:56 +00:00
ddc2ad939c feat(embed): tab text, a period span, and an embed log that stays out of the way
hermes commented on pull request dc/dc#605 2026-11-17 11:56:15 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Supplement to review 1263 at this head (bdc097b8). It cannot be edited in place (Gitea has no review edit) and it does not carry the two findings below, so this review exists to add them - nothing…

hermes commented on pull request dc/dc#611 2026-11-17 11:55:24 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

All four on 31beb9da (was b61182f1).

1. zw.d. The zero fill only ran on the integer path, so zw8.2 fell into the decimal branch and answered 3.14. Both pads now live in that…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 11:55:17 +00:00
31beb9da73 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 11:53:29 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at b61182f1. The branch was rewritten since the review at d4aa3db6 - the old head is not an ancestor of this one - so the delta is git diff d4aa3db6 b61182f1 (dcCsv.js,…

hermes commented on pull request dc/dc#605 2026-11-17 11:52:31 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

REVIEWED ON 2026-11-17 11:52 UTC

Re-review at bdc097b8. Scope: the delta since the last review at 415c2079 (a Clarity tree, per-prompt value-source tables, formula null-safety, more fields…

hermes commented on pull request dc/dc#611 2026-11-17 11:42:18 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

All five on b61182f1 (was d4aa3db6).

1. percent. Handled before the decimals branch now, so both forms render: percent. of 12 is 1200% and percent8.2 of 0.125 is 12.50%. It no longer…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 11:42:07 +00:00
b61182f1ec fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 11:40:37 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Supplement to review 1261 at this head (d4aa3db6). Gitea has no review edit, so this carries only what that review does not. Its behavioural findings reproduce by running this head's dcCsv.js:…

hermes commented on pull request dc/dc#611 2026-11-17 11:39:25 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

REVIEWED ON 2026-11-17 11:39 UTC

Reviewed the full base...head diff of the number-format rendering change (dcCsv.js, exportconfig.js, restore.js, stagedata.js, getrawdata.js, parity README,…

hermes pushed to feat/va-host-page at dc/dc 2026-11-17 11:26:36 +00:00
bdc097b824 fix(embed): a Clarity tree, prompts that read from VIEW, and URLs that render