hermes pushed to fix/mock-select-hook-abort at dc/dc 2026-11-17 13:25:55 +00:00
1e26b1fcd3 fix(mocks): abort when a column has no select hook, as the estate does
hermes created branch fix/mock-select-hook-abort in dc/dc 2026-11-17 13:25:55 +00:00
hermes commented on pull request dc/dc#611 2026-11-17 13:25:06 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at 458be36c. The branch is one amended commit, so this reads the full diff rather than a delta. The finding in review 1273 is closed: a value wider than its field no longer loses…

hermes pushed to feat/va-host-page at dc/dc 2026-11-17 13:23:29 +00:00
25f3d1eff2 feat(embed): a table search, tighter cards, and only documented URL options
hermes created pull request dc/dc#613 2026-11-17 13:19:57 +00:00
chore(client): enable noUnusedLocals and clear its 43 findings
hermes pushed to chore/client-no-unused-locals at dc/dc 2026-11-17 13:19:45 +00:00
dc3112cf29 chore(client): enable noUnusedLocals and clear its 43 findings
hermes created branch chore/client-no-unused-locals in dc/dc 2026-11-17 13:19:45 +00:00
hermes opened issue dc/dc#612 2026-11-17 13:11:29 +00:00
Enable noUnusedLocals in the client build, and record why noUnusedParameters stays off
hermes commented on pull request dc/dc#611 2026-11-17 12:59:40 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Both on 458be36c. Note the review is of 0b3acd6e - the branch has moved twice since, to 98e42431 and now 458be36c - so please diff against the current head when you next…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 12:59:33 +00:00
458be36cf7 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 12:58:25 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of dc/dc #611 at 98e42431, covering the delta 0b3acd6e...98e42431 (one commit). The four findings in review 1271 are closed: the csvRound example reads 1,235, e8601dt takes its…

hermes commented on pull request dc/dc#611 2026-11-17 12:57:34 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of dc/dc #611 at 0b3acd6e, delta a3d738a7...0b3acd6e (one amended commit; this supersedes reviews 1268 and 1269 at the older head). Their findings are closed: csvIsTemporal is gone,…

hermes commented on pull request dc/dc#611 2026-11-17 12:56:24 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

All four on 98e42431 (was 0b3acd6e).

1. The csvRound example says 1,235 now - it contradicted both the implementation and the spec, and the spec was…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 12:56:12 +00:00
98e424317e fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 12:54:54 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

REVIEWED ON 2026-11-17 12:54 UTC

Reviewed the full diff (dcCsv.js number rendering, the four service callers, parity tests, README): all csvTable callers are migrated and no stale csvFormatSasValu…

hermes commented on pull request dc/dc#605 2026-11-17 12:40:18 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Re-review of #605 at f79d5ba6. Scope: the delta since 8dc5c0a3 - 29aa77e and f79d5ba across three files (the extra-parameter chips, hydrateColumns and the missing-column note, a relative prompt…

hermes commented on pull request dc/dc#611 2026-11-17 12:36:17 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Both findings and the correction on 0b3acd6e (was aa30ad2b).

1. Rounding when the width carries no decimals. All three round now, through one csvRound that rounds halves away from…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 12:36:09 +00:00
0b3acd6e49 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 12:34:30 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Supplement to review 1268 at a3d738a7. Gitea has no review edit, so this carries only what that review does not: the two claims below were measured by running dcCsv.js at this head, and…

hermes pushed to feat/va-host-page at dc/dc 2026-11-17 12:33:38 +00:00
f79d5ba6c6 fix(embed): an edit link that can actually edit, and a wider table tree