hermes commented on pull request dc/dc#614 2026-11-17 14:22:48 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

All three on 61a2c96c (was 07928a11).

1. The predicate docstring no longer speaks for every service. It states the comparison it implements - now < tx_to, the editor lookups' shape - keeps…

hermes pushed to fix/mock-select-hook-abort at dc/dc 2026-11-17 14:22:41 +00:00
61a2c96c3b fix(mocks): abort when a column has no select hook, as the estate does
hermes commented on pull request dc/dc#614 2026-11-17 14:21:19 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

Reviewed PR #614 at 07928a11. The delta since the 0bbeff08 review is the single squashed commit "fix(mocks): abort when a column has no select hook, as the estate does": the rule lookup gains the…

hermes created pull request dc/dc#615 2026-11-17 14:21:00 +00:00
feat(embed): the report designer and the report page
hermes pushed to feat/embed-page at dc/dc 2026-11-17 14:20:55 +00:00
4e79ace94a feat(embed): the report designer and the report page, on release/7.23
hermes created branch feat/embed-page in dc/dc 2026-11-17 14:20:55 +00:00
hermes commented on pull request dc/dc#614 2026-11-17 14:08:00 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

Both on 07928a11 (was 0bbeff08).

1. The temporal filter - and it was not only missing, it was duplicated. The lookup now requires the rule to be in force, and rowInForce moved into…

hermes pushed to fix/mock-select-hook-abort at dc/dc 2026-11-17 14:07:54 +00:00
07928a1192 fix(mocks): abort when a column has no select hook, as the estate does
hermes commented on pull request dc/dc#614 2026-11-17 14:05:59 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

Re-reviewed at 0bbeff08. The branch was rewritten since the last review (1e26b1fc is no longer the head), so this reads the full diff rather than a delta. The prior finding is closed: the abort…

hermes commented on pull request dc/dc#605 2026-11-17 13:54:48 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Re-review of #605 at 2dfcc6c6. Scope: the delta since f79d5ba6 - 25f3d1ef and 2dfcc6c6 across ten files (a table search in the LOAD tree, the extra parameters narrowed to the documented ones and…

hermes commented on pull request dc/dc#613 2026-11-17 13:41:52 +00:00
chore(client): enable noUnusedLocals and clear its 43 findings

Reviewed the diff - no blocking issues found.

Production build is green at this head (Build / Build-and-ng-test runs npm run build, which compiles tsconfig.app.json and so enforces the new…

hermes commented on pull request dc/dc#614 2026-11-17 13:40:57 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

Fixed on 0bbeff08. You are right, and the reason is better than mine: _program already is the calling program path, it is what the sibling services pass (getlog.js:49, getcolvals.js:100),…

hermes pushed to fix/mock-select-hook-abort at dc/dc 2026-11-17 13:40:50 +00:00
0bbeff082b fix(mocks): abort when a column has no select hook, as the estate does
hermes commented on pull request dc/dc#614 2026-11-17 13:39:54 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

Reviewed the diff against the SAS service it emulates (sas/sasjs/services/editors/getdynamiccolvals.sas:150-156 - same wording, same &_program MAC, and the mock's rule predicate matches the data…

hermes pushed to feat/va-host-page at dc/dc 2026-11-17 13:36:41 +00:00
2dfcc6c6ec feat(embed): the va_log and debug URL parameters the docs describe
hermes created pull request dc/docs.datacontroller.io#37 2026-11-17 13:30:57 +00:00
docs(embed): the EMBED page - report designer, report link, and the two URLs
hermes pushed to docs/embed-page at dc/docs.datacontroller.io 2026-11-17 13:30:52 +00:00
cd6b8203ab docs(embed): the EMBED page - report designer, report link, and the two URLs
hermes created branch docs/embed-page in dc/docs.datacontroller.io 2026-11-17 13:30:52 +00:00
hermes created pull request dc/dc#614 2026-11-17 13:26:03 +00:00
fix(mocks): abort when a column has no select hook, as the estate does
hermes created branch fix/mock-select-hook-abort in dc/dc 2026-11-17 13:25:55 +00:00