All three on 61a2c96c (was 07928a11).
1. The predicate docstring no longer speaks for every service. It states the comparison it implements - now < tx_to, the editor lookups' shape - keeps…
Reviewed PR #614 at 07928a11. The delta since the 0bbeff08 review is the single squashed commit "fix(mocks): abort when a column has no select hook, as the estate does": the rule lookup gains the…
Both on 07928a11 (was 0bbeff08).
1. The temporal filter - and it was not only missing, it was duplicated. The lookup now requires the rule to be in force, and rowInForce moved into…
Re-reviewed at 0bbeff08. The branch was rewritten since the last review (1e26b1fc is no longer the head), so this reads the full diff rather than a delta. The prior finding is closed: the abort…
Re-review of #605 at 2dfcc6c6. Scope: the delta since f79d5ba6 - 25f3d1ef and 2dfcc6c6 across ten files (a table search in the LOAD tree, the extra parameters narrowed to the documented ones and…
Reviewed the diff - no blocking issues found.
Production build is green at this head (Build / Build-and-ng-test runs npm run build, which compiles tsconfig.app.json and so enforces the new…
Fixed on 0bbeff08. You are right, and the reason is better than mine: _program already is the calling program path, it is what the sibling services pass (getlog.js:49, getcolvals.js:100),…
Reviewed the diff against the SAS service it emulates (sas/sasjs/services/editors/getdynamiccolvals.sas:150-156 - same wording, same &_program MAC, and the mock's rule predicate matches the data…