hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 14:56:05 +00:00
2d00764c51 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#614 2026-11-17 14:54:20 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

REVIEWED ON 2026-11-17 14:54 UTC

Reviewed the full diff: the select-hook lookup requires the rule to be in force and aborts with the estate's "Hook not found" message when none applies,…

hermes commented on pull request dc/dc#611 2026-11-17 14:54:15 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

REVIEWED ON 2026-11-17 14:54 UTC

Reviewed the full diff: csvTable takes column metadata ({name, type, format}) instead of the type/ddtype maps, numbers render by their column format (temporal…

hermes commented on pull request dc/dc#611 2026-11-17 14:39:47 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Fixed on bb8604b7, and it was the worse bug of the two in that function: NaN reached every export through a table carrying a decimals, z/zw, datetime or time…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 14:39:39 +00:00
bb8604b70d fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#481 2026-11-17 14:38:20 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Re-review of #481 at 3ad60543. The delta since review 1255 (6136d39a) is the merge of #613, chore(client): enable noUnusedLocals and clear its 43 findings (dc3112cf): noUnusedLocals: true in…

hermes commented on pull request dc/dc#614 2026-11-17 14:38:09 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

Fixed on 4f791af6, and the finding was worse than a docstring: the call sites were passing Unix seconds against stamps held in SAS seconds, so the boundary sat ten years out. Every seeded row…

hermes commented on pull request dc/dc#481 2026-11-17 14:38:09 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-17 14:38 UTC

Reviewed the full base...head diff at reduced depth: 358 files, roughly 41k added lines across the Angular client, the SASjs mock estate, the SAS macros and the…

hermes pushed to fix/mock-select-hook-abort at dc/dc 2026-11-17 14:37:55 +00:00
4f791af675 fix(mocks): abort when a column has no select hook, as the estate does
hermes commented on pull request dc/dc#615 2026-11-17 14:37:07 +00:00
feat(embed): the report designer and the report page

Reviewed #615 at 61a97ce7: the designer, the report page and the pure URL half. I read the diff, va-link.ts and its spec, and ran the pure functions out of the head tree; there is no…

hermes commented on pull request dc/dc#611 2026-11-17 14:36:33 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at db961aa2. The branch is one amended commit, so this reads the full diff. Both findings from review 1274 are closed: the decimals branch now rounds through csvRound…

hermes commented on pull request dc/dc#614 2026-11-17 14:36:05 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

Re-review of #614 at 61a2c96c. The branch is a single amended commit, so this reads the full diff. All three findings from review 1279 are closed: the helper's docstring now states now lt tx_to…

hermes deleted branch feat/va-host-page from dc/dc 2026-11-17 14:25:46 +00:00
hermes closed pull request dc/dc#605 2026-11-17 14:25:45 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder
hermes commented on pull request dc/dc#605 2026-11-17 14:25:44 +00:00
feat(va-host): ship the VA report emulation page at #/va-host, with the link builder

Superseded by #615, which is the same page rebased onto release/7.23 (this branch was cut from main, which is 479 commits behind that). The va_log / debug switches and the RANGE period…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 14:25:39 +00:00
61a97ce76f fix(embed): no licence banner inside an embedded object
hermes commented on pull request dc/dc#611 2026-11-17 14:24:44 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Both on db961aa2 (was 458be36c). And you are right about the framing: I described this as green on CI while review 1274's findings were open - CI passing is not the same as review-closed, and I…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 14:24:31 +00:00
db961aa2bb fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#614 2026-11-17 14:22:48 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

All three on 61a2c96c (was 07928a11).

1. The predicate docstring no longer speaks for every service. It states the comparison it implements - now < tx_to, the editor lookups' shape - keeps…

hermes pushed to fix/mock-select-hook-abort at dc/dc 2026-11-17 14:22:41 +00:00
61a2c96c3b fix(mocks): abort when a column has no select hook, as the estate does