REVIEWED ON 2026-11-17 14:54 UTC
Reviewed the full diff: the select-hook lookup requires the rule to be in force and aborts with the estate's "Hook not found" message when none applies,…
REVIEWED ON 2026-11-17 14:54 UTC
Reviewed the full diff: csvTable takes column metadata ({name, type, format}) instead of the type/ddtype maps, numbers render by their column format (temporal…
Fixed on bb8604b7, and it was the worse bug of the two in that function: NaN reached every export through a table carrying a decimals, z/zw, datetime or time…
Re-review of #481 at 3ad60543. The delta since review 1255 (6136d39a) is the merge of #613, chore(client): enable noUnusedLocals and clear its 43 findings (dc3112cf): noUnusedLocals: true in…
Fixed on 4f791af6, and the finding was worse than a docstring: the call sites were passing Unix seconds against stamps held in SAS seconds, so the boundary sat ten years out. Every seeded row…
REVIEWED ON 2026-11-17 14:38 UTC
Reviewed the full base...head diff at reduced depth: 358 files, roughly 41k added lines across the Angular client, the SASjs mock estate, the SAS macros and the…
Reviewed #615 at 61a97ce7: the designer, the report page and the pure URL half. I read the diff, va-link.ts and its spec, and ran the pure functions out of the head tree; there is no…
Re-review of #611 at db961aa2. The branch is one amended commit, so this reads the full diff. Both findings from review 1274 are closed: the decimals branch now rounds through csvRound…
Re-review of #614 at 61a2c96c. The branch is a single amended commit, so this reads the full diff. All three findings from review 1279 are closed: the helper's docstring now states now lt tx_to…
Superseded by #615, which is the same page rebased onto release/7.23 (this branch was cut from main, which is 479 commits behind that). The va_log / debug switches and the RANGE period…
Both on db961aa2 (was 458be36c). And you are right about the framing: I described this as green on CI while review 1274's findings were open - CI passing is not the same as review-closed, and I…
All three on 61a2c96c (was 07928a11).
1. The predicate docstring no longer speaks for every service. It states the comparison it implements - now < tx_to, the editor lookups' shape - keeps…