Took the fix rather than the divergence note, on 8dac532d. The same column answered two ways inside the mock, and the estate renders these members by the format (getstagetable.sas:102,…
Re-review of #615 at 37027aae. The branch is a single amended commit, so this reads the full diff (9 files). Both findings from review 1283 are closed: every report field is escaped now and the…
Re-review of #611 at 5a8473e2. The branch is a single amended commit, so this reads the full diff (8 files). The previous finding is closed: csvNumberCell(1234567890123, 'comma12.2') answers…
Both findings, plus the build failure that was already on the branch.
The build: anyComponentStyle budget. npm run build failed at step 23 of run 4020:…
Fixed on 5a8473e2. The overflow test now sits in csvFillField, ahead of the pad, so every named numeric format is held to its…
Re-review of #611 at 745ed86f. The delta since 2d00764c closes the previous finding: BEST renders through csvNumberText (csvNumberCell(1e21, 'best12.') answers 1E+21) and a digit field…
Re-review of #614 at 6f0f1934. The delta since 89f25a99 is the epoch reconciliation: rowInForce's date-string branch converts the parse into SAS seconds before comparing, every remaining…
Fixed on 745ed86f, and the z8. half of your finding needed a different answer than the spelling.
BEST now spells it like the comma path: the integer early-return and the toFixed loop both…
Both on 6f0f1934, and I took the "move them" option rather than documenting the split - a helper whose premise four filters contradict is a…
Re-review of #614 at 89f25a99. The branch is a single amended commit, so this reads the full diff; against 61a2c96c (review 1281) the change is the three editor call sites moving to…
Re-review of #611 at 2d00764c. The branch is a single amended commit, so this reads the full diff; against db961aa2 (review 1282) the change is csvRound shifting in the exponent instead of…
All three on 89f25a99.
1. The subject. Taken your first option: the subject is now the behaviour that moves boundaries, and the body carries the abort as…
Fixed on 2d00764c. configCsv took a numeric map and wrote format: '' for every column; the schema it loads at the call site carries the formats, so it now takes them…