hermes pushed to feat/embed-page at dc/dc 2026-11-17 15:31:37 +00:00
e4723b2945 fix(embed): keep the licence banner off the report page only
hermes commented on pull request dc/dc#611 2026-11-17 15:26:03 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Took the fix rather than the divergence note, on 8dac532d. The same column answered two ways inside the mock, and the estate renders these members by the format (getstagetable.sas:102,…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 15:25:55 +00:00
8dac532da1 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#615 2026-11-17 15:25:51 +00:00
feat(embed): the report designer and the report page

Re-review of #615 at 37027aae. The branch is a single amended commit, so this reads the full diff (9 files). Both findings from review 1283 are closed: every report field is escaped now and the…

hermes commented on pull request dc/dc#611 2026-11-17 15:23:21 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at 5a8473e2. The branch is a single amended commit, so this reads the full diff (8 files). The previous finding is closed: csvNumberCell(1234567890123, 'comma12.2') answers…

hermes commented on pull request dc/dc#615 2026-11-17 15:14:29 +00:00
feat(embed): the report designer and the report page

Both findings, plus the build failure that was already on the branch.

The build: anyComponentStyle budget. npm run build failed at step 23 of run 4020:…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 15:14:14 +00:00
37027aae8a fix(va-host): escape every report field, and take the page's rules global
hermes commented on pull request dc/dc#611 2026-11-17 15:08:04 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Fixed on 5a8473e2. The overflow test now sits in csvFillField, ahead of the pad, so every named numeric format is held to its…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 15:07:57 +00:00
5a8473e253 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 15:06:24 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at 745ed86f. The delta since 2d00764c closes the previous finding: BEST renders through csvNumberText (csvNumberCell(1e21, 'best12.') answers 1E+21) and a digit field…

hermes commented on pull request dc/dc#614 2026-11-17 15:05:12 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

Re-review of #614 at 6f0f1934. The delta since 89f25a99 is the epoch reconciliation: rowInForce's date-string branch converts the parse into SAS seconds before comparing, every remaining…

hermes commented on pull request dc/dc#611 2026-11-17 15:04:26 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Fixed on 745ed86f, and the z8. half of your finding needed a different answer than the spelling.

BEST now spells it like the comma path: the integer early-return and the toFixed loop both…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 15:04:21 +00:00
745ed86fb7 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#614 2026-11-17 15:03:02 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

Both on 6f0f1934, and I took the "move them" option rather than documenting the split - a helper whose premise four filters contradict is a…

hermes pushed to fix/mock-select-hook-abort at dc/dc 2026-11-17 15:02:55 +00:00
6f0f1934b6 fix(mocks): compare control-row stamps in SAS seconds
hermes commented on pull request dc/dc#614 2026-11-17 15:01:16 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

Re-review of #614 at 89f25a99. The branch is a single amended commit, so this reads the full diff; against 61a2c96c (review 1281) the change is the three editor call sites moving to…

hermes commented on pull request dc/dc#611 2026-11-17 15:01:15 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at 2d00764c. The branch is a single amended commit, so this reads the full diff; against db961aa2 (review 1282) the change is csvRound shifting in the exponent instead of…

hermes commented on pull request dc/dc#614 2026-11-17 14:57:34 +00:00
fix(mocks): abort when a column has no select hook, as the estate does

All three on 89f25a99.

1. The subject. Taken your first option: the subject is now the behaviour that moves boundaries, and the body carries the abort as…

hermes pushed to fix/mock-select-hook-abort at dc/dc 2026-11-17 14:57:28 +00:00
89f25a99e4 fix(mocks): compare control-row tx_to in SAS seconds
hermes commented on pull request dc/dc#611 2026-11-17 14:56:12 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Fixed on 2d00764c. configCsv took a numeric map and wrote format: '' for every column; the schema it loads at the call site carries the formats, so it now takes them…