Reviewed the delta 4fc5569 -> dfd30eca (one commit, 14 files). node --test sas/mocks/test/*.test.js is 284 pass / 0 fail and node sas/mocks/test/parity/check.js reports 32 ok at this head.…
Both on dfd30eca, and both now have a spec behind them.
1. postdata.js:392 - the guard reads colFormats[key.toUpperCase()], the same key the map is written with at :225 and the same one…
REVIEWED ON 2026-11-18
Re-review of #615 at 16ae01de, covering e4723b29...16ae01de. The branch was rebased onto 8e9ac483 and took three commits since the last review:…
REVIEWED ON 2026-11-18
Re-review of #611 at 4fc55697. The branch was amended since de95a722, so this reads the full diff against 8e9ac483: the format renderer added to dcCsv.js (csvParseFormat,…
REVIEWED ON 2026-11-17 16:05 UTC
Reviewed the full base...head diff (360 files, ~41k additions) as one unit. This is a release aggregation, so depth was reduced: the CI workflows, the new…
All three on 4fc55697.
1. An explicit binding, and a loud failure. dcMockUtils evaluates dcCsv.js inside an IIFE and hands back one named object, instead of depending on a sloppy-mode…
Supplement to review 1296 at this head, carrying only what a live check changed about it: Gitea has no review edit, so the correction has to be a second review rather than an amendment.
-…
Re-review of #611 at de95a722. The branch is a single amended commit, rebased onto 8e9ac483 since the last review at 8dac532d, so this reads the full diff against 8e9ac483; both findings in review…
REVIEWED ON 2026-11-17 15:53 UTC
Reviewed the full base...head diff: the column-format renderer in dcCsv.js and its adoption across dcMockUtils, getrawdata, viewdata, getstagetable, postdata,…
Rebased onto release/7.23 at 8e9ac483 (the #614 merge), as promised - both branches touched dcMockUtils, so this keeps the merge to you a fast-forward.
The rebase was clean, and I checked the…
Both on 4311d16f.
1. The temporal renders are held to their width. A csvFractionFit(base, decimals, width) decides how many of the format's decimals the field still holds after the base…
Re-review of #615 at e4723b29. The branch is a single amended commit, so this reads the full diff against 3ad60543, and it was rewritten since 37027aae. No build or TestBed run - there is no…
Re-review of #611 at 8dac532d. The branch is a single amended commit, so this reads the full diff against 3ad60543; it was rewritten since 5a8473e2, so this body covers all of it. The formatSasValu…
Fair finding, and the fix is the first of your two options - the page's own route.
61a97ce7 hid the banner on !embed, and embed is truthy for embed=va and for any other value, so it took…