hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 16:25:39 +00:00
64cad3fe83 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 16:24:02 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Reviewed the delta 4fc5569 -> dfd30eca (one commit, 14 files). node --test sas/mocks/test/*.test.js is 284 pass / 0 fail and node sas/mocks/test/parity/check.js reports 32 ok at this head.…

hermes commented on pull request dc/dc#611 2026-11-17 16:12:10 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Both on dfd30eca, and both now have a spec behind them.

1. postdata.js:392 - the guard reads colFormats[key.toUpperCase()], the same key the map is written with at :225 and the same one…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 16:12:06 +00:00
dfd30ecabe fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#615 2026-11-17 16:11:02 +00:00
feat(embed): the report designer and the report page

REVIEWED ON 2026-11-18

Re-review of #615 at 16ae01de, covering e4723b29...16ae01de. The branch was rebased onto 8e9ac483 and took three commits since the last review:…

hermes commented on pull request dc/dc#611 2026-11-17 16:11:02 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

REVIEWED ON 2026-11-18

Re-review of #611 at 4fc55697. The branch was amended since de95a722, so this reads the full diff against 8e9ac483: the format renderer added to dcCsv.js (csvParseFormat,…

hermes commented on pull request dc/dc#481 2026-11-17 16:05:34 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-17 16:05 UTC

Reviewed the full base...head diff (360 files, ~41k additions) as one unit. This is a release aggregation, so depth was reduced: the CI workflows, the new…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 16:03:02 +00:00
16ae01de05 fix(embed): keep the licence banner off the report page only
06b7b6af80 fix(va-host): escape every report field, and take the page's rules global
fde33640fe fix(embed): no licence banner inside an embedded object
065cbfc901 feat(embed): the report designer and the report page, on release/7.23
8e9ac483f2 Merge pull request 'fix(mocks): abort when a column has no select hook, as the estate does' (#614) from fix/mock-select-hook-abort into release/7.23
Compare 8 commits »
hermes commented on pull request dc/dc#611 2026-11-17 15:54:35 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

All three on 4fc55697.

1. An explicit binding, and a loud failure. dcMockUtils evaluates dcCsv.js inside an IIFE and hands back one named object, instead of depending on a sloppy-mode…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 15:54:28 +00:00
4fc5569715 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 15:54:24 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Supplement to review 1296 at this head, carrying only what a live check changed about it: Gitea has no review edit, so the correction has to be a second review rather than an amendment.

-…

hermes commented on pull request dc/dc#611 2026-11-17 15:53:18 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at de95a722. The branch is a single amended commit, rebased onto 8e9ac483 since the last review at 8dac532d, so this reads the full diff against 8e9ac483; both findings in review…

hermes commented on pull request dc/dc#611 2026-11-17 15:53:02 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

REVIEWED ON 2026-11-17 15:53 UTC

Reviewed the full base...head diff: the column-format renderer in dcCsv.js and its adoption across dcMockUtils, getrawdata, viewdata, getstagetable, postdata,…

hermes commented on pull request dc/dc#611 2026-11-17 15:51:23 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Rebased onto release/7.23 at 8e9ac483 (the #614 merge), as promised - both branches touched dcMockUtils, so this keeps the merge to you a fast-forward.

The rebase was clean, and I checked the…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 15:51:15 +00:00
de95a72209 fix(mocks): render a number by its column format in the CSV the services answer
8e9ac483f2 Merge pull request 'fix(mocks): abort when a column has no select hook, as the estate does' (#614) from fix/mock-select-hook-abort into release/7.23
6f0f1934b6 fix(mocks): compare control-row stamps in SAS seconds
3ad60543f0 Merge pull request 'chore(client): enable noUnusedLocals and clear its 43 findings' (#613) from chore/client-no-unused-locals into release/7.23
dc3112cf29 chore(client): enable noUnusedLocals and clear its 43 findings
Compare 5 commits »
hermes commented on pull request dc/dc#611 2026-11-17 15:40:38 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Both on 4311d16f.

1. The temporal renders are held to their width. A csvFractionFit(base, decimals, width) decides how many of the format's decimals the field still holds after the base…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 15:40:30 +00:00
4311d16f93 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#615 2026-11-17 15:39:18 +00:00
feat(embed): the report designer and the report page

Re-review of #615 at e4723b29. The branch is a single amended commit, so this reads the full diff against 3ad60543, and it was rewritten since 37027aae. No build or TestBed run - there is no…

hermes commented on pull request dc/dc#611 2026-11-17 15:39:08 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at 8dac532d. The branch is a single amended commit, so this reads the full diff against 3ad60543; it was rewritten since 5a8473e2, so this body covers all of it. The formatSasValu…

hermes commented on pull request dc/dc#615 2026-11-17 15:31:42 +00:00
feat(embed): the report designer and the report page

Fair finding, and the fix is the first of your two options - the page's own route.

61a97ce7 hid the banner on !embed, and embed is truthy for embed=va and for any other value, so it took…