hermes commented on pull request dc/dc#481 2026-11-17 17:30:05 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-17 17:30 UTC

Reduced-depth review of the release/7.23 -> main merge (360 files): read the file map in full, the new and changed .gitea scripts and workflows, and the manifests…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 17:29:04 +00:00
d404de450f fix(va-host): deliver the message until the frame says it captured it
hermes commented on pull request dc/dc#611 2026-11-17 17:17:53 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Findings 2 and 3 are fixed on 3d7193e7; finding 1 does not belong to this diff, and I would like to be corrected if I have misread…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 17:17:48 +00:00
3d7193e7cd fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 17:16:33 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at 6a291c59. The branch was rewritten again: a41dc4a8, the head review 1306 sat on, is not on it and the head is one squashed commit, so this reads the full base...head diff (14…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 17:14:46 +00:00
80586c93f9 fix(va-host): the prompt's column picker follows its table
hermes commented on pull request dc/dc#615 2026-11-17 17:04:39 +00:00
feat(embed): the report designer and the report page

REVIEWED ON 2026-11-17 17:04 UTC

Reviewed the full base...head diff: the new va-host designer/report page (component, va-link helpers and its spec), the routing and nav changes, and the appended…

hermes commented on pull request dc/dc#611 2026-11-17 17:00:02 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Both on 6a291c59.

1. $vals renders through the shared renderer. sasNumericFormatted now takes its render from formatSasValue / csvNumberCell and keeps only the part that is specific…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 16:59:58 +00:00
6a291c59d2 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 16:57:35 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at a41dc4a8. The branch was rewritten: the head is a single squashed commit and 64cad3fe, the head both earlier reviews sat on, is no longer on it, so this reviews the full…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 16:52:03 +00:00
5969cf58eb fix(embed): a log that does not reload the frame, and SAS dates on the wire
hermes commented on pull request dc/dc#611 2026-11-17 16:41:32 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

All four on a41dc4a8.

1. The renderer is loaded at evaluation time and fails there. No per-cell throw is left: the IIFE that evaluates dcCsv.js now raises when the globals are absent, and…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 16:41:28 +00:00
a41dc4a892 fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 16:41:23 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Supplement to review 1303 at this head (64cad3fe). Gitea cannot edit a review, and 1303 does not carry the finding below, so it goes in a second review rather than being folded into theirs.

-…

hermes commented on pull request dc/dc#616 2026-11-17 16:41:14 +00:00
fix(makedata): skip the DC.html context rewrite when there is no client

Reviewed the diff: the DC.html compute-context rewrite in makedata.sas is now behind an existence guard.

  • sas/sasjs/targets/viya/services_viya/admin/makedata.sas:312…
hermes commented on pull request dc/dc#611 2026-11-17 16:40:04 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

REVIEWED ON 2026-11-17 16:40 UTC

Reviewed the full base...head diff of dc/dc#611 (14 files: the dcCsv.js format renderer, dcMockUtils formatSasValue, the exportconfig/postdata/getstagetable/getcol…

hermes created pull request dc/dc#616 2026-11-17 16:30:48 +00:00
fix(makedata): skip the DC.html context rewrite when there is no client
hermes pushed to fix/viya-makedata-web-optional at dc/dc 2026-11-17 16:30:42 +00:00
4ff7b624c5 fix(makedata): skip the DC.html context rewrite when there is no client
hermes created branch fix/viya-makedata-web-optional in dc/dc 2026-11-17 16:30:42 +00:00
hermes commented on pull request dc/dc#611 2026-11-17 16:25:43 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Both on 64cad3fe.

1. BEST answers the shortest render that reads back as the value. The loop now walks the decimals upward and takes the first render where Number(text) === value, with the…