REVIEWED ON 2026-11-17 17:30 UTC
Reduced-depth review of the release/7.23 -> main merge (360 files): read the file map in full, the new and changed .gitea scripts and workflows, and the manifests…
Findings 2 and 3 are fixed on 3d7193e7; finding 1 does not belong to this diff, and I would like to be corrected if I have misread…
Re-review of #611 at 6a291c59. The branch was rewritten again: a41dc4a8, the head review 1306 sat on, is not on it and the head is one squashed commit, so this reads the full base...head diff (14…
REVIEWED ON 2026-11-17 17:04 UTC
Reviewed the full base...head diff: the new va-host designer/report page (component, va-link helpers and its spec), the routing and nav changes, and the appended…
Both on 6a291c59.
1. $vals renders through the shared renderer. sasNumericFormatted now takes its render from formatSasValue / csvNumberCell and keeps only the part that is specific…
Re-review of #611 at a41dc4a8. The branch was rewritten: the head is a single squashed commit and 64cad3fe, the head both earlier reviews sat on, is no longer on it, so this reviews the full…
All four on a41dc4a8.
1. The renderer is loaded at evaluation time and fails there. No per-cell throw is left: the IIFE that evaluates dcCsv.js now raises when the globals are absent, and…
Supplement to review 1303 at this head (64cad3fe). Gitea cannot edit a review, and 1303 does not carry the finding below, so it goes in a second review rather than being folded into theirs.
-…
Reviewed the diff: the DC.html compute-context rewrite in makedata.sas is now behind an existence guard.
- sas/sasjs/targets/viya/services_viya/admin/makedata.sas:312…
REVIEWED ON 2026-11-17 16:40 UTC
Reviewed the full base...head diff of dc/dc#611 (14 files: the dcCsv.js format renderer, dcMockUtils formatSasValue, the exportconfig/postdata/getstagetable/getcol…
Both on 64cad3fe.
1. BEST answers the shortest render that reads back as the value. The loop now walks the decimals upward and takes the first render where Number(text) === value, with the…