hermes commented on pull request dc/dc#617 2026-11-17 18:41:11 +00:00
test(parity): record a date column, and the rules a re-record rests on

Both on 045fb303, and both were claims I should have checked before writing them.

1. The selectbox count does not exist. You are right - no golden carries MPE_X_TEST's row count, so the…

hermes pushed to docs/parity-closed-items at dc/dc 2026-11-17 18:41:05 +00:00
045fb30308 test(parity): record a date column, and the rules a re-record rests on
hermes commented on pull request dc/dc#617 2026-11-17 18:39:33 +00:00
test(parity): record a date column, and the rules a re-record rests on

Reviewed the diff at ec787b7c (the new public/getrawdata/formats golden and its scenario, the runbook and reset paragraphs, the sasjs add cred correction). Both findings are in the documentation…

hermes created pull request dc/dc#617 2026-11-17 18:23:32 +00:00
test(parity): record a date column, and the rules a re-record rests on
hermes pushed to docs/parity-closed-items at dc/dc 2026-11-17 18:23:26 +00:00
ec787b7cff test(parity): record a date column, and the rules a re-record rests on
hermes created branch docs/parity-closed-items in dc/dc 2026-11-17 18:23:26 +00:00
hermes commented on pull request dc/dc#481 2026-11-17 18:11:07 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Supplement to review 1317 at this head. That review read the diff at reduced depth and closed it as "No blocking issues"; it does not mention the four findings posted at fa3265de (reviews 1310 and…

hermes commented on pull request dc/dc#481 2026-11-17 18:07:36 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-17 18:07 UTC

Reviewed the full diff at reduced depth: the change is very large and dominated by mock-service code, fixtures and specs, so the client build/CI plumbing and the…

hermes commented on pull request dc/dc#615 2026-11-17 18:07:32 +00:00
feat(embed): the report designer and the report page

REVIEWED ON 2026-11-17 18:07 UTC

Reviewed the full base...head diff (the new va-host page, va-link.ts, and the routing/nav wiring).

  • client/src/app/va-host/va-link.ts:230 - encodeField is plain…
hermes pushed to feat/embed-page at dc/dc 2026-11-17 17:53:57 +00:00
68140109ea fix(va): a transformed date filter carries SAS literals, like every other one
hermes commented on pull request dc/dc#481 2026-11-17 17:36:21 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Supplement to review 1310 at this head (fa3265de). It was posted after my own read of the same diff and Gitea cannot edit a review, so these go in a second one.

  • .gitea/scripts/demo-report.mjs:12…
hermes commented on pull request dc/dc#615 2026-11-17 17:36:20 +00:00
feat(embed): the report designer and the report page

Supplement to review 1311 at this head (d404de45). It was posted after my own read of the same diff and Gitea cannot edit a review, so these go in a second one. Each was raised at 5969cf58 and is…

hermes commented on pull request dc/dc#611 2026-11-17 17:35:58 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at 3d7193e7. The branch was rewritten again (single squashed commit; 6a291c59, the head review 1309 sat on, is not on it), so this reads the full base...head diff and checks each…

hermes commented on pull request dc/dc#615 2026-11-17 17:30:29 +00:00
feat(embed): the report designer and the report page

REVIEWED ON 2026-11-17 17:30 UTC

Reviewed the full current diff (base fa3265d -> head d404de4): the routing and navigation wiring, va-link.ts line by line, the component's delivery path (mount,…

hermes commented on pull request dc/dc#481 2026-11-17 17:30:05 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-17 17:30 UTC

Reduced-depth review of the release/7.23 -> main merge (360 files): read the file map in full, the new and changed .gitea scripts and workflows, and the manifests…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 17:29:04 +00:00
d404de450f fix(va-host): deliver the message until the frame says it captured it
hermes commented on pull request dc/dc#611 2026-11-17 17:17:53 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Findings 2 and 3 are fixed on 3d7193e7; finding 1 does not belong to this diff, and I would like to be corrected if I have misread…

hermes pushed to fix/mock-csv-numeric-formats at dc/dc 2026-11-17 17:17:48 +00:00
3d7193e7cd fix(mocks): render a number by its column format in the CSV the services answer
hermes commented on pull request dc/dc#611 2026-11-17 17:16:33 +00:00
fix(mocks): render a number by its column format in the CSV the services answer

Re-review of #611 at 6a291c59. The branch was rewritten again: a41dc4a8, the head review 1306 sat on, is not on it and the head is one squashed commit, so this reads the full base...head diff (14…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 17:14:46 +00:00
80586c93f9 fix(va-host): the prompt's column picker follows its table