Both on 045fb303, and both were claims I should have checked before writing them.
1. The selectbox count does not exist. You are right - no golden carries MPE_X_TEST's row count, so the…
Reviewed the diff at ec787b7c (the new public/getrawdata/formats golden and its scenario, the runbook and reset paragraphs, the sasjs add cred correction). Both findings are in the documentation…
Supplement to review 1317 at this head. That review read the diff at reduced depth and closed it as "No blocking issues"; it does not mention the four findings posted at fa3265de (reviews 1310 and…
REVIEWED ON 2026-11-17 18:07 UTC
Reviewed the full diff at reduced depth: the change is very large and dominated by mock-service code, fixtures and specs, so the client build/CI plumbing and the…
REVIEWED ON 2026-11-17 18:07 UTC
Reviewed the full base...head diff (the new va-host page, va-link.ts, and the routing/nav wiring).
- client/src/app/va-host/va-link.ts:230 - encodeField is plain…
Supplement to review 1310 at this head (fa3265de). It was posted after my own read of the same diff and Gitea cannot edit a review, so these go in a second one.
- .gitea/scripts/demo-report.mjs:12…
Supplement to review 1311 at this head (d404de45). It was posted after my own read of the same diff and Gitea cannot edit a review, so these go in a second one. Each was raised at 5969cf58 and is…
Re-review of #611 at 3d7193e7. The branch was rewritten again (single squashed commit; 6a291c59, the head review 1309 sat on, is not on it), so this reads the full base...head diff and checks each…
REVIEWED ON 2026-11-17 17:30 UTC
Reviewed the full current diff (base fa3265d -> head d404de4): the routing and navigation wiring, va-link.ts line by line, the component's delivery path (mount,…
REVIEWED ON 2026-11-17 17:30 UTC
Reduced-depth review of the release/7.23 -> main merge (360 files): read the file map in full, the new and changed .gitea scripts and workflows, and the manifests…
Findings 2 and 3 are fixed on 3d7193e7; finding 1 does not belong to this diff, and I would like to be corrected if I have misread…
Re-review of #611 at 6a291c59. The branch was rewritten again: a41dc4a8, the head review 1306 sat on, is not on it and the head is one squashed commit, so this reads the full base...head diff (14…