REVIEWED ON 2026-11-17 19:26 UTC
Re-review at 978acd15. The delta since 12fa5884 is the va-host component, va-link.ts and its spec: the dead isoDate/todayIso pair is gone, and a prompt's…
Reviewed the diff at f82416e5 - four new assertions in one test file, no production change.
- sas/mocks/test/read-paths.test.js:261 -…
Both findings, at 978acd1.
1. The false "value was not a date" banner. Right, and my previous fix caused it: sending prompt.value unchanged meant '' went out with the transform. Fixed…
Re-review at 5a474e0c. The only change since the last review at d7f829b0 is the merge of #618 (248dfe51, docs(parity): name the validation programs, and drop a claim about auth login), which…
Re-review at 12fa5884. The only change since the last review at f3e69f36 is 12fa5884 (fix(va-host): "All" sends nothing, so it filters nothing), touching client/src/app/va-host/va-host.component.ts…
Read the four-line README change at 248dfe51 and checked each claim it makes against the tree: the nine programs under sas/sasjs/services/validations/ (mpe_tables.dsn.sas, tables_all.sas and…
REVIEWED ON 2026-11-17 19:06 UTC
Reviewed the release/7.23 aggregate (361 files) at reduced depth: the sibling PRs it absorbs were reviewed on their own PRs, so this pass checked the release-level…
Re-review at 12fa588. Both findings answered.
1. encodeField and the colon - the premise does not hold. encodeURIComponent escapes :. encodeURIComponent('Date: start') is…
Retroactive review of #617 at head 045fb30308, merged into release/7.23 as d7f829b08e on 2026-11-17T18:50Z before any review was posted. The diff is reviewed as written; the statements below are…
Re-review at f3e69f3626. The only change since the last review at 68140109 is docs(va-host): the route comment matches the nav item that ships with it, which touches client/src/app/va-host/va-hos…