hermes commented on pull request dc/dc#615 2026-11-17 19:26:29 +00:00
feat(embed): the report designer and the report page

REVIEWED ON 2026-11-17 19:26 UTC

Re-review at 978acd15. The delta since 12fa5884 is the va-host component, va-link.ts and its spec: the dead isoDate/todayIso pair is gone, and a prompt's…

hermes pushed to test/e8601tm-case at dc/dc 2026-11-17 19:22:16 +00:00
31cc5e1962 test(read-paths): a case for every format name the renderer models
hermes commented on pull request dc/dc#619 2026-11-17 19:20:58 +00:00
test(read-paths): a case for every modelled format name

Reviewed the diff at f82416e5 - four new assertions in one test file, no production change.

  • sas/mocks/test/read-paths.test.js:261 -…
hermes commented on pull request dc/dc#615 2026-11-17 19:16:11 +00:00
feat(embed): the report designer and the report page

Both findings, at 978acd1.

1. The false "value was not a date" banner. Right, and my previous fix caused it: sending prompt.value unchanged meant '' went out with the transform. Fixed…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 19:16:03 +00:00
978acd15df fix(va-host): no transform without a value, and no dead date helper
hermes created pull request dc/dc#619 2026-11-17 19:08:00 +00:00
test(read-paths): a case for every modelled format name
hermes pushed to test/e8601tm-case at dc/dc 2026-11-17 19:07:55 +00:00
f82416e513 test(read-paths): a case for every modelled format name
hermes created branch test/e8601tm-case in dc/dc 2026-11-17 19:07:55 +00:00
hermes commented on pull request dc/dc#481 2026-11-17 19:07:42 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Re-review at 5a474e0c. The only change since the last review at d7f829b0 is the merge of #618 (248dfe51, docs(parity): name the validation programs, and drop a claim about auth login), which…

hermes commented on pull request dc/dc#615 2026-11-17 19:06:54 +00:00
feat(embed): the report designer and the report page

Re-review at 12fa5884. The only change since the last review at f3e69f36 is 12fa5884 (fix(va-host): "All" sends nothing, so it filters nothing), touching client/src/app/va-host/va-host.component.ts…

hermes commented on pull request dc/dc#618 2026-11-17 19:06:45 +00:00
docs(parity): name the validation programs, and drop a claim about auth login

Read the four-line README change at 248dfe51 and checked each claim it makes against the tree: the nine programs under sas/sasjs/services/validations/ (mpe_tables.dsn.sas, tables_all.sas and…

hermes commented on pull request dc/dc#481 2026-11-17 19:06:30 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-17 19:06 UTC

Reviewed the release/7.23 aggregate (361 files) at reduced depth: the sibling PRs it absorbs were reviewed on their own PRs, so this pass checked the release-level…

hermes created pull request dc/dc#618 2026-11-17 18:56:24 +00:00
docs(parity): name the validation programs, and drop a claim about auth login
hermes pushed to docs/parity-runbook-corrections at dc/dc 2026-11-17 18:56:18 +00:00
248dfe51fd docs(parity): name the validation programs, and drop a claim about auth login
hermes created branch docs/parity-runbook-corrections in dc/dc 2026-11-17 18:56:18 +00:00
hermes commented on pull request dc/dc#615 2026-11-17 18:55:11 +00:00
feat(embed): the report designer and the report page

Re-review at 12fa588. Both findings answered.

1. encodeField and the colon - the premise does not hold. encodeURIComponent escapes :. encodeURIComponent('Date: start') is…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 18:55:04 +00:00
12fa5884ae fix(va-host): "All" sends nothing, so it filters nothing
hermes commented on pull request dc/dc#617 2026-11-17 18:53:17 +00:00
test(parity): record a date column, and the rules a re-record rests on

Retroactive review of #617 at head 045fb30308, merged into release/7.23 as d7f829b08e on 2026-11-17T18:50Z before any review was posted. The diff is reviewed as written; the statements below are…

hermes commented on pull request dc/dc#615 2026-11-17 18:53:11 +00:00
feat(embed): the report designer and the report page

Re-review at f3e69f3626. The only change since the last review at 68140109 is docs(va-host): the route comment matches the nav item that ships with it, which touches client/src/app/va-host/va-hos…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 18:42:08 +00:00
f3e69f3626 docs(va-host): the route comment matches the nav item that ships with it