hermes pushed to fix/embed-shapes-specs-list at dc/dc 2026-11-21 11:17:47 +00:00
c7e78bc37f test(ci): run the report-shape spec, so the coverage guard passes again
hermes pushed to feat/embed-scenarios at dc/dc 2026-11-21 11:12:44 +00:00
1ff3b56a5d test(embed): cover twelve report shapes as end-to-end cases
hermes commented on pull request dc/dc#661 2026-11-21 11:11:09 +00:00
test(embed): cover the designer's round trip and twelve report shapes

Scope correction: the card is out of the product.

Reviews 1506/1507/1508 refined a loader that should never have shipped: "more test cases on the Embed screen" meant tests for that page, and the…

hermes pushed to feat/embed-scenarios at dc/dc 2026-11-21 11:10:47 +00:00
a50388f1f2 test(embed): cover the designer's round trip, not a test card in the app
hermes commented on pull request dc/dc#661 2026-11-21 10:34:18 +00:00
test(embed): cover the designer's round trip and twelve report shapes

CI at b4cedfb is green: Build-and-ng-test success (4m20s), lighthouse success (7m5s), Build-and-test-development success (23m54s, re-run).

That last job failed on its first attempt after 24m51s…

hermes commented on pull request dc/dc#661 2026-11-21 09:28:44 +00:00
test(embed): cover the designer's round trip and twelve report shapes

Re-review at b4cedfb4. The delta since bca47e77 is 0884f495 (the previous findings answered) and b4cedfb4 (a spec for the disarm-timer teardown); the surface is still the scenario card, its styles…

hermes commented on pull request dc/dc#661 2026-11-21 09:17:03 +00:00
test(embed): cover the designer's round trip and twelve report shapes

All six findings answered at b4cedfb, plus the context note on the retarget case. The branch is also rebased onto fbcda45 (release/7.23 with #660), which is what the conflict was; that is a…

hermes pushed to feat/embed-scenarios at dc/dc 2026-11-21 09:09:31 +00:00
b4cedfb433 test(embed): pin the disarm timer's teardown
hermes pushed to feat/embed-scenarios at dc/dc 2026-11-21 09:09:22 +00:00
e3bab8f740 test(embed): pin the disarm timer's teardown
hermes commented on pull request dc/dc#481 2026-11-21 09:08:28 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-21 09:20 UTC

Delta since reviews 1500/1501 at b4fa330e: five commits merged as #660, a net of three files - client/lighthouserc.js (a label assertion), va-host.component.html…

hermes pushed to feat/embed-scenarios at dc/dc 2026-11-21 09:08:24 +00:00
0884f49540 fix(embed): answer the six review findings on the scenario card
c7792e3a2c test(embed): carry prompt edits and each switch through the report and back
f25aa201d2 test(embed): pin the report-to-designer round trip and the clause per scenario
5bc748134c feat(embed): offer twelve test scenarios on the designer
fbcda45abb Merge pull request 'fix(va-host): name the designer's tab rename box' (#660) from fix/va-host-a11y into release/7.23
Compare 9 commits »
hermes commented on pull request dc/dc#661 2026-11-21 01:07:57 +00:00
test(embed): cover the designer's round trip and twelve report shapes

Re-review at bca47e77. The only change since 27ac4fb is one commit, bca47e77 "test(embed): carry prompt edits and each switch through the report and back": two specs added to client/src/app/va-host…

hermes pushed to feat/embed-scenarios at dc/dc 2026-11-21 01:02:29 +00:00
bca47e77df test(embed): carry prompt edits and each switch through the report and back
hermes commented on pull request dc/dc#661 2026-11-21 00:48:58 +00:00
test(embed): cover the designer's round trip and twelve report shapes

Supplement to review 1506 at this head, not a restatement of it: that review already carries the shared failure message at :1870, the seedScenario contract at :2135 and the uncleared scenarioTimer…

hermes commented on pull request dc/dc#661 2026-11-21 00:39:42 +00:00
test(embed): cover the designer's round trip and twelve report shapes

REVIEWED ON 2026-11-21 00:39 UTC

Reviewed the full diff (scenario card in va-host, SCENARIOS table, builder helpers, styles, specs). Angular client change only; no manifest, lockfile or CI…

hermes pushed to feat/embed-scenarios at dc/dc 2026-11-21 00:27:08 +00:00
27ac4fb4f5 test(embed): pin the report-to-designer round trip and the clause per scenario
hermes commented on pull request dc/dc#661 2026-11-21 00:16:53 +00:00
test(embed): cover the designer's round trip and twelve report shapes

REVIEWED ON 2026-11-21 00:16 UTC

Reviewed the full base...head diff: the scenario builder, card template, styles and spec in va-host. No package.json, lockfile or CI change, so no hardening pass;…

hermes commented on pull request dc/dc#660 2026-11-21 00:14:03 +00:00
fix(va-host): name the designer's tab rename box

Reviewed the delta 5ce9aaad...23695701 (the branch was amended, one commit, same subject). The only change is the assertion the review at 5ce9aaad asked about: client/src/app/va-host/va-host.compon…

hermes commented on pull request dc/dc#660 2026-11-21 00:13:07 +00:00
fix(va-host): name the designer's tab rename box

Right - view.contains(input) was true by construction, since input came from view.querySelector. Fixed at 23695701 by making the line carry the claim the comment…

hermes pushed to fix/va-host-a11y at dc/dc 2026-11-21 00:13:02 +00:00
23695701d2 fix(va-host): name the designer's tab rename box