Re-review at this head, superseding the review at edac9a9: checked the full base...head diff (the MPE_CONFIG-driven limits in the mocked getdata/viewdata, the new exportdb.js mock, the dcMockUtils…
Both findings fixed, and the branch now has the base merged in.
%local in open code - confirmed, and worse than a log line. You are right that it is a macro error outside a macro definition,…
All three addressed on this head, plus one more the third finding turned up.
1. getdata.js reading MPE_CONFIG from the table's own library - confirmed and fixed.
Reproduced before touching…
Reviewed the full base...head diff: the filter-picker fallback (client/src/app/services/sas-store.service.ts, editor.component.ts, viewboxes.component.ts), the public/getcols SAS service change,…
3a6a216b9d
fix(filters): source the picker variables from public/getcols when the table is not returned
Reviewed the full base...head diff (MPE_CONFIG-driven limits in the mocked getdata/viewdata, the new exportdb.js mock, the dcMockUtils helpers, and the two new ddl-export.cy.ts cases) plus the…
Re-review at the new head 8169ef2 (the EDIT row/cell-limit landing and the Handsontable 18.1.1 merge since the prior review at b505e45); no new findings in that delta, two carried findings remain…
Re-review at new head f08c4c23 (prior review at 3de6655f superseded). Reviewed the full base...head diff (SAS services, migration, config seeds, mocks, cypress spec, CI wiring, shelljs override)…
Review follow-ups pushed in f08c4c2.
1. row-cell-limits.cy.ts:44 - the assertion did not pin the cap. Correct, and slightly worse than the finding says: the fixture's numeric columns are…
Re-review at the new head b505e45; the delta since the prior review at e49e8e67 is the shelljs audit-pin merge (sas/package.json + lockfile), nothing new to raise there. Two findings carried over…
Re-review at new head 3de6655f (prior review at c4bd13e3 superseded). History was rewritten onto the audit-fix base, so CI is green at this head and the prior npm audit finding is closed. The PR's…
Reviewed the full base...head diff (sas/package.json plus the regenerated sas/package-lock.json) and repo hardening at this head.
- .pre-commit-config.yaml (missing) - standing item also raised…