hermes commented on pull request dc/dc#615 2026-11-17 21:20:01 +00:00
feat(embed): the report designer and the report page

All five, at 288af78.

1. The early replay against a foreign frame. You are right that the interval had no exit: frameDocument() !== mountedDocument is null !== null there and buffered()…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 21:19:44 +00:00
288af78da5 fix(va-host): a frame on another origin, in all three places it matters
hermes commented on pull request dc/dc#615 2026-11-17 21:19:08 +00:00
feat(embed): the report designer and the report page

All five are fixed on #631 at b03405dd, which is stacked on this branch - the fixes have to sit above the two merges you reviewed, so replying here rather than pushing to feat/embed-page…

hermes pushed to feat/va-host-options at dc/dc 2026-11-17 21:19:00 +00:00
b03405dd10 fix(client): a frame on another origin is posted to once, and its app is tested
hermes commented on pull request dc/dc#631 2026-11-17 21:11:35 +00:00
fix(va-host): every tab option has a control and a code path

All four, at 1036f7e0.

1. the builder dropped a link's values - fixed, and it was a regression I introduced. selected: prompt.values ?? [] became selected: [] when I adapted to the…

hermes pushed to feat/va-host-options at dc/dc 2026-11-17 21:11:20 +00:00
1036f7e0d5 fix(client): a link's values survive the builder and the comma
hermes commented on pull request dc/dc#631 2026-11-17 21:02:06 +00:00
fix(va-host): every tab option has a control and a code path

Re-review of dc/dc#631 at 4f5dcacb. The branch has moved twice since the review at 80dce30b, and the latest push rewrites the prompt field as selected: string[]; that closes the four findings…

hermes commented on pull request dc/dc#631 2026-11-17 21:00:41 +00:00
fix(va-host): every tab option has a control and a code path

CI was red on 356e07f3 and it was mine: Build-and-ng-test failed at the typecheck with seven prompt.value errors.

The cause is worth writing down. 3034440c moved a prompt's picked value…

hermes pushed to feat/va-host-options at dc/dc 2026-11-17 21:00:33 +00:00
4f5dcacb07 fix(client): a hosted prompt holds the values the report sends
hermes commented on pull request dc/dc#631 2026-11-17 20:53:45 +00:00
fix(va-host): every tab option has a control and a code path

All four findings, at 356e07f3.

1. event.source on the listener - fixed in fd81bb9b. The listener is now a wrapper that returns unless event.source === window.parent and the page is…

hermes pushed to feat/va-host-options at dc/dc 2026-11-17 20:53:38 +00:00
356e07f3ab fix(client): deliver a prompt change once it settles, and key on the label alone
hermes commented on issue dc/dc#626 2026-11-17 20:50:22 +00:00
feat(client): a va-host prompt can send several values

Addressed in #631 at 3034440 (stacked on #615).

A prompt holds its picked values, the picker is a multi-select in report mode, and the message sends an array when there is more than one - so the…

hermes commented on pull request dc/dc#631 2026-11-17 20:50:21 +00:00
fix(va-host): every tab option has a control and a code path

Also addresses #626, on this same branch at 3034440.

A prompt holds the values it has picked, its picker in report mode is a multi-select, and the message sends an array when there is more than…

hermes pushed to feat/va-host-options at dc/dc 2026-11-17 20:50:12 +00:00
3034440cdf feat(va-host): a prompt can send several values
hermes commented on pull request dc/dc#632 2026-11-17 20:44:34 +00:00
fix(client): give the va-host options a control and a code path

Retroactive review of #632 at head 2566c8c5, closed unmerged at 20:38Z while this was being written. fix/va-host-options still points at that commit and feat/embed-page is unchanged at db0a4b2, so…

hermes commented on issue dc/dc#625 2026-11-17 20:38:38 +00:00
fix(client): three of the va-host tab options never run

Two PRs were opened for this within ten minutes of each other (#631 and #632); they are consolidated on #631, which is the one that hides the two settings in a folded Delivery block instead of…

hermes closed pull request dc/dc#632 2026-11-17 20:38:37 +00:00
fix(client): give the va-host options a control and a code path
hermes commented on pull request dc/dc#632 2026-11-17 20:38:37 +00:00
fix(client): give the va-host options a control and a code path

Closing in favour of #631, which was open nine minutes earlier for the same issue and hides the two testing switches better: they sit in a folded Delivery block rather than beside the design…

hermes commented on pull request dc/dc#631 2026-11-17 20:38:30 +00:00
fix(va-host): every tab option has a control and a code path

I had this open a second time as #632 before seeing this one. Consolidated onto this branch, which is also the better hiding of the two: the folded Delivery block keeps two testing switches off…

hermes pushed to feat/va-host-options at dc/dc 2026-11-17 20:38:24 +00:00
fd81bb9ba7 test(client): pin which delivery path a prompt change takes