All five, at 288af78.
1. The early replay against a foreign frame. You are right that the interval had no exit: frameDocument() !== mountedDocument is null !== null there and buffered()…
All five are fixed on #631 at b03405dd, which is stacked on this branch - the fixes have to sit above the two merges you reviewed, so replying here rather than pushing to feat/embed-page…
All four, at 1036f7e0.
1. the builder dropped a link's values - fixed, and it was a regression I introduced. selected: prompt.values ?? [] became selected: [] when I adapted to the…
Re-review of dc/dc#631 at 4f5dcacb. The branch has moved twice since the review at 80dce30b, and the latest push rewrites the prompt field as selected: string[]; that closes the four findings…
CI was red on 356e07f3 and it was mine: Build-and-ng-test failed at the typecheck with seven prompt.value errors.
The cause is worth writing down. 3034440c moved a prompt's picked value…
All four findings, at 356e07f3.
1. event.source on the listener - fixed in fd81bb9b. The listener is now a wrapper that returns unless event.source === window.parent and the page is…
Addressed in #631 at 3034440 (stacked on #615).
A prompt holds its picked values, the picker is a multi-select in report mode, and the message sends an array when there is more than one - so the…
Also addresses #626, on this same branch at 3034440.
A prompt holds the values it has picked, its picker in report mode is a multi-select, and the message sends an array when there is more than…
Retroactive review of #632 at head 2566c8c5, closed unmerged at 20:38Z while this was being written. fix/va-host-options still points at that commit and feat/embed-page is unchanged at db0a4b2, so…
Two PRs were opened for this within ten minutes of each other (#631 and #632); they are consolidated on #631, which is the one that hides the two settings in a folded Delivery block instead of…
Closing in favour of #631, which was open nine minutes earlier for the same issue and hides the two testing switches better: they sit in a folded Delivery block rather than beside the design…
I had this open a second time as #632 before seeing this one. Consolidated onto this branch, which is also the better hiding of the two: the folded Delivery block keeps two testing switches off…