Re-review of dc/dc#615 at 5be43178. The delta since c6b1025d is one commit, 5be4317, which rewrites applyHostedParameters to walk every tab (va-host.component.ts:290-329) and calls stopApplying()…
Fixed at 07ff993a, and the finding is right: the predicate had a case-by-case spec, but nothing asserted the line that reads it, so reinstating `
Both findings at c6b1025 are addressed at 5be4317, with a case each and no TestBed (the component is constructed directly, as the existing delivery cases are).
applyHostedParameters(:295)…
Re-review of dc/dc#633 at 6ff57cc. The delta since b9451796 is a rebase onto c6b1025 (the merge of #631, whose va-host changes are reviewed on #615), the delivery-block styles at client/src/styles.…
Re-review of dc/dc#633 at ee84ccb1. The delta since b9451796 is a rebase onto c6b1025 (the merge of #631, whose va-host changes are reviewed on #615) plus the delivery-block styles at client/src/st…
Re-review of dc/dc#615 at c6b1025d. The delta since 15fb55b6 is the merge of #631 (99d86c0: the delivery controls, multi-select prompts, the apply debounce and the hosted-parameter listener), and…
The second #631 finding was real and travelled into the merge: a prompt change made while a cross-origin frame was still loading was posted into a document with no listener, and logged as…
Rebased onto feat/embed-page at c6b1025d now that #631 has merged: head is ee84ccb1, base c6b1025d, and the diff against it is the nine files below.
Three conflicts, all in the prompt…
Reviewed the full base...head diff (9 files): the vader -> va-report rename across the report template, the component and its stylesheet, the removal of param.name as a filter fallback, and the…
Head replaced: b03405dd to 99d86c00, rebased onto feat/embed-page at 15fb55b6.
Why: the base moved while this was being reviewed. 15fb55b6 merged release/7.23 in and also brought…
Re-review of dc/dc#631 at b03405dd. The delta since 4f5dcacb is two commits (1036f7e0, b03405dd) and the findings from both earlier reviews are closed: a parsed link's values reach the prompt…
Re-review of dc/dc#615 at 15fb55b6. The delta since db0a4b26 is commit 288af78d plus the merge of release/7.23, and it closes four of the five findings from that review: the early replay posts…