hermes commented on pull request dc/dc#615 2026-11-17 22:16:25 +00:00
feat(embed): the report designer and the report page

Re-review of dc/dc#615 at 5be43178. The delta since c6b1025d is one commit, 5be4317, which rewrites applyHostedParameters to walk every tab (va-host.component.ts:290-329) and calls stopApplying()…

hermes commented on pull request dc/dc#633 2026-11-17 22:08:21 +00:00
refactor(client): name the report page for what it is, and match on the label

Fixed at 07ff993a, and the finding is right: the predicate had a case-by-case spec, but nothing asserted the line that reads it, so reinstating `

hermes pushed to fix/va-host-naming at dc/dc 2026-11-17 22:08:16 +00:00
07ff993afd test(client): assert the banner's route decision where it renders
hermes commented on pull request dc/dc#615 2026-11-17 22:06:25 +00:00
feat(embed): the report designer and the report page

Both findings at c6b1025 are addressed at 5be4317, with a case each and no TestBed (the component is constructed directly, as the existing delivery cases are).

  • applyHostedParameters (:295)…
hermes pushed to feat/embed-page at dc/dc 2026-11-17 22:06:21 +00:00
5be4317869 fix(va-host): hosted parameters reach every tab, and a delivery keeps to its tab
hermes commented on pull request dc/dc#633 2026-11-17 22:01:42 +00:00
refactor(client): name the report page for what it is, and match on the label

Re-review of dc/dc#633 at 6ff57cc. The delta since b9451796 is a rebase onto c6b1025 (the merge of #631, whose va-host changes are reviewed on #615), the delivery-block styles at client/src/styles.…

hermes commented on pull request dc/dc#633 2026-11-17 22:00:45 +00:00
refactor(client): name the report page for what it is, and match on the label

Re-review of dc/dc#633 at ee84ccb1. The delta since b9451796 is a rebase onto c6b1025 (the merge of #631, whose va-host changes are reviewed on #615) plus the delivery-block styles at client/src/st…

hermes commented on pull request dc/dc#615 2026-11-17 22:00:43 +00:00
feat(embed): the report designer and the report page

Re-review of dc/dc#615 at c6b1025d. The delta since 15fb55b6 is the merge of #631 (99d86c0: the delivery controls, multi-select prompts, the apply debounce and the hosted-parameter listener), and…

hermes commented on pull request dc/dc#631 2026-11-17 21:56:50 +00:00
fix(va-host): every tab option has a control and a code path

The second #631 finding was real and travelled into the merge: a prompt change made while a cross-origin frame was still loading was posted into a document with no listener, and logged as…

hermes pushed to fix/va-host-naming at dc/dc 2026-11-17 21:56:48 +00:00
6ff57cc007 refactor(client): name the report page for what it is, and match on the label
hermes commented on pull request dc/dc#633 2026-11-17 21:54:10 +00:00
refactor(client): name the report page for what it is, and match on the label

Rebased onto feat/embed-page at c6b1025d now that #631 has merged: head is ee84ccb1, base c6b1025d, and the diff against it is the nine files below.

Three conflicts, all in the prompt…

hermes pushed to fix/va-host-naming at dc/dc 2026-11-17 21:54:00 +00:00
ee84ccb1f9 refactor(client): name the report page for what it is, and match on the label
c6b1025d4a Merge pull request 'fix(va-host): every tab option has a control and a code path' (#631) from feat/va-host-options into feat/embed-page
99d86c0080 fix(va-host): every tab option has a control and a code path
Compare 3 commits »
hermes commented on pull request dc/dc#633 2026-11-17 21:45:47 +00:00
refactor(client): name the report page for what it is, and match on the label

Reviewed the full base...head diff (9 files): the vader -> va-report rename across the report template, the component and its stylesheet, the removal of param.name as a filter fallback, and the…

hermes commented on pull request dc/dc#631 2026-11-17 21:41:50 +00:00
fix(va-host): every tab option has a control and a code path

Head replaced: b03405dd to 99d86c00, rebased onto feat/embed-page at 15fb55b6.

Why: the base moved while this was being reviewed. 15fb55b6 merged release/7.23 in and also brought…

hermes pushed to feat/va-host-options at dc/dc 2026-11-17 21:41:39 +00:00
99d86c0080 fix(va-host): every tab option has a control and a code path
15fb55b666 Merge branch 'release/7.23' into feat/embed-page
288af78da5 fix(va-host): a frame on another origin, in all three places it matters
ecfa8f3a27 Merge pull request 'fix(tests): stop pointing _webout at a temporary file' (#621) from test/no-webout-hijack into release/7.23
2f59e7630b Merge pull request 'fix(csv): drop DTDATETIME, which SAS does not supply' (#620) from fix/drop-dtdatetime into release/7.23
Compare 17 commits »
hermes commented on pull request dc/dc#631 2026-11-17 21:33:25 +00:00
fix(va-host): every tab option has a control and a code path

Re-review of dc/dc#631 at b03405dd. The delta since 4f5dcacb is two commits (1036f7e0, b03405dd) and the findings from both earlier reviews are closed: a parsed link's values reach the prompt…

hermes commented on pull request dc/dc#615 2026-11-17 21:33:16 +00:00
feat(embed): the report designer and the report page

Re-review of dc/dc#615 at 15fb55b6. The delta since db0a4b26 is commit 288af78d plus the merge of release/7.23, and it closes four of the five findings from that review: the early replay posts…

hermes created pull request dc/dc#633 2026-11-17 21:32:49 +00:00
refactor(client): name the report page for what it is, and match on the label
hermes created branch fix/va-host-naming in dc/dc 2026-11-17 21:32:41 +00:00
hermes pushed to fix/va-host-naming at dc/dc 2026-11-17 21:32:41 +00:00
b94517962a refactor(client): name the report page for what it is, and match on the label