hermes created pull request dc/dc#632 2026-11-17 20:27:43 +00:00
fix(client): give the va-host options a control and a code path
hermes pushed to fix/va-host-options at dc/dc 2026-11-17 20:27:38 +00:00
2566c8c538 fix(client): give the va-host options a control and a code path
hermes created branch fix/va-host-options in dc/dc 2026-11-17 20:27:38 +00:00
hermes commented on pull request dc/dc#631 2026-11-17 20:27:24 +00:00
fix(va-host): every tab option has a control and a code path

Reviewed dc/dc#631 at 80dce30 (base feat/embed-page, so this is the stacked diff only). Prettier 3.8.4 --check is clean on the five changed files. CI is still running (Build / Build-and-ng-test,…

hermes commented on issue dc/dc#625 2026-11-17 20:22:59 +00:00
fix(client): three of the va-host tab options never run

Addressed in #631, stacked on #615 (feat/va-host-options -> feat/embed-page), at 80dce30.

  • mode has a control and a code path: refresh re-mounts the frame on a prompt change (a new…
hermes created pull request dc/dc#631 2026-11-17 20:22:51 +00:00
fix(va-host): every tab option has a control and a code path
hermes pushed to feat/va-host-options at dc/dc 2026-11-17 20:22:43 +00:00
80dce30bec fix(va-host): every tab option has a control and a code path
db0a4b2641 Merge pull request 'fix(client): the va-host base keeps its query, and the author owns it' (#630) from fix/va-host-app-url into feat/embed-page
74fd6d9855 fix(client): the va-host base keeps its query, and the author owns it
Compare 3 commits »
hermes commented on pull request dc/dc#630 2026-11-17 20:17:33 +00:00
fix(client): the va-host base keeps its query, and the author owns it

Retroactive review of #630 at head 74fd6d98, merged into feat/embed-page as db0a4b26 on 2026-11-17 before any review was posted. The code is on that branch (and in the head of #615), so these are…

hermes commented on pull request dc/dc#615 2026-11-17 20:17:32 +00:00
feat(embed): the report designer and the report page

Re-review at db0a4b26. The delta since 34c9ba8 is commit 022e0a0e (the sandbox contract) and the merge of #630, which brought that PR's four files in; everything below is on that delta.

-…

hermes pushed to feat/va-host-options at dc/dc 2026-11-17 20:16:37 +00:00
948c54e4be fix(va-host): every tab option has a control and a code path
hermes created branch feat/va-host-options in dc/dc 2026-11-17 20:16:36 +00:00
hermes commented on issue dc/dc#623 2026-11-17 20:10:16 +00:00
fix(client): va-host derives the app URL, so a query-carried deployment gets dead links

A fix is open against #615: #630, on fix/va-host-app-url, targeting feat/embed-page.

What it does:

  • appBaseOf in va-link.ts reads the app URL from the window location with its query, so…
hermes commented on issue dc/dc#624 2026-11-17 20:07:47 +00:00
fix(client): the va-host frame grants a looser sandbox than VA, and there are now two VA hosts

Addressed in #615 at 022e0a0, with the decision stated there: keep the page and take VA's token set verbatim in one exported constant.

  • VA_SANDBOX in client/src/app/va-host/va-link.ts holds…
hermes commented on pull request dc/dc#615 2026-11-17 20:07:46 +00:00
feat(embed): the report designer and the report page

Addresses #624 at 022e0a0.

Decision: keep the page, and take VA's token set verbatim in one constant. I did not reuse /ddc-host.

Why not the reuse option: /ddc-host is a server-side…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 20:07:39 +00:00
022e0a0eb8 fix(va-host): frame Data Controller under VA's own sandbox tokens
hermes created pull request dc/dc#630 2026-11-17 20:07:00 +00:00
fix(client): the va-host base keeps its query, and the author owns it
hermes pushed to fix/va-host-app-url at dc/dc 2026-11-17 20:06:49 +00:00
74fd6d9855 fix(client): the va-host base keeps its query, and the author owns it
hermes created branch fix/va-host-app-url in dc/dc 2026-11-17 20:06:49 +00:00
hermes commented on issue dc/dc#622 2026-11-17 19:54:50 +00:00
fix(client): the va-host report page - one deployment shape, a looser sandbox, and options that never run

Split into per-item issues, since the findings have different owners and different urgency. The review text stays here as the…

hermes closed issue dc/dc#622 2026-11-17 19:54:50 +00:00
fix(client): the va-host report page - one deployment shape, a looser sandbox, and options that never run