hermes commented on issue dc/dc#625 2026-11-17 23:03:40 +00:00
fix(client): three of the va-host tab options never run

Landed. mode and timing have controls, in a folded Delivery block, and both have a path through the code - refresh re-mounts the frame on a prompt change, prompt posts into the running…

hermes closed issue dc/dc#624 2026-11-17 23:03:40 +00:00
fix(client): the va-host frame grants a looser sandbox than VA, and there are now two VA hosts
hermes commented on pull request dc/dc#615 2026-11-17 23:03:16 +00:00
feat(embed): the report designer and the report page

Re-review of dc/dc#615 at 5262dc30. The delta since 14a015e6 is the merge of #633 (the page rename, the banner predicate with its template spec, and the label-only parameter key), #635 (the e2e…

hermes commented on pull request dc/dc#634 2026-11-17 22:56:43 +00:00
test(client): put the report designer under the accessibility floor

Both reviews, at 24531431 - rebased onto 97631f60, so this PR is now only the lighthouserc change (one file, seven lines) and the release-type finding answers itself: the banner fix, the guard…

hermes pushed to test/va-host-a11y at dc/dc 2026-11-17 22:56:38 +00:00
245314311c test(client): put the report pages under the accessibility floor
97631f6056 Merge pull request 'refactor(client): name the report page for what it is, and match on the label' (#633) from fix/va-host-naming into feat/embed-page
14a015e6fd fix(va-host): only the visible tab's prompts ask for a delivery
5be4317869 fix(va-host): hosted parameters reach every tab, and a delivery keeps to its tab
Compare 4 commits »
hermes created pull request dc/dc#635 2026-11-17 22:56:08 +00:00
fix(client): the e2e transform case expects the literal the app writes
hermes pushed to fix/e2e-and-review at dc/dc 2026-11-17 22:56:08 +00:00
b5a97b4177 fix(client): the e2e transform case expects the literal the app writes
hermes created branch fix/e2e-and-review in dc/dc 2026-11-17 22:56:08 +00:00
hermes commented on pull request dc/dc#634 2026-11-17 22:47:24 +00:00
test(client): put the report designer under the accessibility floor

Supplements review 1346 at this head. Gitea has no review edit, so the one finding that review does not carry is posted here rather than folded into it.

  • client/lighthouserc.js:67…
hermes commented on pull request dc/dc#634 2026-11-17 22:45:28 +00:00
test(client): put the report designer under the accessibility floor

REVIEWED ON 2026-11-17 22:45 UTC

Reviewed the full base...head diff: lighthouserc, licence-banner predicate and its new util + specs, va-filter param-key handling and specs, va-host template/compo…

hermes commented on pull request dc/dc#633 2026-11-17 22:35:12 +00:00
refactor(client): name the report page for what it is, and match on the label

Re-review of dc/dc#633 at 103a0a5a. The delta since 07ff993a is one commit, 103a0a5a, which rewrites the docstring in client/src/app/shared/utils/hides-licence-banner.ts to name both suppressions…

hermes commented on pull request dc/dc#615 2026-11-17 22:35:11 +00:00
feat(embed): the report designer and the report page

Re-review of dc/dc#615 at 14a015e6. The delta since 5be43178 is one commit, 14a015e6, which takes const active = this.tab before the loop in applyHostedParameters and raises changed only for a…

hermes created pull request dc/dc#634 2026-11-17 22:32:17 +00:00
test(client): put the report designer under the accessibility floor
hermes pushed to test/va-host-a11y at dc/dc 2026-11-17 22:32:12 +00:00
294b962f2c test(client): put the report designer under the accessibility floor
hermes created branch test/va-host-a11y in dc/dc 2026-11-17 22:32:12 +00:00
hermes commented on pull request dc/dc#615 2026-11-17 22:22:03 +00:00
feat(embed): the report designer and the report page

Fixed at 14a015e. changed is now compared against the visible tab, taken before the loop (va-host.component.ts:290-334): its prompts decide whether a delivery is owed, the other tabs still take…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 22:21:57 +00:00
14a015e6fd fix(va-host): only the visible tab's prompts ask for a delivery
hermes commented on pull request dc/dc#633 2026-11-17 22:21:25 +00:00
refactor(client): name the report page for what it is, and match on the label

Right, and at 103a0a5a: the docstring said "exactly one place" and "everywhere else it shows", while the function also suppresses the banner on /licensing/* - and the spec two lines below…

hermes pushed to fix/va-host-naming at dc/dc 2026-11-17 22:21:21 +00:00
103a0a5a28 docs(client): the banner has two suppressions, not one
hermes commented on pull request dc/dc#633 2026-11-17 22:16:36 +00:00
refactor(client): name the report page for what it is, and match on the label

Re-review of dc/dc#633 at 07ff993a. The delta since 6ff57cc0 is one commit, 07ff993, which adds client/src/app/app.component.spec.ts: three render-level cases over hidesLicenceBanner, asserting…