Landed. mode and timing have controls, in a folded Delivery block, and both have a path through the code - refresh re-mounts the frame on a prompt change, prompt posts into the running…
Re-review of dc/dc#615 at 5262dc30. The delta since 14a015e6 is the merge of #633 (the page rename, the banner predicate with its template spec, and the label-only parameter key), #635 (the e2e…
Both reviews, at 24531431 - rebased onto 97631f60, so this PR is now only the lighthouserc change (one file, seven lines) and the release-type finding answers itself: the banner fix, the guard…
Supplements review 1346 at this head. Gitea has no review edit, so the one finding that review does not carry is posted here rather than folded into it.
- client/lighthouserc.js:67…
REVIEWED ON 2026-11-17 22:45 UTC
Reviewed the full base...head diff: lighthouserc, licence-banner predicate and its new util + specs, va-filter param-key handling and specs, va-host template/compo…
Re-review of dc/dc#633 at 103a0a5a. The delta since 07ff993a is one commit, 103a0a5a, which rewrites the docstring in client/src/app/shared/utils/hides-licence-banner.ts to name both suppressions…
Re-review of dc/dc#615 at 14a015e6. The delta since 5be43178 is one commit, 14a015e6, which takes const active = this.tab before the loop in applyHostedParameters and raises changed only for a…
Fixed at 14a015e. changed is now compared against the visible tab, taken before the loop (va-host.component.ts:290-334): its prompts decide whether a delivery is owed, the other tabs still take…
Right, and at 103a0a5a: the docstring said "exactly one place" and "everywhere else it shows", while the function also suppresses the banner on /licensing/* - and the spec two lines below…
Re-review of dc/dc#633 at 07ff993a. The delta since 6ff57cc0 is one commit, 07ff993, which adds client/src/app/app.component.spec.ts: three render-level cases over hidesLicenceBanner, asserting…