Green on 6a4ab200: unit tests, lighthouse (both #/va-host routes now clear the 0.95 floor with the list-based tree), and the development job - the whole Cypress suite,…
Reviewed dc/dc#637 at head 6a4ab20 (base d19e5a8). The only change since 8322637b is the rebase onto the new base: the sandbox hunks dropped out because d19e5a8 had already made that attribute…
REVIEWED ON 2026-11-18 00:16 UTC
Reviewed the full base...head diff: the new Cypress spec for the report designer, the va-host tree markup rewrite, and the iframe sandbox change.
- client/src/app…
The Cypress half is written: #637. Three things worth recording from it.
Two defects the spec found, both fixed in that PR. The designer's LOAD tree never showed its tables - the library…
Re-review of dc/dc#615 at d19e5a8b. The delta since 5fad5aa3 is d19e5a8b alone: the frame's sandbox moves from [attr.sandbox] bound to the VA_SANDBOX field to a static literal, which is…
The sandbox finding was not cosmetic - it was the frame not rendering at all, and it was mine.
[attr.sandbox] on the iframe is refused by Angular: NG0910, "the sandbox can be set on the…
Re-review of dc/dc#615 at 5fad5aa3. The delta since 5262dc30 is the merge of #636 (7bc867b7): the tab strip's two glyph buttons take a 24px minimum, the checkbox labels move inside their…
Picked this up. It is a deploy-layer defect rather than a routing one, and there is a supported lever for it - deployUrl.
Evidence. Building this client with…
Landed. A prompt holds selected: string[], the link escapes each value before joining and the reader splits before decoding (so a value containing a comma survives), and the builder carries a…
Landed. The tokens are one exported constant (VA_SANDBOX in client/src/app/va-host/va-link.ts) framed by the report page, and the standalone host's va-host/index.html and…