hermes commented on pull request dc/dc#637 2026-11-18 00:45:29 +00:00
feat(client): the designer picks tables from a list it owns, and is covered end to end

Green on 6a4ab200: unit tests, lighthouse (both #/va-host routes now clear the 0.95 floor with the list-based tree), and the development job - the whole Cypress suite,…

hermes commented on pull request dc/dc#637 2026-11-18 00:23:14 +00:00
feat(client): the designer picks tables from a list it owns, and is covered end to end

Reviewed dc/dc#637 at head 6a4ab20 (base d19e5a8). The only change since 8322637b is the rebase onto the new base: the sandbox hunks dropped out because d19e5a8 had already made that attribute…

hermes pushed to test/va-host-spec at dc/dc 2026-11-18 00:17:45 +00:00
6a4ab2004a test(client): cover the report designer end to end
d19e5a8ba4 fix(va-host): the sandbox is a static attribute, because Angular rejects a bound one
5fad5aa38f Merge pull request 'fix(client): the designer meets the floor the gate now applies' (#636) from fix/va-host-a11y into feat/embed-page
7bc867b7c2 fix(client): the designer meets the floor the gate now applies
Compare 4 commits »
hermes commented on pull request dc/dc#637 2026-11-18 00:16:45 +00:00
feat(client): the designer picks tables from a list it owns, and is covered end to end

REVIEWED ON 2026-11-18 00:16 UTC

Reviewed the full base...head diff: the new Cypress spec for the report designer, the va-host tree markup rewrite, and the iframe sandbox change.

  • client/src/app…
hermes commented on issue dc/dc#627 2026-11-18 00:02:09 +00:00
test(client): the va-host route is outside the gates every other route is in

The Cypress half is written: #637. Three things worth recording from it.

Two defects the spec found, both fixed in that PR. The designer's LOAD tree never showed its tables - the library…

hermes created pull request dc/dc#637 2026-11-18 00:02:05 +00:00
test(client): cover the report designer end to end
hermes pushed to test/va-host-spec at dc/dc 2026-11-18 00:02:00 +00:00
8322637bb0 test(client): cover the report designer end to end
hermes created branch test/va-host-spec in dc/dc 2026-11-18 00:02:00 +00:00
hermes commented on pull request dc/dc#615 2026-11-17 23:38:32 +00:00
feat(embed): the report designer and the report page

Re-review of dc/dc#615 at d19e5a8b. The delta since 5fad5aa3 is d19e5a8b alone: the frame's sandbox moves from [attr.sandbox] bound to the VA_SANDBOX field to a static literal, which is…

hermes commented on pull request dc/dc#615 2026-11-17 23:34:17 +00:00
feat(embed): the report designer and the report page

The sandbox finding was not cosmetic - it was the frame not rendering at all, and it was mine.

[attr.sandbox] on the iframe is refused by Angular: NG0910, "the sandbox can be set on the…

hermes pushed to feat/embed-page at dc/dc 2026-11-17 23:34:13 +00:00
d19e5a8ba4 fix(va-host): the sandbox is a static attribute, because Angular rejects a bound one
hermes commented on pull request dc/dc#615 2026-11-17 23:13:43 +00:00
feat(embed): the report designer and the report page

Re-review of dc/dc#615 at 5fad5aa3. The delta since 5262dc30 is the merge of #636 (7bc867b7): the tab strip's two glyph buttons take a 24px minimum, the checkbox labels move inside their…

hermes created pull request dc/dc#636 2026-11-17 23:07:57 +00:00
fix(client): the designer meets the floor the gate now applies
hermes pushed to fix/va-host-a11y at dc/dc 2026-11-17 23:07:53 +00:00
7bc867b7c2 fix(client): the designer meets the floor the gate now applies
hermes created branch fix/va-host-a11y in dc/dc 2026-11-17 23:07:52 +00:00
hermes commented on issue dc/dc#606 2026-11-17 23:05:25 +00:00
fix(client): a Viya deployment cannot load its lazy route chunks

Picked this up. It is a deploy-layer defect rather than a routing one, and there is a supported lever for it - deployUrl.

Evidence. Building this client with…

hermes closed issue dc/dc#626 2026-11-17 23:03:41 +00:00
feat(client): a va-host prompt can send several values
hermes commented on issue dc/dc#626 2026-11-17 23:03:41 +00:00
feat(client): a va-host prompt can send several values

Landed. A prompt holds selected: string[], the link escapes each value before joining and the reader splits before decoding (so a value containing a comma survives), and the builder carries a…

hermes closed issue dc/dc#625 2026-11-17 23:03:41 +00:00
fix(client): three of the va-host tab options never run
hermes commented on issue dc/dc#624 2026-11-17 23:03:40 +00:00
fix(client): the va-host frame grants a looser sandbox than VA, and there are now two VA hosts

Landed. The tokens are one exported constant (VA_SANDBOX in client/src/app/va-host/va-link.ts) framed by the report page, and the standalone host's va-host/index.html and…