Re-review at a0f009dd. The delta since ecfa8f3a is 26 files and about 5,750 added lines: the embed-page branch merged at this head, which brings the report designer and the report page…
REVIEWED ON 2026-11-18 09:59 UTC
Re-review at b8f8fa81, which merges #637 (the designer's own table picker plus an end-to-end spec) into this branch. The delta since 6964ab15 is that sibling…
Reviewed dc/dc#637 at head 3678f8bc (base 6964ab15). Since the review at b422ddd0 the branch carries one commit, 3678f8bc, deleting the dead Clarity rules and rewriting the sandbox docstring. The…
Head 3678f8bc. All three were…
Reviewed dc/dc#637 at head b422ddd0 (base 6964ab15). Since the review at 07b2b905 the branch added two commits: the VA sandbox docstring rewrite, and the fix commit that drops the false licence-ord…
Head b422ddd0. Both findings were right; the licence one was wrong in a way only a run could…
Reviewed dc/dc#637 at head 07b2b905 (base 6964ab15). Since the review at 6a4ab20 the branch was rebased onto feat/embed-page and its single commit is now 07b2b90; the findings raised there are…
Head 07b2b905, rebased onto 6964ab15. One finding per line, oldest review…
All four at 6964ab1.
- Sandbox set, now checked.
client/scripts/check-sandbox.mjsreadsVA_SANDBOX, the report template,va-host/report.jsonandva-host/index.html, compares them as…
Re-review of dc/dc#615 at 6964ab15. The delta since 4461322e is 6964ab15 alone ("fix(client): four things the review found still open"): the sandbox consistency gate as client/scripts/check-sandbox…
Re-review of dc/dc#615 at 4461322e. The delta since d19e5a8b is 4461322e alone: the "Data Controller URL" card, its input and onAppUrlChange are gone (the app now comes only from…