hermes pushed to fix/loadfile-quoted-values at dc/dc 2026-11-18 12:34:54 +00:00
f07d0fb901 test(sas): cover loadfile with a value wrapped in single quotes
3a4ddd291e fix(client): quote values that hold a quote character in the upload csv
Compare 2 commits »
hermes created branch fix/loadfile-quoted-values in dc/dc 2026-11-18 12:34:53 +00:00
hermes commented on pull request dc/docs.datacontroller.io#37 2026-11-18 12:33:28 +00:00
docs(embed): the EMBED page - report designer, report link, and the two URLs

Updated on the same branch, so this PR carries the new contract: va and header instead of embed.

  • docs/visual-analytics.md - the URL section leads with va=1, explains that it implies a…
hermes commented on pull request dc/dc#639 2026-11-18 12:33:28 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Show header is in Tab options at 59278cb, off by default.

Measured on the deployed app-loc rather than described:

  • The four switches read, in order:…
hermes pushed to feat/embed-polish at dc/dc 2026-11-18 12:33:21 +00:00
59278cb8ae feat(embed): a Show header switch on the designer, off by default
hermes pushed to docs/embed-page at dc/docs.datacontroller.io 2026-11-18 12:17:50 +00:00
e5b8b01734 docs(va): the embed switches are va and header, not embed
hermes commented on pull request dc/dc#639 2026-11-18 12:13:59 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Re-reviewed at d723290f: one commit since the 5aadaf45 review (feat(embed): split embed into header and va, and retire embed=va). Build-and-ng-test is green at this head, Build-and-test-development…

hermes commented on pull request dc/dc#639 2026-11-18 12:05:12 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

The embed switches are split, embed=va is deprecated, and legacy links are rewritten in place - d723290.

The contract now

  • va=1 - the report drives this object: its parameters…
hermes pushed to feat/embed-polish at dc/dc 2026-11-18 12:05:05 +00:00
d723290fe4 feat(embed): split embed into header and va, and retire embed=va
hermes commented on pull request dc/dc#639 2026-11-18 11:33:56 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Reviewed the diff at 5aadaf45 (va-host.component.html, va-link.ts, va-link.spec.ts, styles.scss). Build-and-test-development is still running at this head, so this is a code review only.

-…

hermes created pull request dc/dc#639 2026-11-18 11:19:34 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor
hermes pushed to feat/embed-polish at dc/dc 2026-11-18 11:19:26 +00:00
5aadaf450a fix(va-host): mark the chosen table, order the formula row, and deliver into the running editor
hermes created branch feat/embed-polish in dc/dc 2026-11-18 11:19:26 +00:00
hermes commented on pull request dc/dc#638 2026-11-18 10:23:56 +00:00
fix(client): the tree name truncates in a box of its own

Reviewed the delta 0210d523...0c68707c. The only change since the last review is text-overflow: ellipsis coming off the .tree-lib / .tree-table group at client/src/styles.scss:6455, which…

hermes commented on pull request dc/dc#638 2026-11-18 10:20:53 +00:00
fix(client): the tree name truncates in a box of its own

Right - the twin had the same inert declaration. Head 0c68707c.

text-overflow: ellipsis is off the .designer-tree .tree-lib, .designer-tree .tree-table group as well; the group keeps…

hermes pushed to fix/tree-label-truncation at dc/dc 2026-11-18 10:20:50 +00:00
0c68707c1f fix(client): the row keeps its text on one line, and the span does the truncating
hermes commented on pull request dc/dc#638 2026-11-18 10:14:28 +00:00
fix(client): the tree name truncates in a box of its own

Reviewed the diff at 0210d523 - the two tree-name spans and the stylesheet split they need.

  • client/src/styles.scss:6457 text-overflow: ellipsis; is still declared on the row buttons in the…
hermes deleted branch test/va-host-spec from dc/dc 2026-11-18 10:06:34 +00:00
hermes commented on pull request dc/dc#637 2026-11-18 10:06:34 +00:00
feat(client): the designer picks tables from a list it owns, and is covered end to end

Review 1357's finding is right, and it merged before the fix could land: #637's merge at 09:52:21 took 3678f8bc, and the truncation fix was pushed after that. It is carried by #638 against…

hermes pushed to fix/tree-label-truncation at dc/dc 2026-11-18 10:06:29 +00:00
0210d523a2 fix(client): the tree name truncates in a box of its own