Updated on the same branch, so this PR carries the new contract: va and header instead of embed.
docs/visual-analytics.md- the URL section leads withva=1, explains that it implies a…
Show header is in Tab options at 59278cb, off by default.
Measured on the deployed app-loc rather than described:
- The four switches read, in order:…
Re-reviewed at d723290f: one commit since the 5aadaf45 review (feat(embed): split embed into header and va, and retire embed=va). Build-and-ng-test is green at this head, Build-and-test-development…
The embed switches are split, embed=va is deprecated, and legacy links are rewritten in place - d723290.
The contract now
va=1- the report drives this object: its parameters…
Reviewed the diff at 5aadaf45 (va-host.component.html, va-link.ts, va-link.spec.ts, styles.scss). Build-and-test-development is still running at this head, so this is a code review only.
-…
Reviewed the delta 0210d523...0c68707c. The only change since the last review is text-overflow: ellipsis coming off the .tree-lib / .tree-table group at client/src/styles.scss:6455, which…
Right - the twin had the same inert declaration. Head 0c68707c.
text-overflow: ellipsis is off the .designer-tree .tree-lib, .designer-tree .tree-table group as well; the group keeps…
Reviewed the diff at 0210d523 - the two tree-name spans and the stylesheet split they need.
- client/src/styles.scss:6457
text-overflow: ellipsis;is still declared on the row buttons in the…
Review 1357's finding is right, and it merged before the fix could land: #637's merge at 09:52:21 took 3678f8bc, and the truncation fix was pushed after that. It is carried by #638 against…