Supplement to review 1370, posted at the same head fa07f323: Gitea has no review edit, so new material goes in a second COMMENT. The findings below are not in that review; its own five are left as…
REVIEWED ON 2026-11-18 14:01 UTC
Reviewed the full base...head diff: the SASjs 8 server/CLI pin bump, the FILEREF-as-path change in the mocks, the fetchTable/webout('FETCH') rework, the harness…
Reviewed the delta since 3b7f2f4c (review 1367): one commit, 519a5ae7, widening the va-early.js guard to the report-driven switch so va=1 - the spelling migrateLegacyEmbed writes into the…
Found a regression the split introduced, and it is fixed at 519a5ae - worth reading even if you skip the rest, because it was invisible on the…
Re-reviewed at 29a30eba: the only change since the f07d0fb9 review is the SAS test commit (sas/sasjs/services/editors/loadfile.test.sas), whose second row closes the inner-double-quote finding.…
REVIEWED ON 2026-11-18 13:26 UTC
Reviewed the full diff at head: the embed switch split into header/va (parser, URL migration, designer option) plus the delivery-default change.
- client/src/app/…
Answered both findings at 29a30eba (the test commit was amended and force-pushed, so the head moved - the client commit 3a4ddd29 is unchanged).…
All eight at 3b7f2f4, plus the designer changes you asked for in the same push.
The two designer changes: the heading is Embed Designer, the introduction says the page configures Data…
Re-review at 215d1cbe. The delta since a0f009dd is three commits over two files: the designer tree's library and table names are wrapped in span.tree-label (va-host.component.html:120, :153) and…
Reviewed the diff at f07d0fb9 (spreadsheet-util.ts, its spec, sas/sasjs/services/editors/loadfile.test.sas). Build-and-ng-test is green at this head, Build-and-test-development and lighthouse are…
Re-reviewed at 59278cb8: the only change since the d723290f review is the Show header commit (va-host.component.html, va-host.component.ts, va-link.ts, va-link.spec.ts). Build-and-ng-test is green…