hermes pushed to feat/mock-fetch-inputs at dc/dc 2026-11-18 14:11:40 +00:00
5741b7ac12 chore(deps): take @sasjs/utils 4.13.1 for the fixed FETCH reader
hermes commented on pull request dc/dc#641 2026-11-18 14:03:06 +00:00
feat(mocks): read staged inputs and adapter tables through webout FETCH

Supplement to review 1370, posted at the same head fa07f323: Gitea has no review edit, so new material goes in a second COMMENT. The findings below are not in that review; its own five are left as…

hermes commented on pull request dc/dc#641 2026-11-18 14:01:25 +00:00
feat(mocks): read staged inputs and adapter tables through webout FETCH

REVIEWED ON 2026-11-18 14:01 UTC

Reviewed the full base...head diff: the SASjs 8 server/CLI pin bump, the FILEREF-as-path change in the mocks, the fetchTable/webout('FETCH') rework, the harness…

hermes created pull request dc/dc#641 2026-11-18 13:47:03 +00:00
feat(mocks): read staged inputs and adapter tables through webout FETCH
hermes pushed to feat/mock-fetch-inputs at dc/dc 2026-11-18 13:45:48 +00:00
fa07f323a3 chore(deps): move to @sasjs/cli 8 and SASjs Server 8
7b6bd72bcd feat(mocks): read staged inputs and adapter tables the way server 8 hands them
Compare 2 commits »
hermes created branch feat/mock-fetch-inputs in dc/dc 2026-11-18 13:45:48 +00:00
hermes commented on pull request dc/dc#639 2026-11-18 13:41:46 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Reviewed the delta since 3b7f2f4c (review 1367): one commit, 519a5ae7, widening the va-early.js guard to the report-driven switch so va=1 - the spelling migrateLegacyEmbed writes into the…

hermes commented on pull request dc/dc#639 2026-11-18 13:38:04 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Found a regression the split introduced, and it is fixed at 519a5ae - worth reading even if you skip the rest, because it was invisible on the…

hermes pushed to feat/embed-polish at dc/dc 2026-11-18 13:37:57 +00:00
519a5ae70d fix(embed): the early capture listens for the switch the designer now writes
hermes commented on pull request dc/dc#640 2026-11-18 13:30:17 +00:00
fix(client): quote values that hold a quote character in the upload csv

Re-reviewed at 29a30eba: the only change since the f07d0fb9 review is the SAS test commit (sas/sasjs/services/editors/loadfile.test.sas), whose second row closes the inner-double-quote finding.…

hermes commented on pull request dc/dc#639 2026-11-18 13:26:40 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

REVIEWED ON 2026-11-18 13:26 UTC

Reviewed the full diff at head: the embed switch split into header/va (parser, URL migration, designer option) plus the delivery-default change.

  • client/src/app/…
hermes commented on pull request dc/dc#640 2026-11-18 13:21:27 +00:00
fix(client): quote values that hold a quote character in the upload csv

Answered both findings at 29a30eba (the test commit was amended and force-pushed, so the head moved - the client commit 3a4ddd29 is unchanged).…

hermes pushed to fix/loadfile-quoted-values at dc/dc 2026-11-18 13:21:10 +00:00
29a30ebaf0 test(sas): cover loadfile with values that hold a quote character
hermes commented on pull request dc/dc#639 2026-11-18 13:17:55 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

All eight at 3b7f2f4, plus the designer changes you asked for in the same push.

The two designer changes: the heading is Embed Designer, the introduction says the page configures Data…

hermes pushed to feat/embed-polish at dc/dc 2026-11-18 13:11:14 +00:00
3b7f2f4c36 fix(embed): the page is the Embed Designer, and eight review findings
hermes commented on pull request dc/dc#481 2026-11-18 13:02:07 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Re-review at 215d1cbe. The delta since a0f009dd is three commits over two files: the designer tree's library and table names are wrapped in span.tree-label (va-host.component.html:120, :153) and…

hermes pushed to docs/embed-page at dc/docs.datacontroller.io 2026-11-18 12:59:26 +00:00
4d0b6a2024 docs(embed): the designer is the Embed Designer, and the tab description moved
hermes commented on pull request dc/dc#640 2026-11-18 12:44:35 +00:00
fix(client): quote values that hold a quote character in the upload csv

Reviewed the diff at f07d0fb9 (spreadsheet-util.ts, its spec, sas/sasjs/services/editors/loadfile.test.sas). Build-and-ng-test is green at this head, Build-and-test-development and lighthouse are…

hermes commented on pull request dc/dc#639 2026-11-18 12:44:28 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Re-reviewed at 59278cb8: the only change since the d723290f review is the Show header commit (va-host.component.html, va-host.component.ts, va-link.ts, va-link.spec.ts). Build-and-ng-test is green…

hermes created pull request dc/dc#640 2026-11-18 12:35:07 +00:00
fix(client): quote values that hold a quote character in the upload csv